Revert "x86/boot: Explicitly clean pcpu stacks in debug builds"

This reverts commit 8a3c4acc9907cfec9aae9f1bc251fbf50af6828e.
It's reportedly broken.

diff --git a/xen/arch/x86/boot/x86_64.S b/xen/arch/x86/boot/x86_64.S
index 399541d19a2e4bf059a17664d124274eb68f5d57..ed3888d4697515292bfda7afc9257b4dd5735cfb 100644 (file)
--- a/xen/arch/x86/boot/x86_64.S
+++ b/xen/arch/x86/boot/x86_64.S
@@ -13,15 +13,6 @@
         mov     mmu_cr4_features(%rip),%rcx
         mov     %rcx,%cr4
 
-#ifndef NDEBUG
-        /* Clean stack. */
-        mov     stack_start(%rip),%rdi
-        mov     $(STACK_SIZE / 8),%rcx
-        xor     %eax,%eax
-        rep stosq
-#endif
-
-        /* Switch to cpu0_stack. */
         mov     stack_start(%rip),%rsp
         or      $(STACK_SIZE-CPUINFO_sizeof),%rsp
 

diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c
index 8bfa151a401593ab7e2f1b4b0c1e6c54783ec1c1..9f81c7ba62ca7e2e77062ab4f0c5dfd2b6a3a6fe 100644 (file)
--- a/xen/arch/x86/smpboot.c
+++ b/xen/arch/x86/smpboot.c
@@ -659,10 +659,6 @@ static int cpu_smpboot_alloc(unsigned int cpu)
     stack_base[cpu] = alloc_xenheap_pages(STACK_ORDER, 0);
     if ( stack_base[cpu] == NULL )
         goto oom;
-#ifndef NDEBUG
-    for ( order = 0 ; order < (1<<STACK_ORDER); ++order )
-        clear_page(stack_base[cpu] + order * PAGE_SIZE);
-#endif
     memguard_guard_stack(stack_base[cpu]);
 
     order = get_order_from_pages(NR_RESERVED_GDT_PAGES);