Progress: Robust against bad 'completed' values #3579

Increasing the 'total' for bogus values of 'completed' is a bad idea.

diff --git a/src/libsync/progressdispatcher.cpp b/src/libsync/progressdispatcher.cpp
index 9627ff3140fea16cff98c3608b8fd5067a9887fc..b39b87c43647055b9606769c0a944c75f5fb9f3c 100644 (file)
--- a/src/libsync/progressdispatcher.cpp
+++ b/src/libsync/progressdispatcher.cpp
@@ -316,9 +316,8 @@ void ProgressInfo::Progress::update()
 
 void ProgressInfo::Progress::setCompleted(quint64 completed)
 {
-    _completed = completed;
-    _prevCompleted = qMin(_prevCompleted, completed);
-    _total = qMax(_total, completed);
+    _completed = qMin(completed, _total);
+    _prevCompleted = qMin(_prevCompleted, _completed);
 }