I understand this now, marking confirmed

diff --git a/doc/todo/Incremental_git_annex_sync_--content_--all.mdwn b/doc/todo/Incremental_git_annex_sync_--content_--all.mdwn
index 59e615b69ca0374a36ea15912a2565e69b3df0ae..8eb0fb7f05393e59a3ff1ac3a6d0950f9c4ed9a3 100644 (file)
--- a/doc/todo/Incremental_git_annex_sync_--content_--all.mdwn
+++ b/doc/todo/Incremental_git_annex_sync_--content_--all.mdwn
@@ -16,3 +16,5 @@ So I have yet another idea to speed up git annex. For now only for the 2nd pass
 
 1. In the 2nd pass of git annex sync --content --all, only look at keys whose location log changed since the last (full or incremental) sync via `git diff-tree -r --name-only <lowest recorded commit id of all remotes> git-annex`.
 2. Again, update the commit id of remotes that we successfully synced with.
+
+[[!tag confirmed]]

diff --git a/doc/todo/Incremental_git_annex_sync_--content_--all/comment_3_638f40462d4bb2a447350ce0a5dc7a92._comment b/doc/todo/Incremental_git_annex_sync_--content_--all/comment_3_638f40462d4bb2a447350ce0a5dc7a92._comment
new file mode 100644 (file)
index 0000000..5db686d
--- /dev/null
+++ b/doc/todo/Incremental_git_annex_sync_--content_--all/comment_3_638f40462d4bb2a447350ce0a5dc7a92._comment
@@ -0,0 +1,35 @@
+[[!comment format=mdwn
+ username="joey"
+ subject="""comment 3"""
+ date="2021-07-16T17:42:49Z"
+ content="""
+Thank you for rewording, which should not have been necessary, but seems to
+have helped my reading comprehension.
+
+This does seem like a good idea! That diff should be fast and if the
+location log changed, it needs to recheck preferred content against the
+changed situation, and if it didn't, we know preferred content will have
+the same result as currently applies. Elegant.
+
+I suppose it needs to record the branch tip for each remote, because
+different remotes can be synced at different times. It can record it
+locally, in a hidden ref or something.
+
+Your script checks for changes to the preferred-content.log etc 
+by storing a copy and comparing it with the current one. But since it knows
+the old git-annex branch tip, it can just request a diff of those files
+between the old and new shas, eg:
+
+       git diff-tree refs/annex/last-sync/origin/git-annex..git-annex --name-only -- preferred-content.log required-content.log etc
+
+If that outputs anything the logs changed and the optimisation can't be
+used.
+
+Weirdly, this will make --all often faster than not using --all, because it
+will be able to quickly see there is nothing to do. Occurs to me that
+the same method could be used to tell when a non-all sync is a no-op,
+and so speed up those, although only in the case where there was a previous
+--all sync. Or, it could record a tuple of (tree, git-annex branch), and
+use that to speed up non-all syncs, at least of the variety that don't
+operate on a specific list of files, but on a whole tree.
+"""]]