Constify config file QFileInfo, create directly in if statement

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

diff --git a/src/gui/accountmanager.cpp b/src/gui/accountmanager.cpp
index 2a96a3a60ad81a3a5fb3f8e7e7eb4203a807985c..95ba39b6305cadbc7080232209e5e6935594b961 100644 (file)
--- a/src/gui/accountmanager.cpp
+++ b/src/gui/accountmanager.cpp
@@ -172,11 +172,12 @@ bool AccountManager::restoreFromLegacySettings()
                                                       legacyCfgFileGrandParentFolder + legacyCfgFileRelativePath};
 
         for (const auto &configFile : legacyLocations) {
-            if (QFileInfo::exists(configFile)) {
+            if (const QFileInfo configFileInfo(configFile);
+                    configFileInfo.exists()) {
+
                 qCInfo(lcAccountManager) << "Migrate: checking old config " << configFile;
 
-                QFileInfo fi(configFile);
-                if (fi.isReadable()) {
+                if (configFileInfo.isReadable()) {
                     std::unique_ptr<QSettings> oCSettings(new QSettings(configFile, QSettings::IniFormat));
                     if (oCSettings->status() != QSettings::Status::NoError) {
                         qCInfo(lcAccountManager) << "Error reading legacy configuration file" << oCSettings->status();