fix-reproducible-builds-rocksdb
authorDebian MySQL Maintainers <pkg-mysql-maint@lists.alioth.debian.org>
Tue, 6 Jun 2023 14:09:17 +0000 (14:09 +0000)
committerPeter Michael Green <plugwash@raspbian.org>
Tue, 6 Jun 2023 14:09:17 +0000 (14:09 +0000)
Origin: https://github.com/facebook/rocksdb/commit/0a9a05ae12943b1529ef1eabbca5ce5a71c986bf

# Merged in RocksDB 6.19.3, but not updated into MariaDB yet
Bug: https://github.com/facebook/rocksdb/issues/7035
Author: Otto Kekäläinen <otto@kekalainen.net>
Subject: Make RocksDB build reproducible

The RocksDB binary included a string with the build timestamp:
> rocksdb_build_git_date:@2021-05-23·16:04:38@

As this changes from build to build, it makes the builds unreproducible.
Simply removing it solves the issue.

This temporary fix can be removed when a proper fix already done in upstream
lands in MariaDB when the RocksDB submodule is updated to a newer release.

Gbp-Pq: Name fix-reproducible-builds-rocksdb.patch

storage/rocksdb/rocksdb/util/build_version.cc.in

index 8569580188e20cdf8eba386ade37f101679f3db7..56a1235778a745a6039ad07cb386e09ec3a819d0 100644 (file)
@@ -1,5 +1,5 @@
 // Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
 #include "build_version.h"
-const char* rocksdb_build_git_sha = "rocksdb_build_git_sha:@@GIT_SHA@@";
-const char* rocksdb_build_git_date = "rocksdb_build_git_date:@@GIT_DATE_TIME@@";
-const char* rocksdb_build_compile_date = __DATE__;
+const char* rocksdb_build_git_sha = "rocksdb_build_git_sha:REDACTED";
+const char* rocksdb_build_git_date = "rocksdb_build_git_date:REDACTED";
+const char* rocksdb_build_compile_date = "REDACTED";