libxl/vsnd: add missing error checks
authorWei Liu <wei.liu2@citrix.com>
Tue, 10 Jul 2018 13:35:11 +0000 (14:35 +0100)
committerWei Liu <wei.liu2@citrix.com>
Tue, 10 Jul 2018 14:17:43 +0000 (15:17 +0100)
Reported-by: Coverity
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
tools/libxl/libxl_vsnd.c

index cf46e3ddb11d6051bed6fda6ed3764b6a9b10ffb..9570a4cf0edfb44459a6d6f8010422d0bc80d41f 100644 (file)
@@ -192,6 +192,7 @@ static int libxl__pcm_from_xenstore(libxl__gc *gc, const char *path,
                         GCSPRINTF("%s/"XENSND_FIELD_DEVICE_NAME, path), NULL);
 
     rc = libxl__params_from_xenstore(gc, path, &pcm->params);
+    if (rc) goto out;
 
     pcm->streams = NULL;
     pcm->num_vsnd_streams = 0;
@@ -253,6 +254,7 @@ static int libxl__vsnd_from_xenstore(libxl__gc *gc, const char *libxl_path,
                               fe_path), NULL);
 
     rc = libxl__params_from_xenstore(gc, fe_path, &vsnd->params);
+    if (rc) goto out;
 
     vsnd->pcms = NULL;
     vsnd->num_vsnd_pcms = 0;