Check reading from journal was successful before remove placeholder

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>

diff --git a/src/libsync/vfs/cfapi/vfs_cfapi.cpp b/src/libsync/vfs/cfapi/vfs_cfapi.cpp
index 925dacf35b3abb3aaef94a9f7c7e1d1df299cfb3..580c15b992bca54bfef5e3fca62806e662b4a885 100644 (file)
--- a/src/libsync/vfs/cfapi/vfs_cfapi.cpp
+++ b/src/libsync/vfs/cfapi/vfs_cfapi.cpp
@@ -363,16 +363,19 @@ void VfsCfApi::onHydrationJobFinished(HydrationJob *job)
 
 void VfsCfApi::onHydrationJobCanceled(HydrationJob *job)
 {
-    const auto folderPath = job->localPath();
     const auto folderRelativePath = job->folderPath();
+    SyncJournalFileRecord record;
+    if (!params().journal->getFileRecord(folderRelativePath, &record)) {
+        qCWarning(lcCfApi) << "Could not read file record from journal for canceled hydration request.";
+        return;
+    }
 
     // Remove placeholder file because there might be already pumped
     // some data into it
+    const auto folderPath = job->localPath();
     QFile::remove(folderPath + folderRelativePath);
 
     // Create a new placeholder file
-    SyncJournalFileRecord record;
-    params().journal->getFileRecord(folderRelativePath, &record);
     const auto item = SyncFileItem::fromSyncJournalFileRecord(record);
     createPlaceholder(*item);
 }