x86/mcheck: Drop unnecessary barriers
authorAndrew Cooper <andrew.cooper3@citrix.com>
Fri, 2 Dec 2016 15:00:41 +0000 (15:00 +0000)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Thu, 21 Dec 2017 10:57:16 +0000 (10:57 +0000)
spin_unlock() has full barrier semantics already.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
xen/arch/x86/cpu/mcheck/mctelem.c

index 492e2af77f65b87b9cc24d6a20c4043253df07b3..35431df3460e648766e8fc9fe5cd582ba2a15fa4 100644 (file)
@@ -520,7 +520,6 @@ mctelem_cookie_t mctelem_consume_oldest_begin(mctelem_class_t which)
        }
 
        mctelem_processing_hold(tep);
-       wmb();
        spin_unlock(&processing_lock);
        return MCTE2COOKIE(tep);
 }
@@ -531,7 +530,6 @@ void mctelem_consume_oldest_end(mctelem_cookie_t cookie)
 
        spin_lock(&processing_lock);
        mctelem_processing_release(tep);
-       wmb();
        spin_unlock(&processing_lock);
 }
 
@@ -547,7 +545,6 @@ void mctelem_ack(mctelem_class_t which, mctelem_cookie_t cookie)
        spin_lock(&processing_lock);
        if (tep == mctctl.mctc_processing_head[target])
                mctelem_processing_release(tep);
-       wmb();
        spin_unlock(&processing_lock);
 }