mem_event: Revert pointless, unrelated, and broken (on i386) change in 23434:ef410f262299
authorKeir Fraser <keir@xen.org>
Sat, 28 May 2011 07:33:54 +0000 (08:33 +0100)
committerKeir Fraser <keir@xen.org>
Sat, 28 May 2011 07:33:54 +0000 (08:33 +0100)
vcpu_pause() is nestable in the hypervisor, hence checking for
already-paused is not required.

Signed-off-by: Keir Fraser <keir@xen.org>
xen/arch/x86/hvm/hvm.c

index aa283cc1a5e1c0d14890f0c2fc26b2982e374254..9883c3fb7dae91e97ed0890404a712a99776fc62 100644 (file)
@@ -4068,21 +4068,11 @@ int hvm_debug_op(struct vcpu *v, int32_t op)
             rc = -ENOSYS;
             if ( !cpu_has_monitor_trap_flag )
                 break;
-
-            rc = mem_event_check_ring(v->domain);
-            /* rc ==0 p2m_mem_access_check() has already paused the vcpu */
-            if ( rc < 0 )
-                vcpu_pause(v);
-
+            rc = 0;
+            vcpu_pause(v);
             v->arch.hvm_vcpu.single_step =
                 (op == XEN_DOMCTL_DEBUG_OP_SINGLE_STEP_ON);
-
-            /* rc ==0 p2m_mem_access_resume() will unpause the vcpu */
-            if ( rc < 0 )
-            {
-                vcpu_unpause(v); /* guest will latch new state */
-                rc = 0;
-            }
+            vcpu_unpause(v); /* guest will latch new state */
             break;
         default:
             rc = -ENOSYS;