babl: remove more missing fast path warnings

We no longer want to warn, since warnings are also triggered when the
fast path is better than the best path found, something that happens
when we-re finding long paths and the reference is better.

Maybe we should still print warnings according to better heuristics to be able
to warn and encourage complete fast path coverage, fast paths should still be
able to beat the reference in a few steps.

diff --git a/babl/babl-fish-path.c b/babl/babl-fish-path.c
index 71f584d29b48dc95dfc705b25afb68c109017c3f..c3a22892ee2a8ffc4003e0fa73b2dcf7bfeb9111 100644 (file)
--- a/babl/babl-fish-path.c
+++ b/babl/babl-fish-path.c
@@ -599,11 +599,13 @@ babl_fish_path2 (const Babl *source,
     {
       get_conversion_path (&pc, (Babl *) source, 0, max_path_length () + 1, tolerance);
 
+#if 0
       if (babl->fish_path.conversion_list->count)
       {
         fprintf (stderr, "babl is using a rather long chain, room exists for optimization here\n");
         babl_list_each (babl->fish_path.conversion_list, show_item, NULL);
       }
+#endif
     }
 
     /* third attempt,. at path length + 2 */
@@ -611,11 +613,13 @@ babl_fish_path2 (const Babl *source,
         max_path_length () + 2 <= BABL_HARD_MAX_PATH_LENGTH)
     {
       get_conversion_path (&pc, (Babl *) source, 0, max_path_length () + 2, tolerance);
+#if 0
       if (babl->fish_path.conversion_list->count)
       {
         fprintf (stderr, "babl is using very long chain, should be optimized\n");
         babl_list_each (babl->fish_path.conversion_list, show_item, NULL);
       }
+#endif
     }
 
     babl_in_fish_path--;

diff --git a/babl/babl-fish.c b/babl/babl-fish.c
index a5306550b07150dd8c55d4dc873c0e55024455c2..65c482ed2ff9bb093a78814957e66dd001b5e229 100644 (file)
--- a/babl/babl-fish.c
+++ b/babl/babl-fish.c
@@ -297,8 +297,10 @@ babl_fish (const void *source,
             /* the dummy fish was created by the cache, and we need to manually
              * show a "missing fast path" warning for it on the first lookup.
              */
+#if 0
             _babl_fish_missing_fast_path_warning (ffish.fish_fish->fish.source,
                                                   ffish.fish_fish->fish.destination);
+#endif
 
             ffish.fish_fish->fish.data = NULL;
           }