Cleanup

diff --git a/src/bin/init.rs b/src/bin/init.rs
index 9252ddd3900f3f9e0ed49521d87312f35d46100c..4c3832e68df8d94c01d6f24a4acd2da69cdf12f6 100644 (file)
--- a/src/bin/init.rs
+++ b/src/bin/init.rs
@@ -56,17 +56,16 @@ pub fn execute(options: Options, config: &mut Config) -> CliResult {
 
     let path = &arg_path.unwrap_or_else(|| String::from("."));
     let opts = ops::NewOptions::new(flag_vcs,
-                                     flag_bin,
-                                     flag_lib,
-                                     path,
-                                     flag_name.as_ref().map(|s| s.as_ref()));
+                                    flag_bin,
+                                    flag_lib,
+                                    path,
+                                    flag_name.as_ref().map(|s| s.as_ref()));
 
     let opts_lib = opts.lib;
     ops::init(&opts, config)?;
 
-    config.shell().status("Created", format!("{} project",
-                                             if opts_lib { "library" }
-                                             else {"binary (application)"}))?;
+    let project_kind = if opts_lib { "library" } else { "binary (application)" };
+    config.shell().status("Created", format!("{} project", project_kind))?;
 
     Ok(())
 }

diff --git a/src/bin/new.rs b/src/bin/new.rs
index c006fd1e4d9407f62ae238e8df064d9d30c87c27..1e6342e2f6e50f9caebaa7af441e92d1817116c7 100644 (file)
--- a/src/bin/new.rs
+++ b/src/bin/new.rs
@@ -63,10 +63,8 @@ pub fn execute(options: Options, config: &mut Config) -> CliResult {
     let opts_lib = opts.lib;
     ops::new(&opts, config)?;
 
-    config.shell().status("Created", format!("{} `{}` project",
-                                             if opts_lib { "library" }
-                                             else {"binary (application)"},
-                                             arg_path))?;
+    let project_kind = if opts_lib { "library" } else { "binary (application)" };
+    config.shell().status("Created", format!("{} `{}` project", project_kind, arg_path))?;
 
     Ok(())
 }

diff --git a/src/cargo/ops/cargo_new.rs b/src/cargo/ops/cargo_new.rs
index 83dc8d045201609622c40b6b5d8c39becc5617be..9fbb8f853572ba64da10c919dd11d0b7b9776dff 100644 (file)
--- a/src/cargo/ops/cargo_new.rs
+++ b/src/cargo/ops/cargo_new.rs
@@ -62,25 +62,20 @@ impl<'de> Deserialize<'de> for VersionControl {
 
 impl<'a> NewOptions<'a> {
     pub fn new(version_control: Option<VersionControl>,
-           bin: bool,
-           lib: bool,
-           path: &'a str,
-           name: Option<&'a str>) -> NewOptions<'a> {
+               bin: bool,
+               lib: bool,
+               path: &'a str,
+               name: Option<&'a str>) -> NewOptions<'a> {
 
         // default to lib
-        let is_lib = if !bin {
-            true
-        }
-        else {
-            lib
-        };
+        let is_lib = !bin || lib;
 
         NewOptions {
-            version_control: version_control,
-            bin: bin,
+            version_control,
+            bin,
             lib: is_lib,
-            path: path,
-            name: name,
+            path,
+            name,
         }
     }
 }