GtkImage: Make resource property work properly
authorcedlemo <cedlemo@gmx.com>
Wed, 24 Jun 2015 13:59:00 +0000 (13:59 +0000)
committerMatthias Clasen <mclasen@redhat.com>
Thu, 25 Jun 2015 10:50:44 +0000 (06:50 -0400)
gtk_image_set_from_resource was setting the resource_path,
only to have it overwritten again before returning. That
is not as it should be, so change things to set the resource
path late.

https://bugzilla.gnome.org/show_bug.cgi?id=751443

gtk/gtkimage.c

index 5763f069150c3da094d4056a3a7bc9c188f584f7..032100d29b08f48d8fd754404ca7b9bef9107d79 100644 (file)
@@ -1015,8 +1015,6 @@ gtk_image_set_from_resource (GtkImage    *image,
       return;
     }
 
-  priv->resource_path = g_strdup (resource_path);
-
   if (gdk_pixbuf_animation_is_static_image (animation))
     gtk_image_set_from_pixbuf (image, gdk_pixbuf_animation_get_static_image (animation));
   else
@@ -1024,6 +1022,8 @@ gtk_image_set_from_resource (GtkImage    *image,
 
   _gtk_icon_helper_set_pixbuf_scale (priv->icon_helper, scale_factor);
 
+  priv->resource_path = g_strdup (resource_path);
+
   g_object_notify (G_OBJECT (image), "resource");
 
   g_object_unref (animation);