]> dgit.raspbian.org Git - nextcloud-desktop.git/commitdiff
Propagator: don't use dynamic_cast for QObject
authorOlivier Goffart <ogoffart@woboq.com>
Tue, 22 Nov 2016 16:25:42 +0000 (17:25 +0100)
committerOlivier Goffart <ogoffart@woboq.com>
Tue, 22 Nov 2016 16:37:41 +0000 (17:37 +0100)
qobject_cast is better. (no need to use RTTI when we have QMetaObject

src/libsync/owncloudpropagator.cpp

index 213896abe5fa4cbced6fc3e728f8229b20df84bc..f31aa167605cb42a8791e88f9683d44967fc4777 100644 (file)
@@ -314,7 +314,7 @@ void OwncloudPropagator::start(const SyncFileItemVector& items)
 
         if (!removedDirectory.isEmpty() && item->_file.startsWith(removedDirectory)) {
             // this is an item in a directory which is going to be removed.
-            PropagateDirectory *delDirJob = dynamic_cast<PropagateDirectory*>(directoriesToRemove.first());
+            PropagateDirectory *delDirJob = qobject_cast<PropagateDirectory*>(directoriesToRemove.first());
 
             if (item->_instruction == CSYNC_INSTRUCTION_REMOVE) {
                 // already taken care of. (by the removal of the parent directory)