Lock down TIOCSSERIAL

Lock down TIOCSSERIAL as that can be used to change the ioport and irq
settings on a serial port.  This only appears to be an issue for the serial
drivers that use the core serial code.  All other drivers seem to either
ignore attempts to change port/irq or give an error.

Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Jiri Slaby <jslaby@suse.com>

Gbp-Pq: Topic features/all/lockdown
Gbp-Pq: Name 0021-Lock-down-TIOCSSERIAL.patch

diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index 80bb56facfb684423e415e702e334fb97be152b1..3fab1da741f855922250d2352d35c86b03662c13 100644 (file)
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -836,6 +836,12 @@ static int uart_set_info(struct tty_struct *tty, struct tty_port *port,
        new_flags = (__force upf_t)new_info->flags;
        old_custom_divisor = uport->custom_divisor;
 
+       if ((change_port || change_irq) &&
+           kernel_is_locked_down("Using TIOCSSERIAL to change device addresses, irqs and dma channels")) {
+               retval = -EPERM;
+               goto exit;
+       }
+
        if (!capable(CAP_SYS_ADMIN)) {
                retval = -EPERM;
                if (change_irq || change_port ||