Code review markups.

diff --git a/src/cargo/ops/registry.rs b/src/cargo/ops/registry.rs
index eef46da9e20cd28107a8af0b191668837ce02f67..18f2d5cea6a948138c51b81ee9a1b9dcc46e6bf2 100644 (file)
--- a/src/cargo/ops/registry.rs
+++ b/src/cargo/ops/registry.rs
@@ -43,7 +43,10 @@ pub fn publish(ws: &Workspace, opts: &PublishOpts) -> CargoResult<()> {
     let pkg = ws.current()?;
 
     if let &Some(ref allowed_registries) = pkg.publish() {
-        if opts.registry.is_none() || !allowed_registries.contains(&opts.registry.clone().unwrap()) {
+        if !match opts.registry {
+            Some(ref registry) => allowed_registries.contains(registry),
+            None => false,
+        } {
             bail!("some crates cannot be published.\n\
                    `{}` is marked as unpublishable", pkg.name());
         }

diff --git a/tests/alt-registry.rs b/tests/alt-registry.rs
index fa8c15b8d998500ada6974d383f993c34a935275..430a37fcc53b2943a56c8b4e952c8b7487eefd87 100644 (file)
--- a/tests/alt-registry.rs
+++ b/tests/alt-registry.rs
@@ -73,7 +73,7 @@ fn depend_on_alt_registry() {
 }
 
 #[test]
-fn depend_on_alt_registry_depends_on_same_registry() {
+fn depend_on_alt_registry_depends_on_same_registry_no_index() {
     let p = project("foo")
         .file("Cargo.toml", r#"
             cargo-features = ["alternative-registries"]
@@ -107,6 +107,41 @@ fn depend_on_alt_registry_depends_on_same_registry() {
         reg = registry::alt_registry())));
 }
 
+#[test]
+fn depend_on_alt_registry_depends_on_same_registry() {
+    let p = project("foo")
+        .file("Cargo.toml", r#"
+            cargo-features = ["alternative-registries"]
+
+            [project]
+            name = "foo"
+            version = "0.0.1"
+            authors = []
+
+            [dependencies.bar]
+            version = "0.0.1"
+            registry = "alternative"
+        "#)
+        .file("src/main.rs", "fn main() {}")
+        .build();
+
+    Package::new("baz", "0.0.1").alternative(true).publish();
+    Package::new("bar", "0.0.1").registry_dep("baz", "0.0.1", registry::alt_registry().as_str()).alternative(true).publish();
+
+    assert_that(p.cargo("build").masquerade_as_nightly_cargo(),
+                execs().with_status(0).with_stderr(&format!("\
+[UPDATING] registry `{reg}`
+[DOWNLOADING] [..] v0.0.1 (registry `file://[..]`)
+[DOWNLOADING] [..] v0.0.1 (registry `file://[..]`)
+[COMPILING] baz v0.0.1 (registry `file://[..]`)
+[COMPILING] bar v0.0.1 (registry `file://[..]`)
+[COMPILING] foo v0.0.1 ({dir})
+[FINISHED] dev [unoptimized + debuginfo] target(s) in [..] secs
+",
+        dir = p.url(),
+        reg = registry::alt_registry())));
+}
+
 #[test]
 fn depend_on_alt_registry_depends_on_crates_io() {
     let p = project("foo")