Checksums: Explicitly close file before reporting result
authorChristian Kamm <mail@ckamm.de>
Mon, 23 Sep 2019 14:58:56 +0000 (16:58 +0200)
committerKevin Ottens <kevin.ottens@nextcloud.com>
Tue, 15 Dec 2020 09:59:00 +0000 (10:59 +0100)
To ensure it's no longer open when the finished signal fires.

src/common/checksums.cpp

index 258abe086f813dff055503e998dd7a23a815142a..462e2d3e5d8f7a8af711997c6e3e3becde7b7603 100644 (file)
@@ -261,7 +261,9 @@ void ComputeChecksum::startImpl(std::unique_ptr<QIODevice> device)
             }
             return QByteArray();
         }
-        return ComputeChecksum::computeNow(sharedDevice.data(), type);
+        auto result = ComputeChecksum::computeNow(sharedDevice.data(), type);
+        sharedDevice->close();
+        return result;
     }));
 }