tree-wide: Add error prefixing for most remaining syscalls

There were some important ones there like a random `syncfs()`. The remaining
users are mostly blocked on the "fstatat enoent" case, I'll wait to port those.

Closes: #1150
Approved by: jlebon

diff --git a/src/libostree/ostree-repo-commit.c b/src/libostree/ostree-repo-commit.c
index 6a5ba9dd3ada156ba3d57185bd2aaab2e5bea2cd..5d28dca888fcc998c84100dc71c8a822dcc3f467 100644 (file)
--- a/src/libostree/ostree-repo-commit.c
+++ b/src/libostree/ostree-repo-commit.c
@@ -1534,7 +1534,7 @@ ostree_repo_commit_transaction (OstreeRepo                  *self,
   if (g_getenv ("OSTREE_SUPPRESS_SYNCFS") == NULL)
     {
       if (syncfs (self->tmp_dir_fd) < 0)
-        return glnx_throw_errno (error);
+        return glnx_throw_errno_prefix (error, "syncfs");
     }
 
   if (!rename_pending_loose_objects (self, cancellable, error))
@@ -2798,8 +2798,8 @@ write_dfd_iter_to_mtree_internal (OstreeRepo                  *self,
   OstreeRepoCommitFilterResult filter_result;
   struct stat dir_stbuf;
 
-  if (fstat (src_dfd_iter->fd, &dir_stbuf) != 0)
-    return glnx_throw_errno (error);
+  if (!glnx_fstat (src_dfd_iter->fd, &dir_stbuf, error))
+    return FALSE;
 
   child_info = _ostree_stbuf_to_gfileinfo (&dir_stbuf);
 

diff --git a/src/libostree/ostree-repo.c b/src/libostree/ostree-repo.c
index 7ad2019eba91114bf5e57a36a315f684bea10824..6971d9b49a230cf816ce143d1ca992aa4896b867 100644 (file)
--- a/src/libostree/ostree-repo.c
+++ b/src/libostree/ostree-repo.c
@@ -1129,8 +1129,8 @@ impl_repo_remote_delete (OstreeRepo     *self,
 
   if (remote->file != NULL)
     {
-      if (unlink (gs_file_get_path_cached (remote->file)) != 0)
-        return glnx_throw_errno (error);
+      if (!glnx_unlinkat (AT_FDCWD, gs_file_get_path_cached (remote->file), 0, error))
+        return FALSE;
     }
   else
     {
@@ -2362,8 +2362,8 @@ ostree_repo_open (OstreeRepo    *self,
       /* Note - we don't return this error yet! */
     }
 
-  if (fstat (self->objects_dir_fd, &stbuf) != 0)
-    return glnx_throw_errno (error);
+  if (!glnx_fstat (self->objects_dir_fd, &stbuf, error))
+    return FALSE;
   self->owner_uid = stbuf.st_uid;
 
   if (stbuf.st_uid != getuid () || stbuf.st_gid != getgid ())
@@ -2749,8 +2749,8 @@ load_metadata_internal (OstreeRepo       *self,
 
   if (fd != -1)
     {
-      if (fstat (fd, &stbuf) < 0)
-        return glnx_throw_errno (error);
+      if (!glnx_fstat (fd, &stbuf, error))
+        return FALSE;
 
       if (out_variant)
         {
@@ -3173,7 +3173,7 @@ _ostree_repo_has_loose_object (OstreeRepo           *self,
           if (errno == ENOENT)
             ; /* Next dfd */
           else
-            return glnx_throw_errno (error);
+            return glnx_throw_errno_prefix (error, "fstatat(%s)", loose_path_buf);
         }
       else
         {
@@ -3696,7 +3696,7 @@ ostree_repo_load_commit (OstreeRepo            *self,
         }
       else if (errno != ENOENT)
         {
-          return glnx_throw_errno (error);
+          return glnx_throw_errno_prefix (error, "fstatat(%s)", commitpartial_path);
         }
     }
 

diff --git a/src/libostree/ostree-sepolicy.c b/src/libostree/ostree-sepolicy.c
index 6012d9da007fde79a61f10dc4d3ef76c39fe8d69..64670092ee885398fe3a420c2965a06b3271226c 100644 (file)
--- a/src/libostree/ostree-sepolicy.c
+++ b/src/libostree/ostree-sepolicy.c
@@ -521,7 +521,7 @@ ostree_sepolicy_get_label (OstreeSePolicy    *self,
       if (errno == ENOENT)
         *out_label = NULL;
       else
-        return glnx_throw_errno (error);
+        return glnx_throw_errno_prefix (error, "selabel_lookup");
     }
   else
     {

diff --git a/src/libostree/ostree-sysroot-deploy.c b/src/libostree/ostree-sysroot-deploy.c
index f50f24573a54711662008299abfbcd5c14737c4d..62ebd6b6e3b386266a4db405ed428e3736aa446a 100644 (file)
--- a/src/libostree/ostree-sysroot-deploy.c
+++ b/src/libostree/ostree-sysroot-deploy.c
@@ -171,8 +171,8 @@ copy_dir_recurse (int              src_parent_dfd,
     return FALSE;
 
   /* Create with mode 0700, we'll fchmod/fchown later */
-  if (mkdirat (dest_parent_dfd, name, 0700) != 0)
-    return glnx_throw_errno (error);
+  if (!glnx_ensure_dir (dest_parent_dfd, name, 0700, error))
+    return FALSE;
 
   if (!glnx_opendirat (dest_parent_dfd, name, TRUE, &dest_dfd, error))
     return FALSE;

diff --git a/src/libostree/ostree-sysroot.c b/src/libostree/ostree-sysroot.c
index 8e6c475c9864a152c479efa24ab3432758464d28..e8e299fe894c22873dfc69718f84844a5c6c146a 100644 (file)
--- a/src/libostree/ostree-sysroot.c
+++ b/src/libostree/ostree-sysroot.c
@@ -471,8 +471,8 @@ _ostree_sysroot_read_boot_loader_configs (OstreeSysroot *self,
       if (dent == NULL)
         break;
 
-      if (fstatat (dfd_iter.fd, dent->d_name, &stbuf, 0) != 0)
-        return glnx_throw_errno (error);
+      if (!glnx_fstatat (dfd_iter.fd, dent->d_name, &stbuf, 0, error))
+        return FALSE;
 
       if (g_str_has_prefix (dent->d_name, "ostree-") &&
           g_str_has_suffix (dent->d_name, ".conf") &&