[PATCH 1/2] submission: Fix settings leak on error paths in client_create_from_input()

Gbp-Pq: Name 0001-submission-Fix-settings-leak-on-error-paths-in-clien.patch

diff --git a/src/submission/main.c b/src/submission/main.c
index 00e6642510abe3ef905de6de6aa7b843e6e6f6af..3b110f4f4a5e52e3d2c2fa349780432b7f319a79 100644 (file)
--- a/src/submission/main.c
+++ b/src/submission/main.c
@@ -208,6 +208,7 @@ client_create_from_input(const struct mail_storage_service_input *input,
                        "(submission_relay_host is unset)";
                send_error(fd_out, event, set->hostname,
                           "4.3.5", MAIL_ERRSTR_CRITICAL_MSG);
+               settings_free(set);
                mail_user_deinit(&mail_user);
                event_unref(&event);
                return -1;
@@ -216,6 +217,7 @@ client_create_from_input(const struct mail_storage_service_input *input,
        if (ret < 0) {
                send_error(fd_out, event, my_hostname,
                        "4.7.0", MAIL_ERRSTR_CRITICAL_MSG);
+               settings_free(set);
                mail_user_deinit(&mail_user);
                event_unref(&event);
                return -1;