projects
/
gtk4.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
038a9b2
)
assistant: Fix a refcounting oversight
author
Matthias Clasen
<mclasen@redhat.com>
Fri, 8 Feb 2019 14:49:54 +0000
(09:49 -0500)
committer
Matthias Clasen
<mclasen@redhat.com>
Fri, 8 Feb 2019 14:51:45 +0000
(09:51 -0500)
The assistant needs to hold a ref on the pages.
gtk/gtkassistant.c
patch
|
blob
|
history
diff --git
a/gtk/gtkassistant.c
b/gtk/gtkassistant.c
index 12c38ea43f2166da8ed1f0574f71de1810bb9b0d..f20bbe0428822c8989bcaeab3ae2479de0a11bac 100644
(file)
--- a/
gtk/gtkassistant.c
+++ b/
gtk/gtkassistant.c
@@
-1773,6
+1773,8
@@
gtk_assistant_insert_page (GtkAssistant *assistant,
page_info->has_padding = TRUE;
return gtk_assistant_add_page (assistant, page_info, position);
+
+ g_object_unref (page_info);
}
static int
@@
-1815,7
+1817,7
@@
gtk_assistant_add_page (GtkAssistant *assistant,
if (position < 0 || position > n_pages)
position = n_pages;
- priv->pages = g_list_insert (priv->pages,
page_info
, position);
+ priv->pages = g_list_insert (priv->pages,
g_object_ref (page_info)
, position);
if (position == 0)
sibling = NULL;