arm64/arm64asm: recognise new ssbb/pssbb mnemonics from objdump
authorMichael Hudson-Doyle <michael.hudson@canonical.com>
Thu, 20 Sep 2018 07:20:31 +0000 (09:20 +0200)
committerSylvain Beucler <beuc@debian.org>
Thu, 20 Apr 2023 14:32:58 +0000 (15:32 +0100)
Fixes golang/go#27754

Change-Id: I8fcc3bc3c718cf0d93afbd1d383df48316b522d4
Reviewed-on: https://go-review.googlesource.com/136455
Run-TryBot: Michael Hudson-Doyle <michael.hudson@canonical.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Gbp-Pq: Name 0003-arm64-arm64asm-recognise-new-ssbb-pssbb-mnemonics-fr.patch

src/cmd/vendor/golang.org/x/arch/arm64/arm64asm/objdump_test.go

index 261c7cae5f92398786e119906ecd33a2a61594da..3baf8a19dd19d05ad6f2d30265200dd702beb606 100644 (file)
@@ -103,6 +103,13 @@ func allowedMismatchObjdump(text string, inst *Inst, dec ExtInst) bool {
                        return true
                }
        }
+       // New objdump supports some newer mnemonics than this package. This
+       // package should be updated to support the new mnemonics and the sense
+       // of this reversed to continue passing with older objdumps but that
+       // requires internal ARM tooling.
+       if newForm, ok := newMnemonics[text]; ok && newForm == dec.text {
+               return true
+       }
        // GNU objdump misses spaces between operands for some instructions (e.g., "ld1 {v10.2s, v11.2s}, [x23],#16")
        if strings.Replace(text, " ", "", -1) == strings.Replace(dec.text, " ", "", -1) {
                return true
@@ -148,3 +155,8 @@ var oldObjdumpMismatch = map[string]string{
        "strh":  "sturh",
        "prfm":  "prfum",
 }
+
+var newMnemonics = map[string]string{
+       "dsb #0x00": "ssbb",
+       "dsb #0x04": "pssbb",
+}