x86/ACPI: Insert missing newlines into FACS error messages
authorAndrew Cooper <andrew.cooper3@citrix.com>
Mon, 16 Aug 2021 13:24:44 +0000 (14:24 +0100)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Mon, 16 Aug 2021 14:58:31 +0000 (15:58 +0100)
Booting Xen as a PVH guest currently yields:

  (XEN) ACPI: SLEEP INFO: pm1x_cnt[1:b004,1:0], pm1x_evt[1:b000,1:0]
  (XEN) ACPI: FACS is not 64-byte aligned: 0xfc001010<2>ACPI: wakeup_vec[fc00101c], vec_size[20]
  (XEN) ACPI: Local APIC address 0xfee00000

Insert newlines as appropriate.

Fixes: d3faf9badf52 ("[host s3] Retrieve necessary sleep information from plain-text ACPI tables (FADT/FACS), and keep one hypercall remained for sleep notification.")
Fixes: 0f089bbf43ec ("x86/ACPI: fix S3 wakeup vector mapping")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
xen/arch/x86/acpi/boot.c

index ff4685279f68bef5a0378190dd12a2cc1f352671..8fe2d6fe0f4267f661cc54514dfa69d5006e9ae8 100644 (file)
@@ -432,19 +432,19 @@ acpi_fadt_parse_sleep_info(const struct acpi_table_fadt *fadt)
        }
 
        if (facs->length < 24) {
-               printk(KERN_ERR PREFIX "Invalid FACS table length: %#x",
+               printk(KERN_ERR PREFIX "Invalid FACS table length: %#x\n",
                        facs->length);
                goto done;
        }
 
        if (facs->length < 64)
                printk(KERN_WARNING PREFIX
-                       "FACS is shorter than ACPI spec allow: %#x",
+                       "FACS is shorter than ACPI spec allow: %#x\n",
                        facs->length);
 
        if (facs_pa % 64)
                printk(KERN_WARNING PREFIX
-                       "FACS is not 64-byte aligned: %#lx",
+                       "FACS is not 64-byte aligned: %#lx\n",
                        facs_pa);
 
        acpi_sinfo.wakeup_vector = facs_pa +