Fix leak when signing
authorAlexander Larsson <alexl@redhat.com>
Tue, 8 Sep 2020 09:37:33 +0000 (11:37 +0200)
committerAlexander Larsson <alexl@redhat.com>
Fri, 11 Sep 2020 09:45:33 +0000 (11:45 +0200)
_ostree_detached_metadata_append_gpg_sig() was returning a floating
ref, but all users were using g_autoptr. Fix it by adding a ref-sink.

src/libostree/ostree-core.c

index 523f57c00168b222a3721848538dc3ec39eb4896..29528fa51f33191439f14bbcc3eefa12993a89f5 100644 (file)
@@ -2675,7 +2675,7 @@ _ostree_detached_metadata_append_gpg_sig (GVariant   *existing_metadata,
                                _OSTREE_METADATA_GPGSIGS_NAME,
                                g_variant_builder_end (signature_builder));
 
-  return g_variant_dict_end (&metadata_dict);
+  return g_variant_ref_sink (g_variant_dict_end (&metadata_dict));
 }
 #endif /* OSTREE_DISABLE_GPGME */