depend on version of Win32 that exports c_createFile
authorJoey Hess <joeyh@joeyh.name>
Tue, 12 Jul 2022 20:28:01 +0000 (16:28 -0400)
committerJoey Hess <joeyh@joeyh.name>
Tue, 12 Jul 2022 20:28:01 +0000 (16:28 -0400)
doc/todo/windows__58___prepare_for_Win32_not_export_c__95___entities/comment_1_40985c5919f20fd47fa57caec09bfa3c._comment [new file with mode: 0644]
git-annex.cabal

diff --git a/doc/todo/windows__58___prepare_for_Win32_not_export_c__95___entities/comment_1_40985c5919f20fd47fa57caec09bfa3c._comment b/doc/todo/windows__58___prepare_for_Win32_not_export_c__95___entities/comment_1_40985c5919f20fd47fa57caec09bfa3c._comment
new file mode 100644 (file)
index 0000000..a034ce0
--- /dev/null
@@ -0,0 +1,19 @@
+[[!comment format=mdwn
+ username="joey"
+ subject="""comment 1"""
+ date="2022-07-12T19:59:54Z"
+ content="""
+We could go argue with the Win32 maintainer to put it back in.
+I have: <https://github.com/haskell/win32/issues/208>
+
+But it is a simple FFI implementation so I would not mind just including it
+in git-annex.
+
+... But also git-annex can depend on a version of Win32 before this
+breakage. I've made that change. It's perhaps only a stopgap, if something
+else that git-annex uses begins depending on the newer version of Win32
+later.
+
+Switching to LockFileEx seems like it might break interoperation with older
+git-annex versions?
+"""]]
index bd28fdee7e1b184965d90313cb37a095f68c8554..b1c101cec2e1c2830ba37bcff12cb9e07e22edc4 100644 (file)
@@ -402,7 +402,7 @@ Executable git-annex
 
   if (os(windows))
     Build-Depends:
-      Win32 (>= 2.6.1.0),
+      Win32 (>= 2.6.1.0 && < 2.12.0.0),
       setenv,
       process (>= 1.6.2.0),
       silently (>= 1.2.5.1)