amba_pl011: Insert mb() for correct FIFO handling

The pl011 register accessor functions use the _relaxed versions of the
standard readl() and writel() functions, meaning that there are no
automatic memory barriers. When polling a FIFO status register to check
for fullness, it is necessary to ensure that any outstanding writes have
completed; otherwise the flags are effectively stale, making it possible
that the next write is to a full FIFO.

Signed-off-by: Phil Elwell <phil@raspberrypi.org>

diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c
index 460c7d3e2962509a69eee5208ced765306b3bc7a..2f75eb7aa0b2432c20ff432b2549f3c3d29c520f 100644 (file)
--- a/drivers/tty/serial/amba-pl011.c
+++ b/drivers/tty/serial/amba-pl011.c
@@ -1384,6 +1384,7 @@ static bool pl011_tx_char(struct uart_amba_port *uap, unsigned char c,
                return false; /* unable to transmit character */
 
        pl011_write(c, uap, REG_DR);
+       mb();
        uap->port.icount.tx++;
 
        return true;