gtkgstpaintable: Handle a NULL value
authorTimm Bäder <mail@baedert.org>
Wed, 16 Feb 2022 09:01:13 +0000 (10:01 +0100)
committerTimm Bäder <mail@baedert.org>
Wed, 16 Feb 2022 09:02:24 +0000 (10:02 +0100)
gst_element_factory_make can return NULL.

modules/media/gtkgstpaintable.c

index aae52b03e590cabb9b2f11199629ef8f25044adb..0a4309b9d304a2c0c54799c0eb7bfbb84d60b1ce 100644 (file)
@@ -115,7 +115,7 @@ gtk_gst_paintable_video_renderer_create_video_sink (GstPlayerVideoRenderer *rend
                                                     GstPlayer              *player)
 {
   GtkGstPaintable *self = GTK_GST_PAINTABLE (renderer);
-  GstElement *sink, *glsinkbin;
+  GstElement *sink;
   GdkGLContext *ctx;
 
   sink = g_object_new (GTK_TYPE_GST_SINK,
@@ -128,7 +128,10 @@ gtk_gst_paintable_video_renderer_create_video_sink (GstPlayerVideoRenderer *rend
 
   if (self->context != NULL && ctx != NULL)
     {
-      glsinkbin = gst_element_factory_make ("glsinkbin", NULL);
+      GstElement *glsinkbin = gst_element_factory_make ("glsinkbin", NULL);
+
+      if (!glsinkbin)
+        return NULL;
 
       g_object_set (glsinkbin, "sink", sink, NULL);
       g_object_unref (ctx);