libxl: check for xc_domain_shutdown failure in libxl__domain_suspend_common_callback
authorMatthew Daley <mattjd@gmail.com>
Fri, 1 Nov 2013 00:30:44 +0000 (13:30 +1300)
committerIan Campbell <ian.campbell@citrix.com>
Fri, 1 Nov 2013 13:14:19 +0000 (13:14 +0000)
Coverity-ID: 1055048
Signed-off-by: Matthew Daley <mattjd@gmail.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
tools/libxl/libxl_dom.c

index c164469a071eb40a0f51d2c8109b9ed3ad4317c4..1812bdc07962b6b226665ca37ae77017974eaf58 100644 (file)
@@ -1041,7 +1041,11 @@ int libxl__domain_suspend_common_callback(void *user)
 
     if (dss->hvm && (!hvm_pvdrv || hvm_s_state)) {
         LOG(DEBUG, "Calling xc_domain_shutdown on HVM domain");
-        xc_domain_shutdown(CTX->xch, domid, SHUTDOWN_suspend);
+        ret = xc_domain_shutdown(CTX->xch, domid, SHUTDOWN_suspend);
+        if (ret < 0) {
+            LOGE(ERROR, "xc_domain_shutdown failed");
+            return 0;
+        }
         /* The guest does not (need to) respond to this sort of request. */
         dss->guest_responded = 1;
     } else {