macos: fix allocation for filechoosernative filter
authorChristian Hergert <christian@hergert.me>
Thu, 17 Feb 2022 20:39:21 +0000 (12:39 -0800)
committerChristian Hergert <christian@hergert.me>
Tue, 22 Feb 2022 19:53:33 +0000 (11:53 -0800)
The GtkFileCHooserNativeQuartz injects a NSComboBox into the NSSavePanel
(which is displayed in a remote process since 10.15 whether or not you are
a sandboxed application). The style has changed and we need more space
here to not clip part of the combobox out of view.

I tried every size from 22 to 30 and this seemed to look the most natural
without skewing the location of the text within the combobox.

gtk/gtkfilechoosernativequartz.c

index c004167a233656747fbdf61b64c44b12e84e42a6..3854937c0d5415382766f820ba6b46df6ceeece2 100644 (file)
@@ -300,7 +300,7 @@ filechooser_quartz_launch (FileChooserQuartzData *data)
   if (data->filters)
     {
       // when filters have been provided, a combobox needs to be added
-      data->filter_combo_box = [[NSComboBox alloc] initWithFrame:NSMakeRect(0.0, 0.0, 200, 20)];
+      data->filter_combo_box = [[NSComboBox alloc] initWithFrame:NSMakeRect(0, 0, 200, 24)];
       [data->filter_combo_box addItemsWithObjectValues:data->filter_names];
       [data->filter_combo_box setEditable:NO];
       [data->filter_combo_box setDelegate:[[FilterComboBox alloc] initWithData:data]];