Take ints by value rather than reference in UserModel methods

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>

diff --git a/src/gui/tray/usermodel.cpp b/src/gui/tray/usermodel.cpp
index 8c65468e361f12bd5b0509ae8d8f8a96b0b34cea..436fb42e4512093ff33cd768bd6dffaf4d0dd844 100644 (file)
--- a/src/gui/tray/usermodel.cpp
+++ b/src/gui/tray/usermodel.cpp
@@ -872,7 +872,7 @@ Q_INVOKABLE int UserModel::currentUserId() const
     return _currentUserId;
 }
 
-Q_INVOKABLE bool UserModel::isUserConnected(const int &id)
+Q_INVOKABLE bool UserModel::isUserConnected(const int id)
 {
     if (id < 0 || id >= _users.size())
         return false;
@@ -880,7 +880,7 @@ Q_INVOKABLE bool UserModel::isUserConnected(const int &id)
     return _users[id]->isConnected();
 }
 
-QImage UserModel::avatarById(const int &id)
+QImage UserModel::avatarById(const int id)
 {
     if (id < 0 || id >= _users.size())
         return {};
@@ -981,7 +981,7 @@ Q_INVOKABLE void UserModel::openCurrentAccountServer()
     QDesktopServices::openUrl(url);
 }
 
-Q_INVOKABLE void UserModel::switchCurrentUser(const int &id)
+Q_INVOKABLE void UserModel::switchCurrentUser(const int id)
 {
     if (_currentUserId < 0 || _currentUserId >= _users.size())
         return;
@@ -992,7 +992,7 @@ Q_INVOKABLE void UserModel::switchCurrentUser(const int &id)
     emit newUserSelected();
 }
 
-Q_INVOKABLE void UserModel::login(const int &id)
+Q_INVOKABLE void UserModel::login(const int id)
 {
     if (id < 0 || id >= _users.size())
         return;
@@ -1000,7 +1000,7 @@ Q_INVOKABLE void UserModel::login(const int &id)
     _users[id]->login();
 }
 
-Q_INVOKABLE void UserModel::logout(const int &id)
+Q_INVOKABLE void UserModel::logout(const int id)
 {
     if (id < 0 || id >= _users.size())
         return;
@@ -1008,7 +1008,7 @@ Q_INVOKABLE void UserModel::logout(const int &id)
     _users[id]->logout();
 }
 
-Q_INVOKABLE void UserModel::removeAccount(const int &id)
+Q_INVOKABLE void UserModel::removeAccount(const int id)
 {
     if (id < 0 || id >= _users.size())
         return;

diff --git a/src/gui/tray/usermodel.h b/src/gui/tray/usermodel.h
index afe7fe6d4b4d784a5bef75f94b814a4bea789c70..28a7eb9ac093401a7951224af6fd3ab73680f154 100644 (file)
--- a/src/gui/tray/usermodel.h
+++ b/src/gui/tray/usermodel.h
@@ -160,7 +160,7 @@ public:
 
     QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override;
 
-    QImage avatarById(const int &id);
+    QImage avatarById(const int id);
 
     User *currentUser() const;
 
@@ -173,11 +173,11 @@ public:
     Q_INVOKABLE int numUsers();
     Q_INVOKABLE QString currentUserServer();
     int currentUserId() const;
-    Q_INVOKABLE bool isUserConnected(const int &id);
-    Q_INVOKABLE void switchCurrentUser(const int &id);
-    Q_INVOKABLE void login(const int &id);
-    Q_INVOKABLE void logout(const int &id);
-    Q_INVOKABLE void removeAccount(const int &id);
+    Q_INVOKABLE bool isUserConnected(const int id);
+    Q_INVOKABLE void switchCurrentUser(const int id);
+    Q_INVOKABLE void login(const int id);
+    Q_INVOKABLE void logout(const int id);
+    Q_INVOKABLE void removeAccount(const int id);
 
     Q_INVOKABLE std::shared_ptr<OCC::UserStatusConnector> userStatusConnector(int id);