notebook: Don't trigger criticals in dispose
authorMatthias Clasen <mclasen@redhat.com>
Tue, 4 Feb 2020 21:42:44 +0000 (22:42 +0100)
committerMatthias Clasen <mclasen@redhat.com>
Wed, 5 Feb 2020 06:01:47 +0000 (01:01 -0500)
When we dismantle our children in dispose, we
trigger a11y children-changed signals which end
up calling back into the notebook. Handle this
without critical warnings.

gtk/gtknotebook.c

index 73486d71fb00ad19ee28f47dd3f0b067dedfb9eb..b3feea7fe367900e477770a1d89647b6b12870d1 100644 (file)
@@ -6544,7 +6544,8 @@ gtk_notebook_get_tab_label (GtkNotebook *notebook,
   g_return_val_if_fail (GTK_IS_WIDGET (child), NULL);
 
   list = gtk_notebook_find_child (notebook, child);
-  g_return_val_if_fail (list != NULL, NULL);
+  if (list == NULL)
+    return NULL;
 
   if (GTK_NOTEBOOK_PAGE_FROM_LIST (list)->default_tab)
     return NULL;