Fix conflicting definitions in anonymous namespace in Unity build
authorClaudio Cambra <claudio.cambra@nextcloud.com>
Thu, 15 Dec 2022 15:09:39 +0000 (16:09 +0100)
committerClaudio Cambra <claudio.cambra@gmail.com>
Thu, 15 Dec 2022 15:58:00 +0000 (16:58 +0100)
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
src/gui/folder.cpp
src/gui/folderman.cpp

index 3abb319ae835b414e8f7ed7347abb1ef34f0d918..0ed956f276f31e20fc06b94c4b29128a4d4e81fd 100644 (file)
@@ -49,7 +49,7 @@
 namespace {
 #ifndef VERSION_C
 #define VERSION_C
-constexpr auto versionC= "version";
+constexpr auto versionC = "version";
 #endif
 }
 namespace OCC {
index 44c5efdef9341661d0c8940ca1b38cbcdda9c25f..b6f9758dceaef464e7932d2882db50a36a644e52 100644 (file)
@@ -39,9 +39,9 @@
 #include <QNetworkProxy>
 
 namespace {
-constexpr auto accountsC = "Accounts";
-constexpr auto foldersC = "Folders";
-constexpr auto versionC = "version";
+constexpr auto settingsAccountsC = "Accounts";
+constexpr auto settingsFoldersC = "Folders";
+constexpr auto settingsVersionC = "version";
 constexpr auto maxFoldersVersion = 1;
 }
 
@@ -322,7 +322,7 @@ void FolderMan::setupFoldersHelper(QSettings &settings, AccountStatePtr account,
                     f->switchToVirtualFiles();
                 }
                 // Migrate the old "usePlaceholders" setting to the root folder pin state
-                if (settings.value(QLatin1String(versionC), 1).toInt() == 1
+                if (settings.value(QLatin1String(settingsVersionC), 1).toInt() == 1
                     && settings.value(QLatin1String("usePlaceholders"), false).toBool()) {
                     qCInfo(lcFolderMan) << "Migrate: From usePlaceholders to PinState::OnlineOnly";
                     f->setRootPinState(PinState::OnlineOnly);
@@ -377,11 +377,11 @@ void FolderMan::backwardMigrationSettingsKeys(QStringList *deleteKeys, QStringLi
 
     auto processSubgroup = [&](const QString &name) {
         settings->beginGroup(name);
-        const int foldersVersion = settings->value(QLatin1String(versionC), 1).toInt();
+        const int foldersVersion = settings->value(QLatin1String(settingsVersionC), 1).toInt();
         if (foldersVersion <= maxFoldersVersion) {
             foreach (const auto &folderAlias, settings->childGroups()) {
                 settings->beginGroup(folderAlias);
-                const int folderVersion = settings->value(QLatin1String(versionC), 1).toInt();
+                const int folderVersion = settings->value(QLatin1String(settingsVersionC), 1).toInt();
                 if (folderVersion > FolderDefinition::maxSettingsVersion()) {
                     ignoreKeys->append(settings->group());
                 }
@@ -518,12 +518,12 @@ Folder *FolderMan::setupFolderFromOldConfigFile(const QString &file, AccountStat
         return nullptr;
     }
 
-    settings.beginGroup(accountsC);
+    settings.beginGroup(settingsAccountsC);
     const auto rootChildGroups = settings.childGroups();
     for (const auto &accountId : rootChildGroups) {
         qCDebug(lcFolderMan) << "try to migrate accountId:" << accountId;
         settings.beginGroup(accountId);
-        settings.beginGroup(foldersC);
+        settings.beginGroup(settingsFoldersC);
 
         if (settings.childGroups().isEmpty()) {
             continue;