qt: use QString::setNum() rather than QString::sprintf()
authorSteve Lhomme <robux4@ycbcr.xyz>
Wed, 18 Dec 2024 10:57:05 +0000 (11:57 +0100)
committerSebastian Ramacher <sramacher@debian.org>
Tue, 21 Jan 2025 18:02:47 +0000 (19:02 +0100)
It's deprecated and one of the replacement suggested in the doc [^1].
QString::asprint() might be the more logical choice, but it's also not recommended [^2].

[^1] https://doc.qt.io/qt-5/qstring-obsolete.html#sprintf
[^2] https://doc.qt.io/qt-5/qstring.html#asprintf

Gbp-Pq: Name 0121-qt-use-QString-setNum-rather-than-QString-sprintf.patch

modules/gui/qt/menus.cpp

index 70a475fb37b047980a54735b834bc3a42b097c7d..a689b4cfcb68621ab1119ec4e640b0854ab06294 100644 (file)
@@ -1438,7 +1438,7 @@ int VLCMenuBar::CreateChoicesMenu( QMenu *submenu, const char *psz_var,
             case VLC_VAR_FLOAT:
                 var_Get( p_object, psz_var, &val );
                 if( CURTEXT ) menutext = qfue( CURTEXT );
-                else menutext.sprintf( "%.2f", CURVAL.f_float );
+                else menutext.setNum(CURVAL.f_float, 'f', 2);
                 CreateAndConnect( submenu, psz_var, menutext, "", RADIO_OR_COMMAND,
                         p_object, CURVAL, i_type,
                         CURVAL.f_float == val.f_float );