libxl: correctly handle readlink() errors
authorMatthew Daley <mattjd@gmail.com>
Tue, 10 Sep 2013 14:34:18 +0000 (02:34 +1200)
committerIan Campbell <ian.campbell@citrix.com>
Fri, 13 Sep 2013 12:14:41 +0000 (13:14 +0100)
readlink() returns a ssize_t with a negative value on failure.

Coverity-ID: 1055566
Signed-off-by: Matthew Daley <mattjd@gmail.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
tools/libxl/libxl_exec.c

index 98bfd716ace3a6e59d31b7382d08c07d7ece50a3..7eddaef2e3335bd3b9a96f1d820bfee7c60ea7ff 100644 (file)
@@ -33,7 +33,7 @@ static void check_open_fds(const char *what)
 
     for (i = 4; i < 256; i++) {
 #ifdef __linux__
-        size_t len;
+        ssize_t len;
         char path[PATH_MAX];
         char linkpath[PATH_MAX+1];
 #endif