builder: Use a better name for templates
authorMatthias Clasen <mclasen@redhat.com>
Wed, 29 Jan 2020 14:48:31 +0000 (15:48 +0100)
committerMatthias Clasen <mclasen@redhat.com>
Thu, 30 Jan 2020 09:04:38 +0000 (10:04 +0100)
This name can show up in error messages or profiler
traces, so it is nice to provide some hint what
file we are dealing with.
<GtkFileChoser template> is a lot more helpful
than <input>.

gtk/gtkbuilder.c

index b98ab3566cd332179000f4c51a72bafd031c31ec..90b54e864d84e33a6747d2d0181db600e17a5ccb 100644 (file)
@@ -1219,6 +1219,7 @@ gtk_builder_extend_with_template (GtkBuilder   *builder,
 {
   GtkBuilderPrivate *priv = gtk_builder_get_instance_private (builder);
   GError *tmp_error;
+  char *filename;
 
   g_return_val_if_fail (GTK_IS_BUILDER (builder), 0);
   g_return_val_if_fail (GTK_IS_WIDGET (widget), 0);
@@ -1234,11 +1235,13 @@ gtk_builder_extend_with_template (GtkBuilder   *builder,
   priv->resource_prefix = NULL;
   priv->template_type = template_type;
 
+  filename = g_strconcat ("<", g_type_name (template_type), " template>", NULL);
   gtk_builder_expose_object (builder, g_type_name (template_type), G_OBJECT (widget));
-  _gtk_builder_parser_parse_buffer (builder, "<input>",
+  _gtk_builder_parser_parse_buffer (builder, filename,
                                     buffer, length,
                                     NULL,
                                     &tmp_error);
+  g_free (filename);
 
   if (tmp_error != NULL)
     {