remote: Fix gcc `-fanalyzer` warning

In general, we're probably going to need to change most of our
`g_return_if_fail` to `g_assert`.  The analyzer flags that
the function can return `NULL`, but the caller isn't prepared for
this.

In practice, let's abort.

diff --git a/src/libostree/ostree-remote.c b/src/libostree/ostree-remote.c
index 2b068e15c148f45632af5e1a4f0282d307e31845..93c1a328d8f4d360d0c555475e1ecd6510aae4f2 100644 (file)
--- a/src/libostree/ostree-remote.c
+++ b/src/libostree/ostree-remote.c
@@ -65,8 +65,8 @@ ostree_remote_new_dynamic (const gchar *name,
 {
   OstreeRemote *remote;
 
-  g_return_val_if_fail (name != NULL && *name != '\0', NULL);
-  g_return_val_if_fail (refspec_name == NULL || *refspec_name != '\0', NULL);
+  g_assert (name != NULL && *name != '\0');
+  g_assert (refspec_name == NULL || *refspec_name != '\0');
 
   remote = g_slice_new0 (OstreeRemote);
   remote->ref_count = 1;