close bug

and mention another aspect of the reversion in changelog

diff --git a/CHANGELOG b/CHANGELOG
index 28ca0457a50d21a7c99acc0628a486fa776867d6..125811881836c3c2c111ce8ae6f191388a86c285 100644 (file)
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -6,7 +6,7 @@ git-annex (8.20210631) UNRELEASED; urgency=medium
   * --debug output goes to stderr again, not stdout.
     (Reversion in version 8.20210428)
   * init: Fix misbehavior when core.sharedRepository = group that
-    caused it to enter an adjusted branch.
+    caused it to enter an adjusted branch and set annex.crippledfilesystem
     (Reversion in version 8.20210630)
 
  -- Joey Hess <id@joeyh.name>  Wed, 30 Jun 2021 17:55:10 -0400

diff --git a/doc/bugs/regression__58___index.lck_in_shared-group_is_not_g+w.mdwn b/doc/bugs/regression__58___index.lck_in_shared-group_is_not_g+w.mdwn
index 67d0a0f8f7f706b456308acaabeea299f97b2c5b..56c7771f104fa6444842a0c6adf22beea1c36dcc 100644 (file)
--- a/doc/bugs/regression__58___index.lck_in_shared-group_is_not_g+w.mdwn
+++ b/doc/bugs/regression__58___index.lck_in_shared-group_is_not_g+w.mdwn
@@ -64,3 +64,5 @@ reference: https://github.com/datalad/datalad/issues/5759
 
 [[!meta author=yoh]]
 [[!tag projects/datalad]]
+
+> [[fixed|done]] --[[Joey]]

diff --git a/doc/bugs/regression__58___index.lck_in_shared-group_is_not_g+w/comment_4_3b19a1d3e0e13e407af476b54b725bd1._comment b/doc/bugs/regression__58___index.lck_in_shared-group_is_not_g+w/comment_4_3b19a1d3e0e13e407af476b54b725bd1._comment
new file mode 100644 (file)
index 0000000..ef5655e
--- /dev/null
+++ b/doc/bugs/regression__58___index.lck_in_shared-group_is_not_g+w/comment_4_3b19a1d3e0e13e407af476b54b725bd1._comment
@@ -0,0 +1,14 @@
+[[!comment format=mdwn
+ username="joey"
+ subject="""comment 4"""
+ date="2021-07-12T14:41:50Z"
+ content="""
+The bug was making init set annex.crippledfilesystem,
+and once that's set, git-annex avoids setting file
+perms, so then it writes index.lck it leaves it at the default permissions.
+
+That might or might not be a problem in some case (eg if some filesystem
+was detected as crippled but still supported file permissions to a point
+that write bits need to be added to support core.sharedRepository = group), but 
+the reversion was fixed by fixing init's behavior. So, closing this.
+"""]]