Always move final product to product path in mac crafter
authorClaudio Cambra <claudio.cambra@nextcloud.com>
Wed, 11 Sep 2024 19:48:28 +0000 (03:48 +0800)
committerbackportbot[bot] <backportbot[bot]@users.noreply.github.com>
Thu, 12 Sep 2024 05:17:36 +0000 (05:17 +0000)
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
admin/osx/mac-crafter/Sources/main.swift

index 25e1d824c50673acc7464fb1b7935503d49f2a2f..7e92f7878973169ddce9d83eb216a181edd1c8a3 100644 (file)
@@ -194,14 +194,11 @@ struct MacCrafter: ParsableCommand {
             throw MacCrafterError.craftError("Error crafting Nextcloud Desktop Client.")
         }
 
-        guard let codeSignIdentity else {
-            print("Crafted Nextcloud Desktop Client. Not codesigned.")
-            return
-        }
-
-        print("Code-signing Nextcloud Desktop Client libraries and frameworks...")
         let clientAppDir = "\(clientBuildDir)/image-\(buildType)-master/\(appName).app"
-        try codesignClientAppBundle(at: clientAppDir, withCodeSignIdentity: codeSignIdentity)
+        if let codeSignIdentity {
+            print("Code-signing Nextcloud Desktop Client libraries and frameworks...")
+            try codesignClientAppBundle(at: clientAppDir, withCodeSignIdentity: codeSignIdentity)
+        }
 
         print("Placing Nextcloud Desktop Client in \(productPath)...")
         if !fm.fileExists(atPath: productPath) {