firmware: Remove redundant log messages from drivers
authorBen Hutchings <ben@decadent.org.uk>
Sun, 9 Dec 2012 16:40:31 +0000 (16:40 +0000)
committerBen Hutchings <benh@debian.org>
Tue, 9 Jun 2020 17:50:00 +0000 (18:50 +0100)
Forwarded: no

Now that firmware_class logs every success and failure consistently,
many other log messages can be removed from drivers.

This will probably need to be split up into multiple patches prior to
upstream submission.

Gbp-Pq: Topic bugfix/all
Gbp-Pq: Name firmware-remove-redundant-log-messages-from-drivers.patch

154 files changed:
arch/x86/kernel/cpu/microcode/amd.c
drivers/atm/ambassador.c
drivers/atm/fore200e.c
drivers/bluetooth/ath3k.c
drivers/bluetooth/bcm203x.c
drivers/bluetooth/bfusb.c
drivers/bluetooth/bt3c_cs.c
drivers/bluetooth/btmrvl_sdio.c
drivers/char/dsp56k.c
drivers/dma/imx-sdma.c
drivers/gpu/drm/mga/mga_warp.c
drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
drivers/gpu/drm/r128/r128_cce.c
drivers/gpu/drm/radeon/ni.c
drivers/gpu/drm/radeon/r100.c
drivers/gpu/drm/radeon/r600.c
drivers/infiniband/hw/qib/qib_sd7220.c
drivers/input/touchscreen/atmel_mxt_ts.c
drivers/isdn/hardware/mISDN/speedfax.c
drivers/media/common/siano/smscoreapi.c
drivers/media/dvb-frontends/af9013.c
drivers/media/dvb-frontends/bcm3510.c
drivers/media/dvb-frontends/cx24116.c
drivers/media/dvb-frontends/drxd_hard.c
drivers/media/dvb-frontends/drxk_hard.c
drivers/media/dvb-frontends/ds3000.c
drivers/media/dvb-frontends/nxt200x.c
drivers/media/dvb-frontends/or51132.c
drivers/media/dvb-frontends/or51211.c
drivers/media/dvb-frontends/sp8870.c
drivers/media/dvb-frontends/sp887x.c
drivers/media/dvb-frontends/tda10048.c
drivers/media/dvb-frontends/tda1004x.c
drivers/media/dvb-frontends/tda10071.c
drivers/media/i2c/cx25840/cx25840-firmware.c
drivers/media/pci/bt8xx/bttv-cards.c
drivers/media/pci/cx18/cx18-av-firmware.c
drivers/media/pci/cx18/cx18-dvb.c
drivers/media/pci/cx18/cx18-firmware.c
drivers/media/pci/cx23885/cx23885-417.c
drivers/media/pci/cx23885/cx23885-cards.c
drivers/media/pci/cx88/cx88-blackbird.c
drivers/media/pci/ivtv/ivtv-firmware.c
drivers/media/pci/ngene/ngene-core.c
drivers/media/pci/saa7164/saa7164-fw.c
drivers/media/pci/ttpci/av7110.c
drivers/media/pci/ttpci/av7110_hw.c
drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c
drivers/media/radio/radio-wl1273.c
drivers/media/radio/wl128x/fmdrv_common.c
drivers/media/tuners/tuner-xc2028.c
drivers/media/usb/cpia2/cpia2_core.c
drivers/media/usb/cx231xx/cx231xx-417.c
drivers/media/usb/dvb-usb/dib0700_devices.c
drivers/media/usb/dvb-usb/dvb-usb-firmware.c
drivers/media/usb/dvb-usb/gp8psk.c
drivers/media/usb/dvb-usb/opera1.c
drivers/media/usb/go7007/go7007-driver.c
drivers/media/usb/go7007/go7007-fw.c
drivers/media/usb/go7007/go7007-loader.c
drivers/media/usb/gspca/vicam.c
drivers/media/usb/pvrusb2/pvrusb2-hdw.c
drivers/media/usb/s2255/s2255drv.c
drivers/media/usb/ttusb-budget/dvb-ttusb-budget.c
drivers/media/usb/ttusb-dec/ttusb_dec.c
drivers/misc/ti-st/st_kim.c
drivers/net/can/softing/softing_fw.c
drivers/net/ethernet/3com/typhoon.c
drivers/net/ethernet/adaptec/starfire.c
drivers/net/ethernet/alacritech/slicoss.c
drivers/net/ethernet/alteon/acenic.c
drivers/net/ethernet/broadcom/bnx2.c
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
drivers/net/ethernet/broadcom/tg3.c
drivers/net/ethernet/brocade/bna/cna_fwimg.c
drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c
drivers/net/ethernet/intel/e100.c
drivers/net/ethernet/myricom/myri10ge/myri10ge.c
drivers/net/ethernet/smsc/smc91c92_cs.c
drivers/net/ethernet/sun/cassini.c
drivers/net/hamradio/yam.c
drivers/net/usb/kaweth.c
drivers/net/wimax/i2400m/fw.c
drivers/net/wireless/ath/ath9k/hif_usb.c
drivers/net/wireless/ath/carl9170/usb.c
drivers/net/wireless/atmel/at76c50x-usb.c
drivers/net/wireless/atmel/atmel.c
drivers/net/wireless/broadcom/b43/main.c
drivers/net/wireless/broadcom/b43legacy/main.c
drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c
drivers/net/wireless/intel/ipw2x00/ipw2100.c
drivers/net/wireless/intel/ipw2x00/ipw2200.c
drivers/net/wireless/intel/iwlegacy/3945-mac.c
drivers/net/wireless/intel/iwlwifi/iwl-drv.c
drivers/net/wireless/intersil/orinoco/fw.c
drivers/net/wireless/intersil/orinoco/orinoco_usb.c
drivers/net/wireless/intersil/p54/p54pci.c
drivers/net/wireless/intersil/p54/p54spi.c
drivers/net/wireless/intersil/p54/p54usb.c
drivers/net/wireless/intersil/prism54/islpci_dev.c
drivers/net/wireless/marvell/libertas_tf/if_usb.c
drivers/net/wireless/marvell/mwifiex/main.c
drivers/net/wireless/marvell/mwl8k.c
drivers/net/wireless/ralink/rt2x00/rt2x00firmware.c
drivers/net/wireless/realtek/rtlwifi/core.c
drivers/net/wireless/realtek/rtlwifi/rtl8192se/sw.c
drivers/net/wireless/ti/wl1251/main.c
drivers/net/wireless/ti/wlcore/main.c
drivers/net/wireless/zydas/zd1201.c
drivers/net/wireless/zydas/zd1211rw/zd_usb.c
drivers/scsi/advansys.c
drivers/scsi/aic94xx/aic94xx_init.c
drivers/scsi/aic94xx/aic94xx_seq.c
drivers/scsi/bfa/bfad.c
drivers/scsi/ipr.c
drivers/scsi/pm8001/pm8001_ctl.c
drivers/scsi/qla1280.c
drivers/scsi/qla2xxx/qla_init.c
drivers/scsi/qla2xxx/qla_nx.c
drivers/scsi/qla2xxx/qla_os.c
drivers/scsi/qlogicpti.c
drivers/staging/rtl8192u/r819xU_firmware.c
drivers/staging/rtl8712/hal_init.c
drivers/staging/vt6656/firmware.c
drivers/tty/cyclades.c
drivers/tty/moxa.c
drivers/tty/serial/icom.c
drivers/tty/serial/ucc_uart.c
drivers/usb/atm/cxacru.c
drivers/usb/atm/ueagle-atm.c
drivers/usb/misc/emi26.c
drivers/usb/misc/ezusb.c
drivers/usb/misc/isight_firmware.c
drivers/usb/serial/io_edgeport.c
drivers/usb/serial/io_ti.c
drivers/usb/serial/ti_usb_3410_5052.c
drivers/video/fbdev/broadsheetfb.c
drivers/video/fbdev/metronomefb.c
sound/drivers/vx/vx_hwdep.c
sound/isa/msnd/msnd_pinnacle.c
sound/isa/sscape.c
sound/isa/wavefront/wavefront_synth.c
sound/pci/asihpi/hpidspcd.c
sound/pci/cs46xx/cs46xx_lib.c
sound/pci/echoaudio/echoaudio.c
sound/pci/emu10k1/emu10k1_main.c
sound/pci/hda/hda_intel.c
sound/pci/korg1212/korg1212.c
sound/pci/mixart/mixart_hwdep.c
sound/pci/pcxhr/pcxhr_hwdep.c
sound/pci/riptide/riptide.c
sound/pci/rme9652/hdsp.c
sound/soc/codecs/wm2000.c
sound/usb/6fire/firmware.c

index 3f6b137ef4e6e564bff9fe4e8fd5ad2913d5de2a..a02e17a9ae14bc7d78fa791b6c91776a3c58619b 100644 (file)
@@ -901,10 +901,8 @@ static enum ucode_state request_microcode_amd(int cpu, struct device *device,
        if (c->x86 >= 0x15)
                snprintf(fw_name, sizeof(fw_name), "amd-ucode/microcode_amd_fam%.2xh.bin", c->x86);
 
-       if (request_firmware_direct(&fw, (const char *)fw_name, device)) {
-               pr_debug("failed to load file %s\n", fw_name);
+       if (request_firmware_direct(&fw, (const char *)fw_name, device))
                goto out;
-       }
 
        ret = UCODE_ERROR;
        if (!verify_container(fw->data, fw->size, false))
index c039b8a4fefed1697add7cf53d4ef9fe240e4669..e28b965059c002301a18d682d85754de3cfe4d28 100644 (file)
@@ -1914,10 +1914,8 @@ static int ucode_init(loader_block *lb, amb_dev *dev)
   int res;
 
   res = request_ihex_firmware(&fw, "atmsar11.fw", &dev->pci_dev->dev);
-  if (res) {
-    PRINTK (KERN_ERR, "Cannot load microcode data");
+  if (res)
     return res;
-  }
 
   /* First record contains just the start address */
   rec = (const struct ihex_binrec *)fw->data;
index 8fbd36eb89410f1a337184b24fdb2fa345da00e1..eda13f94b0db2d9a486d344fe95584f8d8b5368e 100644 (file)
@@ -2425,10 +2425,9 @@ static int fore200e_load_and_start_fw(struct fore200e *fore200e)
     int err;
 
     sprintf(buf, "%s%s", fore200e->bus->proc_name, FW_EXT);
-    if ((err = request_firmware(&firmware, buf, fore200e->dev)) < 0) {
-       printk(FORE200E "problem loading firmware image %s\n", fore200e->bus->model_name);
+    err = request_firmware(&firmware, buf, fore200e->dev);
+    if (err)
        return err;
-    }
 
     fw_data = (const __le32 *)firmware->data;
     fw_size = firmware->size / sizeof(u32);
index 4ce2705136952f04e71fc4986e0aebcd7a980beb..a2945781827bed5ac95fe88f80f214c9a8512ddb 100644 (file)
@@ -417,10 +417,8 @@ static int ath3k_load_patch(struct usb_device *udev)
                 le32_to_cpu(fw_version.rom_version));
 
        ret = request_firmware(&firmware, filename, &udev->dev);
-       if (ret < 0) {
-               BT_ERR("Patch file not found %s", filename);
+       if (ret)
                return ret;
-       }
 
        pt_rom_version = get_unaligned_le32(firmware->data +
                                            firmware->size - 8);
@@ -480,10 +478,8 @@ static int ath3k_load_syscfg(struct usb_device *udev)
                le32_to_cpu(fw_version.rom_version), clk_value, ".dfu");
 
        ret = request_firmware(&firmware, filename, &udev->dev);
-       if (ret < 0) {
-               BT_ERR("Configuration file not found %s", filename);
+       if (ret)
                return ret;
-       }
 
        ret = ath3k_load_fwfile(udev, firmware);
        release_firmware(firmware);
index 3b176257b99314a0697c900b99fab49c41f06995..9f70b2588916b77615d8c730a20dcff4b2ecaa3b 100644 (file)
@@ -174,7 +174,6 @@ static int bcm203x_probe(struct usb_interface *intf, const struct usb_device_id
                return -ENOMEM;
 
        if (request_firmware(&firmware, "BCM2033-MD.hex", &udev->dev) < 0) {
-               BT_ERR("Mini driver request failed");
                usb_free_urb(data->urb);
                return -EIO;
        }
@@ -199,7 +198,6 @@ static int bcm203x_probe(struct usb_interface *intf, const struct usb_device_id
        release_firmware(firmware);
 
        if (request_firmware(&firmware, "BCM2033-FW.bin", &udev->dev) < 0) {
-               BT_ERR("Firmware request failed");
                usb_free_urb(data->urb);
                kfree(data->buffer);
                return -EIO;
index 0e5954cac98e0c69fca26e450e972f8424cfe548..970d414f3325dbfe418a0e0ad629693bd4b36e9f 100644 (file)
@@ -637,10 +637,8 @@ static int bfusb_probe(struct usb_interface *intf, const struct usb_device_id *i
        skb_queue_head_init(&data->pending_q);
        skb_queue_head_init(&data->completed_q);
 
-       if (request_firmware(&firmware, "bfubase.frm", &udev->dev) < 0) {
-               BT_ERR("Firmware request failed");
+       if (request_firmware(&firmware, "bfubase.frm", &udev->dev))
                goto done;
-       }
 
        BT_DBG("firmware data %p size %zu", firmware->data, firmware->size);
 
index 54713833951a9ddd6fa34780a263942863e242a2..341ed2d9be1e2625561087c3471c50967b8d953b 100644 (file)
@@ -569,10 +569,8 @@ static int bt3c_open(struct bt3c_info *info)
 
        /* Load firmware */
        err = request_firmware(&firmware, "BT3CPCC.bin", &info->p_dev->dev);
-       if (err < 0) {
-               BT_ERR("Firmware request failed");
+       if (err)
                goto error;
-       }
 
        err = bt3c_load_firmware(info, firmware->data, firmware->size);
 
index 0f3a020703ab233d871752f9c6f6d9bce7408f42..eef4e6a956c39ac0ec8bfed76625f72c3d3374e6 100644 (file)
@@ -526,8 +526,6 @@ static int btmrvl_sdio_download_helper(struct btmrvl_sdio_card *card)
        ret = request_firmware(&fw_helper, card->helper,
                                                &card->func->dev);
        if ((ret < 0) || !fw_helper) {
-               BT_ERR("request_firmware(helper) failed, error code = %d",
-                                                                       ret);
                ret = -ENOENT;
                goto done;
        }
@@ -626,8 +624,6 @@ static int btmrvl_sdio_download_fw_w_helper(struct btmrvl_sdio_card *card)
        ret = request_firmware(&fw_firmware, card->firmware,
                                                        &card->func->dev);
        if ((ret < 0) || !fw_firmware) {
-               BT_ERR("request_firmware(firmware) failed, error code = %d",
-                                                                       ret);
                ret = -ENOENT;
                goto done;
        }
index 06749e295adaff06e2770c296a5f2aeaa28a00d4..27cd3e4121a15908e58cff910a78d1197e9ae065 100644 (file)
@@ -140,11 +140,8 @@ static int dsp56k_upload(u_char __user *bin, int len)
        }
        err = request_firmware(&fw, fw_name, &pdev->dev);
        platform_device_unregister(pdev);
-       if (err) {
-               printk(KERN_ERR "Failed to load image \"%s\" err %d\n",
-                      fw_name, err);
+       if (err)
                return err;
-       }
        if (fw->size % 3) {
                printk(KERN_ERR "Bogus length %d in image \"%s\"\n",
                       fw->size, fw_name);
index 4d4477df4ede751a9b4277833d851dc48fe8641f..f5d13b29aeced56b5f1fc66f60119c0a302dfeef 100644 (file)
@@ -1735,11 +1735,8 @@ static void sdma_load_firmware(const struct firmware *fw, void *context)
        const struct sdma_script_start_addrs *addr;
        unsigned short *ram_code;
 
-       if (!fw) {
-               dev_info(sdma->dev, "external firmware not found, using ROM firmware\n");
-               /* In this case we just use the ROM firmware. */
+       if (!fw)
                return;
-       }
 
        if (fw->size < sizeof(*header))
                goto err_firmware;
index b5ef1d2c8b1c1044df0f2893330f84125b049787..cb0d2fa4c2a892b0eb662825406909b3d03cf9ed 100644 (file)
@@ -77,11 +77,8 @@ int mga_warp_install_microcode(drm_mga_private_t *dev_priv)
        }
        rc = request_ihex_firmware(&fw, firmware_name, &pdev->dev);
        platform_device_unregister(pdev);
-       if (rc) {
-               DRM_ERROR("mga: Failed to load microcode \"%s\"\n",
-                         firmware_name);
+       if (rc)
                return rc;
-       }
 
        size = 0;
        where = 0;
index f2f5636efac45e3959d7327c1d461197314707a3..0499f6a34a21dd89e03de0385e99fd29f3811785 100644 (file)
@@ -2445,10 +2445,8 @@ gf100_gr_load_fw(struct gf100_gr *gr, const char *name,
        if (ret) {
                snprintf(f, sizeof(f), "nouveau/%s", name);
                ret = request_firmware(&fw, f, device->dev);
-               if (ret) {
-                       nvkm_error(subdev, "failed to load %s\n", name);
+               if (ret)
                        return ret;
-               }
        }
 
        blob->size = fw->size;
index 138af32480d42cf0b1e812f0b34d8a9fcacf4ffa..be891fcd91ab51ce2bfc8fc568430d261501c82a 100644 (file)
@@ -162,11 +162,8 @@ static int r128_cce_load_microcode(drm_r128_private_t *dev_priv)
        }
        rc = request_firmware(&fw, FIRMWARE_NAME, &pdev->dev);
        platform_device_unregister(pdev);
-       if (rc) {
-               pr_err("r128_cce: Failed to load firmware \"%s\"\n",
-                      FIRMWARE_NAME);
+       if (rc)
                return rc;
-       }
 
        if (fw->size != 256 * 8) {
                pr_err("r128_cce: Bogus length %zu in firmware \"%s\"\n",
index 02feb0801fd3077b0826827169db38360396ac2e..663fcad69e229eff01b18bafead345fb97ae6a1f 100644 (file)
@@ -833,9 +833,6 @@ int ni_init_microcode(struct radeon_device *rdev)
 
 out:
        if (err) {
-               if (err != -EINVAL)
-                       pr_err("ni_cp: Failed to load firmware \"%s\"\n",
-                              fw_name);
                release_firmware(rdev->pfp_fw);
                rdev->pfp_fw = NULL;
                release_firmware(rdev->me_fw);
index 24c8db673931a9cd114c011e776f8e155d123c5c..ae3acbaa3d0c2416aba25e0a912df8b16d7e3557 100644 (file)
@@ -1047,9 +1047,7 @@ static int r100_cp_init_microcode(struct radeon_device *rdev)
        }
 
        err = request_firmware(&rdev->me_fw, fw_name, rdev->dev);
-       if (err) {
-               pr_err("radeon_cp: Failed to load firmware \"%s\"\n", fw_name);
-       } else if (rdev->me_fw->size % 8) {
+       if (err == 0 && rdev->me_fw->size % 8) {
                pr_err("radeon_cp: Bogus length %zu in firmware \"%s\"\n",
                       rdev->me_fw->size, fw_name);
                err = -EINVAL;
index d9a33ca768f345c2dcb34aa0bec01e705945d92a..6f2c599fd64b6915e861e1076f09baa2fd1fa7e5 100644 (file)
@@ -2599,9 +2599,6 @@ int r600_init_microcode(struct radeon_device *rdev)
 
 out:
        if (err) {
-               if (err != -EINVAL)
-                       pr_err("r600_cp: Failed to load firmware \"%s\"\n",
-                              fw_name);
                release_firmware(rdev->pfp_fw);
                rdev->pfp_fw = NULL;
                release_firmware(rdev->me_fw);
index 4f4a09c2dbcd31bd125e333a1357b9c8ee63c5bb..7bf90abe699c3e5bed0550aa5fe8974c4d7c47fd 100644 (file)
@@ -406,10 +406,8 @@ int qib_sd7220_init(struct qib_devdata *dd)
        }
 
        ret = request_firmware(&fw, SD7220_FW_NAME, &dd->pcidev->dev);
-       if (ret) {
-               qib_dev_err(dd, "Failed to load IB SERDES image\n");
+       if (ret)
                goto done;
-       }
 
        /* Substitute our deduced value for was_reset */
        ret = qib_ibsd_ucode_loaded(dd->pport, fw);
index ae60442efda0dcc29988d16ac32e3488c4e107ea..be0fbf9409ce826c2a3f909dceb4fcdc13dc0784 100644 (file)
@@ -2778,10 +2778,8 @@ static int mxt_load_fw(struct device *dev, const char *fn)
        int ret;
 
        ret = request_firmware(&fw, fn, dev);
-       if (ret) {
-               dev_err(dev, "Unable to open firmware %s\n", fn);
+       if (ret)
                return ret;
-       }
 
        /* Check for incorrect enc file */
        ret = mxt_check_firmware_format(dev, fw);
index b530c78eca8ee6128a0be626a1fb5735cd1af61b..a336db7a81355a550b1bb6e9213bcaf22eeee7ab 100644 (file)
@@ -379,11 +379,8 @@ setup_instance(struct sfax_hw *card)
        card->isar.owner = THIS_MODULE;
 
        err = request_firmware(&firmware, "isdn/ISAR.BIN", &card->pdev->dev);
-       if (err < 0) {
-               pr_info("%s: firmware request failed %d\n",
-                       card->name, err);
+       if (err)
                goto error_fw;
-       }
        if (debug & DEBUG_HW)
                pr_notice("%s: got firmware %zu bytes\n",
                          card->name, firmware->size);
index c1511094fdc7ba9c5563be46c0655cee060231a0..b5e915b21bafbc369f2de895ec1d4eeb65110ed6 100644 (file)
@@ -1156,10 +1156,8 @@ static int smscore_load_firmware_from_file(struct smscore_device_t *coredev,
                return -EINVAL;
 
        rc = request_firmware(&fw, fw_filename, coredev->device);
-       if (rc < 0) {
-               pr_err("failed to open firmware file '%s'\n", fw_filename);
+       if (rc < 0)
                return rc;
-       }
        pr_debug("read fw %s, buffer size=0x%zx\n", fw_filename, fw->size);
        fw_buf = kmalloc(ALIGN(fw->size + sizeof(struct sms_firmware),
                         SMS_ALLOC_ALIGNMENT), GFP_KERNEL | coredev->gfp_buf_flags);
index 7281899bd7ae3759cfa633b364fe3a85fa9f9081..a1ddafb4f21ac4590c956f720a9d3d9b9507892a 100644 (file)
@@ -1049,14 +1049,8 @@ static int af9013_download_firmware(struct af9013_state *state)
 
        /* Request the firmware, will block and timeout */
        ret = request_firmware(&firmware, name, &client->dev);
-       if (ret) {
-               dev_info(&client->dev, "firmware file '%s' not found %d\n",
-                        name, ret);
+       if (ret)
                goto err;
-       }
-
-       dev_info(&client->dev, "downloading firmware from file '%s'\n",
-                name);
 
        /* Write firmware checksum & size */
        for (i = 0; i < firmware->size; i++)
index e92542b92d3492430d56fdb9c71837a529d25f4f..cd10feb1f883d8e1d788c8edb1df7f662198e95b 100644 (file)
@@ -636,10 +636,9 @@ static int bcm3510_download_firmware(struct dvb_frontend* fe)
        int ret,i;
 
        deb_info("requesting firmware\n");
-       if ((ret = st->config->request_firmware(fe, &fw, BCM3510_DEFAULT_FIRMWARE)) < 0) {
-               err("could not load firmware (%s): %d",BCM3510_DEFAULT_FIRMWARE,ret);
+       ret = st->config->request_firmware(fe, &fw, BCM3510_DEFAULT_FIRMWARE);
+       if (ret)
                return ret;
-       }
        deb_info("got firmware: %zu\n", fw->size);
 
        b = fw->data;
index ea8264ccbb4e841c448f783ccec5327075124162..becc7dc68477d38eb115681b99989bba2382c538 100644 (file)
@@ -479,13 +479,8 @@ static int cx24116_firmware_ondemand(struct dvb_frontend *fe)
                        __func__, CX24116_DEFAULT_FIRMWARE);
                ret = request_firmware(&fw, CX24116_DEFAULT_FIRMWARE,
                        state->i2c->dev.parent);
-               printk(KERN_INFO "%s: Waiting for firmware upload(2)...\n",
-                       __func__);
-               if (ret) {
-                       printk(KERN_ERR "%s: No firmware uploaded (timeout or file not found?)\n",
-                              __func__);
+               if (ret)
                        return ret;
-               }
 
                /* Make sure we don't recurse back through here
                 * during loading */
index fae6f3763364aac9cf7983d43bf0a6e11ab4fe1b..751e240bad9f1b101312c462ed0061c77734a990 100644 (file)
@@ -891,10 +891,8 @@ static int load_firmware(struct drxd_state *state, const char *fw_name)
 {
        const struct firmware *fw;
 
-       if (request_firmware(&fw, fw_name, state->dev) < 0) {
-               printk(KERN_ERR "drxd: firmware load failure [%s]\n", fw_name);
+       if (request_firmware(&fw, fw_name, state->dev))
                return -EIO;
-       }
 
        state->microcode = kmemdup(fw->data, fw->size, GFP_KERNEL);
        if (!state->microcode) {
index 0a4875b391d9ca17a8c13a0aec7b904ccab85418..8d21a2cdff6d3911943d518c80c80f84318d9bc4 100644 (file)
@@ -6271,10 +6271,6 @@ static void load_firmware_cb(const struct firmware *fw,
 
        dprintk(1, ": %s\n", fw ? "firmware loaded" : "firmware not loaded");
        if (!fw) {
-               pr_err("Could not load firmware file %s.\n",
-                       state->microcode_name);
-               pr_info("Copy %s to your hotplug directory!\n",
-                       state->microcode_name);
                state->microcode_name = NULL;
 
                /*
index 20fcf31af1658b77aef94b1f193345d98602233c..d8008d58285455f31fc79f980fa3e30ba5206a1c 100644 (file)
@@ -348,12 +348,8 @@ static int ds3000_firmware_ondemand(struct dvb_frontend *fe)
                                DS3000_DEFAULT_FIRMWARE);
        ret = request_firmware(&fw, DS3000_DEFAULT_FIRMWARE,
                                state->i2c->dev.parent);
-       printk(KERN_INFO "%s: Waiting for firmware upload(2)...\n", __func__);
-       if (ret) {
-               printk(KERN_ERR "%s: No firmware uploaded (timeout or file not found?)\n",
-                      __func__);
+       if (ret)
                return ret;
-       }
 
        ret = ds3000_load_firmware(fe, fw);
        if (ret)
index 35b83b1dd82cee33ff43b0003fc9da6ec08519ef..564003075325f329bae91c44a014d76a9126c5e4 100644 (file)
@@ -876,12 +876,8 @@ static int nxt2002_init(struct dvb_frontend* fe)
                 __func__, NXT2002_DEFAULT_FIRMWARE);
        ret = request_firmware(&fw, NXT2002_DEFAULT_FIRMWARE,
                               state->i2c->dev.parent);
-       pr_debug("%s: Waiting for firmware upload(2)...\n", __func__);
-       if (ret) {
-               pr_err("%s: No firmware uploaded (timeout or file not found?)\n",
-                      __func__);
+       if (ret)
                return ret;
-       }
 
        ret = nxt2002_load_firmware(fe, fw);
        release_firmware(fw);
@@ -943,12 +939,8 @@ static int nxt2004_init(struct dvb_frontend* fe)
                 __func__, NXT2004_DEFAULT_FIRMWARE);
        ret = request_firmware(&fw, NXT2004_DEFAULT_FIRMWARE,
                               state->i2c->dev.parent);
-       pr_debug("%s: Waiting for firmware upload(2)...\n", __func__);
-       if (ret) {
-               pr_err("%s: No firmware uploaded (timeout or file not found?)\n",
-                      __func__);
+       if (ret)
                return ret;
-       }
 
        ret = nxt2004_load_firmware(fe, fw);
        release_firmware(fw);
index 35a3e47497c272c78188149c623c449b3d78e601..d89dd35059aafefff9d75b765a9c485befc8203d 100644 (file)
@@ -326,10 +326,8 @@ static int or51132_set_parameters(struct dvb_frontend *fe)
                printk("or51132: Waiting for firmware upload(%s)...\n",
                       fwname);
                ret = request_firmware(&fw, fwname, state->i2c->dev.parent);
-               if (ret) {
-                       printk(KERN_WARNING "or51132: No firmware uploaded(timeout or file not found?)\n");
+               if (ret)
                        return ret;
-               }
                ret = or51132_load_firmware(fe, fw);
                release_firmware(fw);
                if (ret) {
index ddcaea5c9941f41c2c0e5d2edcc676e1f0ed2f63..fb198eb3181a56c18abc804b3db469c45b9adcb3 100644 (file)
@@ -361,11 +361,8 @@ static int or51211_init(struct dvb_frontend* fe)
                        OR51211_DEFAULT_FIRMWARE);
                ret = config->request_firmware(fe, &fw,
                                               OR51211_DEFAULT_FIRMWARE);
-               pr_info("Got Hotplug firmware\n");
-               if (ret) {
-                       pr_warn("No firmware uploaded (timeout or file not found?)\n");
+               if (ret)
                        return ret;
-               }
 
                ret = or51211_load_firmware(fe, fw);
                release_firmware(fw);
index 655db8272268d56ef882393923515f8577bc3962..5c3ff08e924b755f4dcf7056bdbc533adb337ba5 100644 (file)
@@ -304,10 +304,8 @@ static int sp8870_init (struct dvb_frontend* fe)
 
        /* request the firmware, this will block until someone uploads it */
        printk("sp8870: waiting for firmware upload (%s)...\n", SP8870_DEFAULT_FIRMWARE);
-       if (state->config->request_firmware(fe, &fw, SP8870_DEFAULT_FIRMWARE)) {
-               printk("sp8870: no firmware upload (timeout or file not found?)\n");
+       if (state->config->request_firmware(fe, &fw, SP8870_DEFAULT_FIRMWARE))
                return -EIO;
-       }
 
        if (sp8870_firmware_upload(state, fw)) {
                printk("sp8870: writing firmware to device failed\n");
index c89a91a3daf404cb15130443e9e9788da8bcbcd3..9fdf51248c29704dbb3a5a77203bf0adb51ad2c4 100644 (file)
@@ -527,10 +527,8 @@ static int sp887x_init(struct dvb_frontend* fe)
                /* request the firmware, this will block until someone uploads it */
                printk("sp887x: waiting for firmware upload (%s)...\n", SP887X_DEFAULT_FIRMWARE);
                ret = state->config->request_firmware(fe, &fw, SP887X_DEFAULT_FIRMWARE);
-               if (ret) {
-                       printk("sp887x: no firmware upload (timeout or file not found?)\n");
+               if (ret)
                        return ret;
-               }
 
                ret = sp887x_initial_setup(fe, fw);
                release_firmware(fw);
index d1d206ebdedd79e5f161f3d1811f63f1ac02212c..110961be6a0c86b61d0e3566db854d8167db450c 100644 (file)
@@ -483,8 +483,6 @@ static int tda10048_firmware_upload(struct dvb_frontend *fe)
        ret = request_firmware(&fw, TDA10048_DEFAULT_FIRMWARE,
                state->i2c->dev.parent);
        if (ret) {
-               printk(KERN_ERR "%s: Upload failed. (file not found?)\n",
-                       __func__);
                return -EIO;
        } else {
                printk(KERN_INFO "%s: firmware read %zu bytes.\n",
index 83a798ca9b00290d03a39d3514b5280ad1750859..f36cc486edf7ffe56698c03dcfb0318f6f58d1d9 100644 (file)
@@ -388,10 +388,8 @@ static int tda10045_fwupload(struct dvb_frontend* fe)
        /* request the firmware, this will block until someone uploads it */
        printk(KERN_INFO "tda1004x: waiting for firmware upload (%s)...\n", TDA10045_DEFAULT_FIRMWARE);
        ret = state->config->request_firmware(fe, &fw, TDA10045_DEFAULT_FIRMWARE);
-       if (ret) {
-               printk(KERN_ERR "tda1004x: no firmware upload (timeout or file not found?)\n");
+       if (ret)
                return ret;
-       }
 
        /* reset chip */
        tda1004x_write_mask(state, TDA1004X_CONFC4, 0x10, 0);
@@ -532,7 +530,6 @@ static int tda10046_fwupload(struct dvb_frontend* fe)
                        /* remain compatible to old bug: try to load with tda10045 image name */
                        ret = state->config->request_firmware(fe, &fw, TDA10045_DEFAULT_FIRMWARE);
                        if (ret) {
-                               printk(KERN_ERR "tda1004x: no firmware upload (timeout or file not found?)\n");
                                return ret;
                        } else {
                                printk(KERN_INFO "tda1004x: please rename the firmware file to %s\n",
index 1953b00b3e48796e5c3d51408fcda585d5c34f34..d0804f6086a26b04d1700f3a7bb61337ade45b1f 100644 (file)
@@ -837,12 +837,8 @@ static int tda10071_init(struct dvb_frontend *fe)
 
                /* request the firmware, this will block and timeout */
                ret = request_firmware(&fw, fw_file, &client->dev);
-               if (ret) {
-                       dev_err(&client->dev,
-                               "did not find the firmware file '%s' (status %d). You can use <kernel_dir>/scripts/get_dvb_firmware to get the firmware\n",
-                               fw_file, ret);
+               if (ret)
                        goto error;
-               }
 
                /* init */
                for (i = 0; i < ARRAY_SIZE(tab2); i++) {
index 02df45ccf57c3abe8eb6ae308da6d7552bd113ad..9ce75298c6ec8a7c3f2ae9c4cd3c558d4926386d 100644 (file)
@@ -113,10 +113,8 @@ int cx25840_loadfw(struct i2c_client *client)
        if (is_cx231xx(state) && max_buf_size > 16)
                max_buf_size = 16;
 
-       if (request_firmware(&fw, fwname, FWDEV(client)) != 0) {
-               v4l_err(client, "unable to open firmware %s\n", fwname);
+       if (request_firmware(&fw, fwname, FWDEV(client)) != 0)
                return -EINVAL;
-       }
 
        start_fw_load(client);
 
index 16148802dabbf44f676bc259076089dbd46b70ac..c2afea668c667853082620b876f5100828055875 100644 (file)
@@ -3904,10 +3904,8 @@ static int pvr_boot(struct bttv *btv)
        int rc;
 
        rc = request_firmware(&fw_entry, "hcwamc.rbf", &btv->c.pci->dev);
-       if (rc != 0) {
-               pr_warn("%d: no altera firmware [via hotplug]\n", btv->c.nr);
+       if (rc != 0)
                return rc;
-       }
        rc = pvr_altera_load(btv, fw_entry->data, fw_entry->size);
        pr_info("%d: altera firmware upload %s\n",
                btv->c.nr, (rc < 0) ? "failed" : "ok");
index 61aeb8c9af7f835195be56db17605f804f299db9..b93b04885e0aff4559a09ede1c1a14ca70ba25f9 100644 (file)
@@ -70,10 +70,8 @@ int cx18_av_loadfw(struct cx18 *cx)
        int i;
        int retries1 = 0;
 
-       if (request_firmware(&fw, FWFILE, &cx->pci_dev->dev) != 0) {
-               CX18_ERR_DEV(sd, "unable to open firmware %s\n", FWFILE);
+       if (request_firmware(&fw, FWFILE, &cx->pci_dev->dev) != 0)
                return -EINVAL;
-       }
 
        /* The firmware load often has byte errors, so allow for several
           retries, both at byte level and at the firmware load level. */
index 4c57a294b9fa73301d1cc9efae5239132ecc2df8..5d4a00c8e2891c37379cdf3fd2258ac19b2ec885 100644 (file)
@@ -127,9 +127,7 @@ static int yuan_mpc718_mt352_reqfw(struct cx18_stream *stream,
        int ret;
 
        ret = request_firmware(fw, fn, &cx->pci_dev->dev);
-       if (ret)
-               CX18_ERR("Unable to open firmware file %s\n", fn);
-       else {
+       if (!ret) {
                size_t sz = (*fw)->size;
                if (sz < 2 || sz > 64 || (sz % 2) != 0) {
                        CX18_ERR("Firmware %s has a bad size: %lu bytes\n",
index 876b96c11290180b39249747195839272ef1a32a..098dafd22276d721d62281c47b0465247db314bd 100644 (file)
@@ -92,11 +92,8 @@ static int load_cpu_fw_direct(const char *fn, u8 __iomem *mem, struct cx18 *cx)
        u32 __iomem *dst = (u32 __iomem *)mem;
        const u32 *src;
 
-       if (request_firmware(&fw, fn, &cx->pci_dev->dev)) {
-               CX18_ERR("Unable to open firmware %s\n", fn);
-               CX18_ERR("Did you put the firmware in the hotplug firmware directory?\n");
+       if (request_firmware(&fw, fn, &cx->pci_dev->dev))
                return -ENOMEM;
-       }
 
        src = (const u32 *)fw->data;
 
@@ -137,8 +134,6 @@ static int load_apu_fw_direct(const char *fn, u8 __iomem *dst, struct cx18 *cx,
        int sz;
 
        if (request_firmware(&fw, fn, &cx->pci_dev->dev)) {
-               CX18_ERR("unable to open firmware %s\n", fn);
-               CX18_ERR("did you put the firmware in the hotplug firmware directory?\n");
                cx18_setup_page(cx, 0);
                return -ENOMEM;
        }
index 2327fe6126102e2975a6b5ee87e582dadd1a34a1..8440de7474dc9c8da70505d1230259dd69135a16 100644 (file)
@@ -920,12 +920,8 @@ static int cx23885_load_firmware(struct cx23885_dev *dev)
        retval = request_firmware(&firmware, CX23885_FIRM_IMAGE_NAME,
                                  &dev->pci->dev);
 
-       if (retval != 0) {
-               pr_err("ERROR: Hotplug firmware request failed (%s).\n",
-                      CX23885_FIRM_IMAGE_NAME);
-               pr_err("Please fix your hotplug setup, the board will not work without firmware loaded!\n");
+       if (retval != 0)
                return -1;
-       }
 
        if (firmware->size != CX23885_FIRM_IMAGE_SIZE) {
                pr_err("ERROR: Firmware size mismatch (have %zu, expected %d)\n",
index 8e5a2c580821ea51d0769e716581ae5e5ae0b517..e623eb5d7831a915b7b29084a32c611ba0641936 100644 (file)
@@ -2439,10 +2439,7 @@ void cx23885_card_setup(struct cx23885_dev *dev)
                        cinfo.rev, filename);
 
                ret = request_firmware(&fw, filename, &dev->pci->dev);
-               if (ret != 0)
-                       pr_err("did not find the firmware file '%s'. You can use <kernel_dir>/scripts/get_dvb_firmware to get the firmware.",
-                              filename);
-               else
+               if (ret == 0)
                        altera_init(&netup_config, fw);
 
                release_firmware(fw);
index d3da7f4297af8220ba9703fda996b9be1e1823a6..881ccc037de1b3b29cac8ec9ab3206bafe87313c 100644 (file)
@@ -462,12 +462,8 @@ static int blackbird_load_firmware(struct cx8802_dev *dev)
        retval = request_firmware(&firmware, CX2341X_FIRM_ENC_FILENAME,
                                  &dev->pci->dev);
 
-       if (retval != 0) {
-               pr_err("Hotplug firmware request failed (%s).\n",
-                      CX2341X_FIRM_ENC_FILENAME);
-               pr_err("Please fix your hotplug setup, the board will not work without firmware loaded!\n");
+       if (retval != 0)
                return -EIO;
-       }
 
        if (firmware->size != BLACKBIRD_FIRM_IMAGE_SIZE) {
                pr_err("Firmware size mismatch (have %zd, expected %d)\n",
index 56b25255faf5eb27ee42d71465438aedb4791791..ee9c227c4ec3b1352ed63707c210e421f6c9eed7 100644 (file)
@@ -68,8 +68,6 @@ retry:
                release_firmware(fw);
                return size;
        }
-       IVTV_ERR("Unable to open firmware %s (must be %ld bytes)\n", fn, size);
-       IVTV_ERR("Did you put the firmware in the hotplug firmware directory?\n");
        return -ENOMEM;
 }
 
index af15ca1c501bf47fb87e408267e72a4d93a8d73d..7198ab37a65545ae52bcc319194bf5ebaf95691b 100644 (file)
@@ -1236,19 +1236,14 @@ static int ngene_load_firm(struct ngene *dev)
                break;
        }
 
-       if (request_firmware(&fw, fw_name, &dev->pci_dev->dev) < 0) {
-               dev_err(pdev, "Could not load firmware file %s.\n", fw_name);
-               dev_info(pdev, "Copy %s to your hotplug directory!\n",
-                        fw_name);
+       if (request_firmware(&fw, fw_name, &dev->pci_dev->dev))
                return -1;
-       }
        if (size == 0)
                size = fw->size;
        if (size != fw->size) {
                dev_err(pdev, "Firmware %s has invalid size!", fw_name);
                err = -1;
        } else {
-               dev_info(pdev, "Loading firmware file %s.\n", fw_name);
                ngene_fw = (u8 *) fw->data;
                err = ngene_command_load_firmware(dev, ngene_fw, size);
        }
index 363689484c54a32d6892e78d808c72713d58f536..447fa2dab1b5d364236bb8cb67d9e0c714345571 100644 (file)
@@ -406,11 +406,8 @@ int saa7164_downloadfirmware(struct saa7164_dev *dev)
                        __func__, fwname);
 
                ret = request_firmware(&fw, fwname, &dev->pci->dev);
-               if (ret) {
-                       printk(KERN_ERR "%s() Upload failed. (file not found?)\n",
-                              __func__);
+               if (ret)
                        return -ENOMEM;
-               }
 
                printk(KERN_INFO "%s() firmware read %zu bytes.\n",
                        __func__, fw->size);
index d0cdee1c6eb0ba89c1713322e8724760c1235e30..9e5e444d2fbe1dd2b5be738f8f343f21f179bbbb 100644 (file)
@@ -1500,13 +1500,8 @@ static int get_firmware(struct av7110* av7110)
        /* request the av7110 firmware, this will block until someone uploads it */
        ret = request_firmware(&fw, "dvb-ttpci-01.fw", &av7110->dev->pci->dev);
        if (ret) {
-               if (ret == -ENOENT) {
-                       printk(KERN_ERR "dvb-ttpci: could not load firmware, file not found: dvb-ttpci-01.fw\n");
-                       printk(KERN_ERR "dvb-ttpci: usually this should be in /usr/lib/hotplug/firmware or /lib/firmware\n");
-                       printk(KERN_ERR "dvb-ttpci: and can be downloaded from https://linuxtv.org/download/dvb/firmware/\n");
-               } else
-                       printk(KERN_ERR "dvb-ttpci: cannot request firmware (error %i)\n",
-                              ret);
+               if (ret == -ENOENT)
+                       printk(KERN_ERR "dvb-ttpci: firmware can be downloaded from https://linuxtv.org/download/dvb/firmware/\n");
                return -EINVAL;
        }
 
index e8a8ec5405e2d2deead16144ef1512ae81ecb162..c26c21190a125bd7cd2eacd6fdde13c4c5a34bb9 100644 (file)
@@ -235,11 +235,8 @@ int av7110_bootarm(struct av7110 *av7110)
        //saa7146_setgpio(dev, 3, SAA7146_GPIO_INPUT);
 
        ret = request_firmware(&fw, fw_name, &dev->pci->dev);
-       if (ret) {
-               printk(KERN_ERR "dvb-ttpci: Failed to load firmware \"%s\"\n",
-                       fw_name);
+       if (ret)
                return ret;
-       }
 
        mwdebi(av7110, DEBISWAB, DPRAM_BASE, fw->data, fw->size);
        release_firmware(fw);
index da138c314963aba04eac10a5dc908675aadd73b6..226a1a2ecfbd77a7d23039c1085a5bc9d4c87e5e 100644 (file)
@@ -65,10 +65,8 @@ int s5p_mfc_load_firmware(struct s5p_mfc_dev *dev)
                }
        }
 
-       if (err != 0) {
-               mfc_err("Firmware is not present in the /lib/firmware directory nor compiled in kernel\n");
+       if (err != 0)
                return -EINVAL;
-       }
        if (fw_blob->size > dev->fw_buf.size) {
                mfc_err("MFC firmware is too big to be loaded\n");
                release_firmware(fw_blob);
index 1123768731676a0aaf0c8d2183f3607d5301ef5e..8123039379588c4a94747f9f390bc504c0720785 100644 (file)
@@ -502,11 +502,8 @@ static int wl1273_fm_upload_firmware_patch(struct wl1273_device *radio)
         * Uploading the firmware patch is not always necessary,
         * so we only print an info message.
         */
-       if (request_firmware(&fw_p, fw_name, dev)) {
-               dev_info(dev, "%s - %s not found\n", __func__, fw_name);
-
+       if (request_firmware(&fw_p, fw_name, dev))
                return 0;
-       }
 
        ptr = (__u8 *) fw_p->data;
        packet_num = ptr[0];
index cce97c9d54090e9d39cf78bbc006533124109c0b..23df585447bff3c00f83bbb29bcedda5f5cdb495 100644 (file)
@@ -1236,10 +1236,8 @@ static int fm_download_firmware(struct fmdev *fmdev, const u8 *fw_name)
 
        ret = request_firmware(&fw_entry, fw_name,
                                &fmdev->radio_dev->dev);
-       if (ret < 0) {
-               fmerr("Unable to read firmware(%s) content\n", fw_name);
+       if (ret)
                return ret;
-       }
        fmdbg("Firmware(%s) length : %zu bytes\n", fw_name, fw_entry->size);
 
        fw_data = (void *)fw_entry->data;
index 574c3bb135d7250f8c10144d8cf3f2b0ac8e8ab3..16ce85a02480ff44f4b0f8180b36dcbd73783adc 100644 (file)
@@ -1366,7 +1366,6 @@ static void load_firmware_cb(const struct firmware *fw,
 
        tuner_dbg("request_firmware_nowait(): %s\n", fw ? "OK" : "error");
        if (!fw) {
-               tuner_err("Could not load firmware %s.\n", priv->fname);
                priv->state = XC2028_NODEV;
                return;
        }
index 20c50c2d042e6386f9ef2eb3947d73421a4d4af9..b8a0812645168ff913b6b5c99ae9f207b8b4a531 100644 (file)
@@ -912,11 +912,8 @@ static int apply_vp_patch(struct camera_data *cam)
        struct cpia2_command cmd;
 
        ret = request_firmware(&fw, fw_name, &cam->dev->dev);
-       if (ret) {
-               printk(KERN_ERR "cpia2: failed to load VP patch \"%s\"\n",
-                      fw_name);
+       if (ret)
                return ret;
-       }
 
        cmd.req_mode = CAMERAACCESS_TYPE_REPEAT | CAMERAACCESS_VP;
        cmd.direction = TRANSFER_WRITE;
index 1aec4459f50abbdb009e499505b634ea75035645..e755b10f266c0cdb33426fa2e4c9e4a03a71094f 100644 (file)
@@ -983,11 +983,6 @@ static int cx231xx_load_firmware(struct cx231xx *dev)
                                  dev->dev);
 
        if (retval != 0) {
-               dev_err(dev->dev,
-                       "ERROR: Hotplug firmware request failed (%s).\n",
-                       CX231xx_FIRM_IMAGE_NAME);
-               dev_err(dev->dev,
-                       "Please fix your hotplug setup, the board will not work without firmware loaded!\n");
                vfree(p_current_fw);
                vfree(p_buffer);
                return retval;
index 4ef3fa98d20f4d985e8fd1dd4857640508832aa3..651d59e1747308cb63016afbc53a8d3c5a7b131d 100644 (file)
@@ -2413,12 +2413,9 @@ static int stk9090m_frontend_attach(struct dvb_usb_adapter *adap)
 
        dib9000_i2c_enumeration(&adap->dev->i2c_adap, 1, 0x10, 0x80);
 
-       if (request_firmware(&state->frontend_firmware, "dib9090.fw", &adap->dev->udev->dev)) {
-               deb_info("%s: Upload failed. (file not found?)\n", __func__);
+       if (request_firmware(&state->frontend_firmware, "dib9090.fw", &adap->dev->udev->dev))
                return -ENODEV;
-       } else {
-               deb_info("%s: firmware read %zu bytes.\n", __func__, state->frontend_firmware->size);
-       }
+       deb_info("%s: firmware read %zu bytes.\n", __func__, state->frontend_firmware->size);
        stk9090m_config.microcode_B_fe_size = state->frontend_firmware->size;
        stk9090m_config.microcode_B_fe_buffer = state->frontend_firmware->data;
 
@@ -2483,12 +2480,9 @@ static int nim9090md_frontend_attach(struct dvb_usb_adapter *adap)
        msleep(20);
        dib0700_set_gpio(adap->dev, GPIO0, GPIO_OUT, 1);
 
-       if (request_firmware(&state->frontend_firmware, "dib9090.fw", &adap->dev->udev->dev)) {
-               deb_info("%s: Upload failed. (file not found?)\n", __func__);
+       if (request_firmware(&state->frontend_firmware, "dib9090.fw", &adap->dev->udev->dev))
                return -EIO;
-       } else {
-               deb_info("%s: firmware read %zu bytes.\n", __func__, state->frontend_firmware->size);
-       }
+       deb_info("%s: firmware read %zu bytes.\n", __func__, state->frontend_firmware->size);
        nim9090md_config[0].microcode_B_fe_size = state->frontend_firmware->size;
        nim9090md_config[0].microcode_B_fe_buffer = state->frontend_firmware->data;
        nim9090md_config[1].microcode_B_fe_size = state->frontend_firmware->size;
index 42c207aacbb12ce90e0ea9d4cfce46996dcd93f8..95ca570054647fb72d4385e962f1531fbf73f4c8 100644 (file)
@@ -89,13 +89,9 @@ int dvb_usb_download_firmware(struct usb_device *udev, struct dvb_usb_device_pro
        int ret;
        const struct firmware *fw = NULL;
 
-       if ((ret = request_firmware(&fw, props->firmware, &udev->dev)) != 0) {
-               err("did not find the firmware file '%s' (status %d). You can use <kernel_dir>/scripts/get_dvb_firmware to get the firmware",
-                       props->firmware,ret);
+       ret = request_firmware(&fw, props->firmware, &udev->dev);
+       if (ret)
                return ret;
-       }
-
-       info("downloading firmware from file '%s'",props->firmware);
 
        switch (props->usb_ctrl) {
                case CYPRESS_AN2135:
index 1282f701f1857677f1b1a926c55d18cad2eb29d1..826923300c4ab6104a1da40cc7ba75c774df6abe 100644 (file)
@@ -131,19 +131,14 @@ static int gp8psk_load_bcm4500fw(struct dvb_usb_device *d)
        const u8 *ptr;
        u8 *buf;
        if ((ret = request_firmware(&fw, bcm4500_firmware,
-                                       &d->udev->dev)) != 0) {
-               err("did not find the bcm4500 firmware file '%s' (status %d). You can use <kernel_dir>/scripts/get_dvb_firmware to get the firmware",
-                       bcm4500_firmware,ret);
+                                       &d->udev->dev)) != 0)
                return ret;
-       }
 
        ret = -EINVAL;
 
        if (gp8psk_usb_out_op(d, LOAD_BCM4500,1,0,NULL, 0))
                goto out_rel_fw;
 
-       info("downloading bcm4500 firmware from file '%s'",bcm4500_firmware);
-
        ptr = fw->data;
        buf = kmalloc(64, GFP_KERNEL);
        if (!buf) {
index 823b33ae828d9de421c328092e0d05a1ee141d52..ccd7712df345d6f97b24c7121bbc239b46d1256c 100644 (file)
@@ -450,8 +450,6 @@ static int opera1_xilinx_load_firmware(struct usb_device *dev,
        info("start downloading fpga firmware %s",filename);
 
        if ((ret = request_firmware(&fw, filename, &dev->dev)) != 0) {
-               err("did not find the firmware file '%s'. You can use <kernel_dir>/scripts/get_dvb_firmware to get the firmware",
-                       filename);
                return ret;
        } else {
                p = kmalloc(fw->size, GFP_KERNEL);
index 153a0c3e3da6443f69144994bffcc483280a0e49..2b6ffdde39312fc7080e8aecb6a852f33fc837de 100644 (file)
@@ -84,10 +84,8 @@ static int go7007_load_encoder(struct go7007 *go)
        u16 intr_val, intr_data;
 
        if (go->boot_fw == NULL) {
-               if (request_firmware(&fw_entry, fw_name, go->dev)) {
-                       v4l2_err(go, "unable to load firmware from file \"%s\"\n", fw_name);
+               if (request_firmware(&fw_entry, fw_name, go->dev))
                        return -1;
-               }
                if (fw_entry->size < 16 || memcmp(fw_entry->data, "WISGO7007FW", 11)) {
                        v4l2_err(go, "file \"%s\" does not appear to be go7007 firmware\n", fw_name);
                        release_firmware(fw_entry);
index 018019ba47d46e9638a33dbc135e333e3b48c79a..2226047843c7b1d3b0c2ca06fbadc828c3d180b2 100644 (file)
@@ -1565,12 +1565,8 @@ int go7007_construct_fw_image(struct go7007 *go, u8 **fw, int *fwlen)
        default:
                return -1;
        }
-       if (request_firmware(&fw_entry, GO7007_FW_NAME, go->dev)) {
-               dev_err(go->dev,
-                       "unable to load firmware from file \"%s\"\n",
-                       GO7007_FW_NAME);
+       if (request_firmware(&fw_entry, GO7007_FW_NAME, go->dev))
                return -1;
-       }
        code = kcalloc(codespace, 2, GFP_KERNEL);
        if (code == NULL)
                goto fw_failed;
index 243aa0ad074c8527002f3656022b6647967bc0a8..575bddaa61db1ce9620748fcf4ebb69347146baf 100644 (file)
@@ -67,11 +67,8 @@ static int go7007_loader_probe(struct usb_interface *interface,
 
        dev_info(&interface->dev, "loading firmware %s\n", fw1);
 
-       if (request_firmware(&fw, fw1, &usbdev->dev)) {
-               dev_err(&interface->dev,
-                       "unable to load firmware from file \"%s\"\n", fw1);
+       if (request_firmware(&fw, fw1, &usbdev->dev))
                goto failed2;
-       }
        ret = cypress_load_firmware(usbdev, fw, CYPRESS_FX2);
        release_firmware(fw);
        if (0 != ret) {
@@ -82,11 +79,8 @@ static int go7007_loader_probe(struct usb_interface *interface,
        if (fw2 == NULL)
                return 0;
 
-       if (request_firmware(&fw, fw2, &usbdev->dev)) {
-               dev_err(&interface->dev,
-                       "unable to load firmware from file \"%s\"\n", fw2);
+       if (request_firmware(&fw, fw2, &usbdev->dev))
                goto failed2;
-       }
        ret = cypress_load_firmware(usbdev, fw, CYPRESS_FX2);
        release_firmware(fw);
        if (0 != ret) {
index 179b2ec3df57c97c8072ee3e3f353889171b485f..45b24bd52cb518e6c942d8b41932af7d8bf1dd87 100644 (file)
@@ -230,10 +230,8 @@ static int sd_init(struct gspca_dev *gspca_dev)
 
        ret = request_ihex_firmware(&fw, VICAM_FIRMWARE,
                                    &gspca_dev->dev->dev);
-       if (ret) {
-               pr_err("Failed to load \"vicam/firmware.fw\": %d\n", ret);
+       if (ret)
                return ret;
-       }
 
        firmware_buf = kmalloc(PAGE_SIZE, GFP_KERNEL);
        if (!firmware_buf) {
index 1cfb7cf64131aa652f09f79b31a05b591aa3a9ad..04e52705366ab98226d4d4e2532d852ba58667bd 100644 (file)
@@ -1371,25 +1371,6 @@ static int pvr2_locate_firmware(struct pvr2_hdw *hdw,
                           "request_firmware fatal error with code=%d",ret);
                return ret;
        }
-       pvr2_trace(PVR2_TRACE_ERROR_LEGS,
-                  "***WARNING*** Device %s firmware seems to be missing.",
-                  fwtypename);
-       pvr2_trace(PVR2_TRACE_ERROR_LEGS,
-                  "Did you install the pvrusb2 firmware files in their proper location?");
-       if (fwcount == 1) {
-               pvr2_trace(PVR2_TRACE_ERROR_LEGS,
-                          "request_firmware unable to locate %s file %s",
-                          fwtypename,fwnames[0]);
-       } else {
-               pvr2_trace(PVR2_TRACE_ERROR_LEGS,
-                          "request_firmware unable to locate one of the following %s files:",
-                          fwtypename);
-               for (idx = 0; idx < fwcount; idx++) {
-                       pvr2_trace(PVR2_TRACE_ERROR_LEGS,
-                                  "request_firmware: Failed to find %s",
-                                  fwnames[idx]);
-               }
-       }
        return ret;
 }
 
index 329ec808959276dc0e224ae3cb044173cdb4437b..2d7b23d42f41e43391e852af8e3aec1a05839fdc 100644 (file)
@@ -2278,10 +2278,8 @@ static int s2255_probe(struct usb_interface *interface,
        }
        /* load the first chunk */
        if (request_firmware(&dev->fw_data->fw,
-                            FIRMWARE_FILE_NAME, &dev->udev->dev)) {
-               dev_err(&interface->dev, "sensoray 2255 failed to get firmware\n");
+                            FIRMWARE_FILE_NAME, &dev->udev->dev))
                goto errorREQFW;
-       }
        /* check the firmware is valid */
        fw_size = dev->fw_data->fw->size;
        pdata = (__le32 *) &dev->fw_data->fw->data[fw_size - 8];
index 4e56ff83566bbfcc7299241895d07279a0876443..fe8224361a646752f1fabb94345a5929e1e170da 100644 (file)
@@ -291,10 +291,8 @@ static int ttusb_boot_dsp(struct ttusb *ttusb)
 
        err = request_firmware(&fw, "ttusb-budget/dspbootcode.bin",
                               &ttusb->dev->dev);
-       if (err) {
-               printk(KERN_ERR "ttusb-budget: failed to request firmware\n");
+       if (err)
                return err;
-       }
 
        /* BootBlock */
        b[0] = 0xaa;
index 3198f9624b7c05ab423db6f7bf77bf551c0254b1..1547aa109e27d009fee7d1e2a8b207b268c06ab7 100644 (file)
@@ -1324,11 +1324,8 @@ static int ttusb_dec_boot_dsp(struct ttusb_dec *dec)
        dprintk("%s\n", __func__);
 
        result = request_firmware(&fw_entry, dec->firmware_name, &dec->udev->dev);
-       if (result) {
-               printk(KERN_ERR "%s: Firmware (%s) unavailable.\n",
-                      __func__, dec->firmware_name);
+       if (result)
                return result;
-       }
 
        firmware = fw_entry->data;
        firmware_size = fw_entry->size;
index a36ed1ff5967f079d983a2853202eea8788ad524..f80321b4a3178408c6d9620b74e2ab74c73cdeae 100644 (file)
@@ -288,11 +288,8 @@ static long download_firmware(struct kim_data_s *kim_gdata)
            request_firmware(&kim_gdata->fw_entry, bts_scr_name,
                             &kim_gdata->kim_pdev->dev);
        if (unlikely((err != 0) || (kim_gdata->fw_entry->data == NULL) ||
-                    (kim_gdata->fw_entry->size == 0))) {
-               pr_err(" request_firmware failed(errno %ld) for %s", err,
-                          bts_scr_name);
+                    (kim_gdata->fw_entry->size == 0)))
                return -EINVAL;
-       }
        ptr = (void *)kim_gdata->fw_entry->data;
        len = kim_gdata->fw_entry->size;
        /* bts_header to remove out magic number and
index 8f44fdd8804bf8902174395210ca1b7a1902c844..9490198e6dcbfa41bddb5178edafa8c62869f962 100644 (file)
@@ -226,11 +226,8 @@ int softing_load_app_fw(const char *file, struct softing *card)
        int8_t type_end = 0, type_entrypoint = 0;
 
        ret = request_firmware(&fw, file, &card->pdev->dev);
-       if (ret) {
-               dev_alert(&card->pdev->dev, "request_firmware(%s) got %i\n",
-                       file, ret);
+       if (ret)
                return ret;
-       }
        dev_dbg(&card->pdev->dev, "firmware(%s) got %lu bytes\n",
                file, (unsigned long)fw->size);
        /* parse the firmware */
index 14fce6658106cd7fd8306d4655340163c5a1ae1f..8b84ed32fe35c2ea79d5771ad5c2b7e502a1723c 100644 (file)
@@ -1283,11 +1283,8 @@ typhoon_request_firmware(struct typhoon *tp)
                return 0;
 
        err = request_firmware(&typhoon_fw, FIRMWARE_NAME, &tp->pdev->dev);
-       if (err) {
-               netdev_err(tp->dev, "Failed to load firmware \"%s\"\n",
-                          FIRMWARE_NAME);
+       if (err)
                return err;
-       }
 
        image_data = typhoon_fw->data;
        remaining = typhoon_fw->size;
index 165d18405b0c784d2edd75614846196f1e0e30dc..c72ef479bbe994b7d2399ffdc46ca45ec26ef96a 100644 (file)
@@ -1015,11 +1015,8 @@ static int netdev_open(struct net_device *dev)
 #endif /* VLAN_SUPPORT */
 
        retval = request_firmware(&fw_rx, FIRMWARE_RX, &np->pci_dev->dev);
-       if (retval) {
-               printk(KERN_ERR "starfire: Failed to load firmware \"%s\"\n",
-                      FIRMWARE_RX);
+       if (retval)
                goto out_init;
-       }
        if (fw_rx->size % 4) {
                printk(KERN_ERR "starfire: bogus length %zu in \"%s\"\n",
                       fw_rx->size, FIRMWARE_RX);
@@ -1027,11 +1024,8 @@ static int netdev_open(struct net_device *dev)
                goto out_rx;
        }
        retval = request_firmware(&fw_tx, FIRMWARE_TX, &np->pci_dev->dev);
-       if (retval) {
-               printk(KERN_ERR "starfire: Failed to load firmware \"%s\"\n",
-                      FIRMWARE_TX);
+       if (retval)
                goto out_rx;
-       }
        if (fw_tx->size % 4) {
                printk(KERN_ERR "starfire: bogus length %zu in \"%s\"\n",
                       fw_tx->size, FIRMWARE_TX);
index 9daef4c8feef2c0c4d2be3cd039e55c2110492aa..83f82d7f178370ea1a893e41bc329cc7d71f333e 100644 (file)
@@ -1052,11 +1052,8 @@ static int slic_load_rcvseq_firmware(struct slic_device *sdev)
        file = (sdev->model == SLIC_MODEL_OASIS) ?  SLIC_RCV_FIRMWARE_OASIS :
                                                    SLIC_RCV_FIRMWARE_MOJAVE;
        err = request_firmware(&fw, file, &sdev->pdev->dev);
-       if (err) {
-               dev_err(&sdev->pdev->dev,
-                       "failed to load receive sequencer firmware %s\n", file);
+       if (err)
                return err;
-       }
        /* Do an initial sanity check concerning firmware size now. A further
         * check follows below.
         */
@@ -1127,10 +1124,8 @@ static int slic_load_firmware(struct slic_device *sdev)
        file = (sdev->model == SLIC_MODEL_OASIS) ?  SLIC_FIRMWARE_OASIS :
                                                    SLIC_FIRMWARE_MOJAVE;
        err = request_firmware(&fw, file, &sdev->pdev->dev);
-       if (err) {
-               dev_err(&sdev->pdev->dev, "failed to load firmware %s\n", file);
+       if (err)
                return err;
-       }
        /* Do an initial sanity check concerning firmware size now. A further
         * check follows below.
         */
index f366faf88eee6a89f3e8f551e23a9cb25045e647..c23e4c7d47b90a6750ad7ee39c696250a3b92c02 100644 (file)
@@ -2886,11 +2886,8 @@ static int ace_load_firmware(struct net_device *dev)
                fw_name = "acenic/tg1.bin";
 
        ret = request_firmware(&fw, fw_name, &ap->pdev->dev);
-       if (ret) {
-               printk(KERN_ERR "%s: Failed to load firmware \"%s\"\n",
-                      ap->name, fw_name);
+       if (ret)
                return ret;
-       }
 
        fw_data = (void *)fw->data;
 
index dbb7874607ca867bfcd0749039dc0ad511b6ecea..22d1d3c78e29c5be45af717d1c206db65ced5194 100644 (file)
@@ -3718,16 +3718,13 @@ static int bnx2_request_uncached_firmware(struct bnx2 *bp)
        }
 
        rc = request_firmware(&bp->mips_firmware, mips_fw_file, &bp->pdev->dev);
-       if (rc) {
-               pr_err("Can't load firmware file \"%s\"\n", mips_fw_file);
+       if (rc)
                goto out;
-       }
 
        rc = request_firmware(&bp->rv2p_firmware, rv2p_fw_file, &bp->pdev->dev);
-       if (rc) {
-               pr_err("Can't load firmware file \"%s\"\n", rv2p_fw_file);
+       if (rc)
                goto err_release_mips_firmware;
-       }
+
        mips_fw = (const struct bnx2_mips_fw_file *) bp->mips_firmware->data;
        rv2p_fw = (const struct bnx2_rv2p_fw_file *) bp->rv2p_firmware->data;
        if (bp->mips_firmware->size < sizeof(*mips_fw) ||
index 1c26fa962233143982f83ef8a03152767c9b35dc..0ea36e18d739b4897fc603c76d9d4c39b1701c57 100644 (file)
@@ -13552,11 +13552,8 @@ static int bnx2x_init_firmware(struct bnx2x *bp)
        BNX2X_DEV_INFO("Loading %s\n", fw_file_name);
 
        rc = request_firmware(&bp->firmware, fw_file_name, &bp->pdev->dev);
-       if (rc) {
-               BNX2X_ERR("Can't load firmware file %s\n",
-                         fw_file_name);
+       if (rc)
                goto request_firmware_exit;
-       }
 
        rc = bnx2x_check_firmware(bp);
        if (rc) {
index 88466255bf66a2d4be6f6877aaadff5c844199b8..84616204fc9294c5d04247dc8da173cc6bdeb53d 100644 (file)
@@ -11412,11 +11412,8 @@ static int tg3_request_firmware(struct tg3 *tp)
 {
        const struct tg3_firmware_hdr *fw_hdr;
 
-       if (request_firmware(&tp->fw, tp->fw_needed, &tp->pdev->dev)) {
-               netdev_err(tp->dev, "Failed to load firmware \"%s\"\n",
-                          tp->fw_needed);
+       if (request_firmware(&tp->fw, tp->fw_needed, &tp->pdev->dev))
                return -ENOENT;
-       }
 
        fw_hdr = (struct tg3_firmware_hdr *)tp->fw->data;
 
index 824eaef307043883a4ad9fca175f503ef1dc79d7..17b9de83a281b7aaeac3e79185fc91ec45e8dcfb 100644 (file)
@@ -24,10 +24,8 @@ cna_read_firmware(struct pci_dev *pdev, u32 **bfi_image,
        const struct firmware *fw;
        u32 n;
 
-       if (request_firmware(&fw, fw_name, &pdev->dev)) {
-               dev_alert(&pdev->dev, "can't load firmware %s\n", fw_name);
+       if (request_firmware(&fw, fw_name, &pdev->dev))
                goto error;
-       }
 
        *bfi_image = (u32 *)fw->data;
        *bfi_image_size = fw->size/sizeof(u32);
index 883cfa9c4b6da4496b694e4854439eda0df0a27a..8a4861e7c8e1f74b6b0a52f573e998ef40b8653b 100644 (file)
@@ -1037,12 +1037,8 @@ int t3_get_edc_fw(struct cphy *phy, int edc_idx, int size)
        fw_name = get_edc_fw_name(edc_idx);
        if (fw_name)
                ret = request_firmware(&fw, fw_name, &adapter->pdev->dev);
-       if (ret < 0) {
-               dev_err(&adapter->pdev->dev,
-                       "could not upgrade firmware: unable to load %s\n",
-                       fw_name);
+       if (ret)
                return ret;
-       }
 
        /* check size, take checksum in account */
        if (fw->size > size + 4) {
@@ -1079,11 +1075,8 @@ static int upgrade_fw(struct adapter *adap)
        struct device *dev = &adap->pdev->dev;
 
        ret = request_firmware(&fw, FW_FNAME, dev);
-       if (ret < 0) {
-               dev_err(dev, "could not upgrade firmware: unable to load %s\n",
-                       FW_FNAME);
+       if (ret)
                return ret;
-       }
        ret = t3_load_fw(adap, fw->data, fw->size);
        release_firmware(fw);
 
@@ -1128,11 +1121,8 @@ static int update_tpsram(struct adapter *adap)
        snprintf(buf, sizeof(buf), TPSRAM_NAME, rev);
 
        ret = request_firmware(&tpsram, buf, dev);
-       if (ret < 0) {
-               dev_err(dev, "could not load TP SRAM: unable to load %s\n",
-                       buf);
+       if (ret)
                return ret;
-       }
 
        ret = t3_check_tpsram(adap, tpsram->data, tpsram->size);
        if (ret)
index 1b8d015ebfb00e3b06700ac8fa2d8d4983dc172c..eefb8cb681b91af89548c7eacd7a8ae3248486d0 100644 (file)
@@ -1265,9 +1265,6 @@ static const struct firmware *e100_request_firmware(struct nic *nic)
 
        if (err) {
                if (required) {
-                       netif_err(nic, probe, nic->netdev,
-                                 "Failed to load firmware \"%s\": %d\n",
-                                 fw_name, err);
                        return ERR_PTR(err);
                } else {
                        netif_info(nic, probe, nic->netdev,
index 2ee0d0be113a7bd19f2a9bb756c12dbe4d0c51b0..5fb3b0e5f3bf50ad60f60203ac7cd86e9882372e 100644 (file)
@@ -580,8 +580,6 @@ static int myri10ge_load_hotplug_firmware(struct myri10ge_priv *mgp, u32 * size)
        unsigned i;
 
        if ((status = request_firmware(&fw, mgp->fw_name, dev)) < 0) {
-               dev_err(dev, "Unable to load %s firmware image via hotplug\n",
-                       mgp->fw_name);
                status = -EINVAL;
                goto abort_with_nothing;
        }
index f2a50eb3c1e07cbfac774ddcef78fd413566568d..ce754906fc3685a99df67f9bdda735cc767e6526 100644 (file)
@@ -647,10 +647,8 @@ static int osi_load_firmware(struct pcmcia_device *link)
        int i, err;
 
        err = request_firmware(&fw, FIRMWARE_NAME, &link->dev);
-       if (err) {
-               pr_err("Failed to load firmware \"%s\"\n", FIRMWARE_NAME);
+       if (err)
                return err;
-       }
 
        /* Download the Seven of Diamonds firmware */
        for (i = 0; i < fw->size; i++) {
index 6ec9163e232c41c12e95a50ab62fdffb4949864b..cbdde0dc82f097293a036b79e20885d5eb66d19c 100644 (file)
@@ -805,11 +805,8 @@ static void cas_saturn_firmware_init(struct cas *cp)
                return;
 
        err = request_firmware(&fw, fw_name, &cp->pdev->dev);
-       if (err) {
-               pr_err("Failed to load firmware \"%s\"\n",
-                      fw_name);
+       if (err)
                return;
-       }
        if (fw->size < 2) {
                pr_err("bogus length %zu in \"%s\"\n",
                       fw->size, fw_name);
index 71cdef9fb56bc93874c1984c2c995343cd065a45..8d2659d72d7a665b844e134e0c1ffae13d434e4f 100644 (file)
@@ -357,11 +357,8 @@ static unsigned char *add_mcs(unsigned char *bits, int bitrate,
                }
                err = request_firmware(&fw, fw_name[predef], &pdev->dev);
                platform_device_unregister(pdev);
-               if (err) {
-                       printk(KERN_ERR "Failed to load firmware \"%s\"\n",
-                              fw_name[predef]);
+               if (err)
                        return NULL;
-               }
                if (fw->size != YAM_FPGA_SIZE) {
                        printk(KERN_ERR "Bogus length %zu in firmware \"%s\"\n",
                               fw->size, fw_name[predef]);
index ed01dc964c99d727d7a04269723bd293452c2ddd..376920410ec1affb3a889b4e2d107532d99ec550 100644 (file)
@@ -378,10 +378,8 @@ static int kaweth_download_firmware(struct kaweth_device *kaweth,
        int ret;
 
        ret = request_firmware(&fw, fwname, &kaweth->dev->dev);
-       if (ret) {
-               dev_err(&kaweth->intf->dev, "Firmware request failed\n");
+       if (ret)
                return ret;
-       }
 
        if (fw->size > KAWETH_FIRMWARE_BUF_SIZE) {
                dev_err(&kaweth->intf->dev, "Firmware too big: %zu\n",
index 6c9a41bff2e0adf9046fa0dd4f8f1c6d5dd27d16..03e2df8690c907c65d4ef8440d34b714e2b3459d 100644 (file)
@@ -1578,11 +1578,8 @@ int i2400m_dev_bootstrap(struct i2400m *i2400m, enum i2400m_bri flags)
                }
                d_printf(1, dev, "trying firmware %s (%d)\n", fw_name, itr);
                ret = request_firmware(&fw, fw_name, dev);
-               if (ret < 0) {
-                       dev_err(dev, "fw %s: cannot load file: %d\n",
-                               fw_name, ret);
+               if (ret)
                        continue;
-               }
                i2400m->fw_name = fw_name;
                ret = i2400m_fw_bootstrap(i2400m, fw, flags);
                release_firmware(fw);
@@ -1625,8 +1622,6 @@ void i2400m_fw_cache(struct i2400m *i2400m)
        kref_init(&i2400m_fw->kref);
        result = request_firmware(&i2400m_fw->fw, i2400m->fw_name, dev);
        if (result < 0) {
-               dev_err(dev, "firmware %s: failed to cache: %d\n",
-                       i2400m->fw_name, result);
                kfree(i2400m_fw);
                i2400m_fw = (void *) ~0;
        } else
index dd0c32379375af8d63a4ad95212266de2bf3766f..6317c2600c0d83a32b4c6f3e9560facd287904f0 100644 (file)
@@ -1164,9 +1164,6 @@ static void ath9k_hif_usb_firmware_cb(const struct firmware *fw, void *context)
                if (!ret)
                        return;
 
-               dev_err(&hif_dev->udev->dev,
-                       "ath9k_htc: Failed to get firmware %s\n",
-                       hif_dev->fw_name);
                goto err_fw;
        }
 
index 486957a04bd18ca00b98fbe7772cc6be43aa12aa..799e2aefab52b07f9eb0dd13b6941d3c82c34d3e 100644 (file)
@@ -1029,7 +1029,6 @@ static void carl9170_usb_firmware_step2(const struct firmware *fw,
                return;
        }
 
-       dev_err(&ar->udev->dev, "firmware not found.\n");
        carl9170_usb_firmware_failed(ar);
 }
 
index 3b2680772f03d41f860d5837c0ac45e4d5eaa52d..cede709a8a40cc1e3169fc972e7d15d4c9f76b52 100644 (file)
@@ -1617,13 +1617,8 @@ static struct fwentry *at76_load_firmware(struct usb_device *udev,
 
        at76_dbg(DBG_FW, "downloading firmware %s", fwe->fwname);
        ret = request_firmware(&fwe->fw, fwe->fwname, &udev->dev);
-       if (ret < 0) {
-               dev_err(&udev->dev, "firmware %s not found!\n",
-                       fwe->fwname);
-               dev_err(&udev->dev,
-                       "you may need to download the firmware from http://developer.berlios.de/projects/at76c503a/\n");
+       if (ret)
                goto exit;
-       }
 
        at76_dbg(DBG_FW, "got it.");
        fwh = (struct at76_fw_header *)(fwe->fw->data);
index 74538085cfb792f27692730b51510136051875d3..f44930926cbdabea98ed570058cfa04ea41168ed 100644 (file)
@@ -3893,12 +3893,8 @@ static int reset_atmel_card(struct net_device *dev)
                                        strcpy(priv->firmware_id, "atmel_at76c502.bin");
                                }
                                err = request_firmware(&fw_entry, priv->firmware_id, priv->sys_dev);
-                               if (err != 0) {
-                                       printk(KERN_ALERT
-                                              "%s: firmware %s is missing, cannot continue.\n",
-                                              dev->name, priv->firmware_id);
+                               if (err != 0)
                                        return err;
-                               }
                        } else {
                                int fw_index = 0;
                                int success = 0;
index 39da1a4c30acf0a10b38211746c7c2a8f5be70a4..309f9a85eca4963a6229354e83e3af7dd86f5be3 100644 (file)
@@ -2243,19 +2243,8 @@ int b43_do_request_fw(struct b43_request_fw_context *ctx,
        }
        err = request_firmware(&ctx->blob, ctx->fwname,
                               ctx->dev->dev->dev);
-       if (err == -ENOENT) {
-               snprintf(ctx->errors[ctx->req_type],
-                        sizeof(ctx->errors[ctx->req_type]),
-                        "Firmware file \"%s\" not found\n",
-                        ctx->fwname);
-               return err;
-       } else if (err) {
-               snprintf(ctx->errors[ctx->req_type],
-                        sizeof(ctx->errors[ctx->req_type]),
-                        "Firmware file \"%s\" request failed (err=%d)\n",
-                        ctx->fwname, err);
+       if (err)
                return err;
-       }
 fw_ready:
        if (ctx->blob->size < sizeof(struct b43_fw_header))
                goto err_format;
index 8b6b657c4b85b5bc4614a2fc565bcbc95a7af97f..ceb4319a90a09e16e94413f61ccb17045fb3864b 100644 (file)
@@ -1523,11 +1523,8 @@ static int do_request_fw(struct b43legacy_wldev *dev,
        } else {
                err = request_firmware(fw, path, dev->dev->dev);
        }
-       if (err) {
-               b43legacyerr(dev->wl, "Firmware file \"%s\" not found "
-                      "or load failed.\n", path);
+       if (err)
                return err;
-       }
        if ((*fw)->size < sizeof(struct b43legacy_fw_header))
                goto err_format;
        hdr = (struct b43legacy_fw_header *)((*fw)->data);
index 8e8b685cfe09b5161d3a2f7b1d03d8ee842472df..cdf464e0d8685f48eb0ad445bd83ef039ceeeaa2 100644 (file)
@@ -378,19 +378,13 @@ static int brcms_request_fw(struct brcms_info *wl, struct bcma_device *pdev)
                sprintf(fw_name, "%s-%d.fw", brcms_firmwares[i],
                        UCODE_LOADER_API_VER);
                status = request_firmware(&wl->fw.fw_bin[i], fw_name, device);
-               if (status) {
-                       wiphy_err(wl->wiphy, "%s: fail to load firmware %s\n",
-                                 KBUILD_MODNAME, fw_name);
+               if (status)
                        return status;
-               }
                sprintf(fw_name, "%s_hdr-%d.fw", brcms_firmwares[i],
                        UCODE_LOADER_API_VER);
                status = request_firmware(&wl->fw.fw_hdr[i], fw_name, device);
-               if (status) {
-                       wiphy_err(wl->wiphy, "%s: fail to load firmware %s\n",
-                                 KBUILD_MODNAME, fw_name);
+               if (status)
                        return status;
-               }
                wl->fw.hdr_num_entries[i] =
                    wl->fw.fw_hdr[i]->size / (sizeof(struct firmware_hdr));
        }
index 536cd729c0860d68cdd44fb67c85282babac89ec..badee38ca8685cc7efc4823ac710d8367fad281c 100644 (file)
@@ -8392,12 +8392,8 @@ static int ipw2100_get_firmware(struct ipw2100_priv *priv,
 
        rc = request_firmware(&fw->fw_entry, fw_name, &priv->pci_dev->dev);
 
-       if (rc < 0) {
-               printk(KERN_ERR DRV_NAME ": "
-                      "%s: Firmware '%s' not available or load failed.\n",
-                      priv->net_dev->name, fw_name);
+       if (rc)
                return rc;
-       }
        IPW_DEBUG_INFO("firmware data %p size %zd\n", fw->fw_entry->data,
                       fw->fw_entry->size);
 
index 5ef6f87a48ac738c919fbf492263b7c21bba636b..4c40d377daca8ccc3e2a79bf35cd6be9f6dc1528 100644 (file)
@@ -3397,10 +3397,8 @@ static int ipw_get_fw(struct ipw_priv *priv,
 
        /* ask firmware_class module to get the boot firmware off disk */
        rc = request_firmware(raw, name, &priv->pci_dev->dev);
-       if (rc < 0) {
-               IPW_ERROR("%s request_firmware failed: Reason %d\n", name, rc);
+       if (rc)
                return rc;
-       }
 
        if ((*raw)->size < sizeof(*fw)) {
                IPW_ERROR("%s is too small (%zd)\n", name, (*raw)->size);
index 206b43b9dff86118b38007130dad323eaaa6de6c..26a7ea6261654dabc49e6ea257d450edd67aa82c 100644 (file)
@@ -1839,7 +1839,6 @@ il3945_read_ucode(struct il_priv *il)
                sprintf(buf, "%s%u%s", name_pre, idx, ".ucode");
                ret = request_firmware(&ucode_raw, buf, &il->pci_dev->dev);
                if (ret < 0) {
-                       IL_ERR("%s firmware file req failed: %d\n", buf, ret);
                        if (ret == -ENOENT)
                                continue;
                        else
index c24350222133dca13d378377284219ba415a5080..d86cdea94021f1d915ef219196b1d99bbfbe0829 100644 (file)
@@ -233,8 +233,6 @@ static int iwl_request_firmware(struct iwl_drv *drv, bool first)
        }
 
        if (drv->fw_index < cfg->ucode_api_min) {
-               IWL_ERR(drv, "no suitable firmware found!\n");
-
                if (cfg->ucode_api_min == cfg->ucode_api_max) {
                        IWL_ERR(drv, "%s%d is required\n", cfg->fw_name_pre,
                                cfg->ucode_api_max);
index 400a3521764406df48dbde06c5074ee298dd6c69..2559f7f1252c2bb8ba601bf0c780216c116659f5 100644 (file)
@@ -132,7 +132,6 @@ orinoco_dl_firmware(struct orinoco_private *priv,
                err = request_firmware(&fw_entry, firmware, priv->dev);
 
                if (err) {
-                       dev_err(dev, "Cannot find firmware %s\n", firmware);
                        err = -ENOENT;
                        goto free;
                }
@@ -292,10 +291,8 @@ symbol_dl_firmware(struct orinoco_private *priv,
        const struct firmware *fw_entry;
 
        if (!orinoco_cached_fw_get(priv, true)) {
-               if (request_firmware(&fw_entry, fw->pri_fw, priv->dev) != 0) {
-                       dev_err(dev, "Cannot find firmware: %s\n", fw->pri_fw);
+               if (request_firmware(&fw_entry, fw->pri_fw, priv->dev) != 0)
                        return -ENOENT;
-               }
        } else
                fw_entry = orinoco_cached_fw_get(priv, true);
 
@@ -311,10 +308,8 @@ symbol_dl_firmware(struct orinoco_private *priv,
        }
 
        if (!orinoco_cached_fw_get(priv, false)) {
-               if (request_firmware(&fw_entry, fw->sta_fw, priv->dev) != 0) {
-                       dev_err(dev, "Cannot find firmware: %s\n", fw->sta_fw);
+               if (request_firmware(&fw_entry, fw->sta_fw, priv->dev) != 0)
                        return -ENOENT;
-               }
        } else
                fw_entry = orinoco_cached_fw_get(priv, false);
 
index e753f43e0162f109c35b8d0b4a712462e276bd6f..e000142b2fe240b3a2aa23a97a0e5b5a85e86358 100644 (file)
@@ -1675,7 +1675,6 @@ static int ezusb_probe(struct usb_interface *interface,
                if (ezusb_firmware_download(upriv, &firmware) < 0)
                        goto error;
        } else {
-               err("No firmware to download");
                goto error;
        }
 
index 80ad0b7eaef437c1a715fded874da58125d864ba..909b92e1eca9d5cdd9baa63d66f6ff45c3c7c332 100644 (file)
@@ -496,7 +496,6 @@ static void p54p_firmware_step2(const struct firmware *fw,
        int err;
 
        if (!fw) {
-               dev_err(&pdev->dev, "Cannot find firmware (isl3886pci)\n");
                err = -ENOENT;
                goto out;
        }
index ab0fe85658518120dfaf066c9b1293b0e8064583..9c57aab8a224f282346e18dca7b2043328f4badd 100644 (file)
@@ -157,10 +157,8 @@ static int p54spi_request_firmware(struct ieee80211_hw *dev)
        /* FIXME: should driver use it's own struct device? */
        ret = request_firmware(&priv->firmware, "3826.arm", &priv->spi->dev);
 
-       if (ret < 0) {
-               dev_err(&priv->spi->dev, "request_firmware() failed: %d", ret);
+       if (ret)
                return ret;
-       }
 
        ret = p54_parse_firmware(dev, priv->firmware);
        if (ret) {
index b94764c88750aa89d3d4071f22a5fe8df3019396..25374d2e2fa9841fa10d571211c7459613963b90 100644 (file)
@@ -928,7 +928,6 @@ static void p54u_load_firmware_cb(const struct firmware *firmware,
                err = p54u_start_ops(priv);
        } else {
                err = -ENOENT;
-               dev_err(&udev->dev, "Firmware not found.\n");
        }
 
        complete(&priv->fw_wait_load);
index a9bae69222dcb935853955575a66de31e71c877a..1e9d25d296a946b4e1b675165fb24b8b48e76de5 100644 (file)
@@ -80,12 +80,9 @@ isl_upload_firmware(islpci_private *priv)
                const u32 *fw_ptr;
 
                rc = request_firmware(&fw_entry, priv->firmware, PRISM_FW_PDEV);
-               if (rc) {
-                       printk(KERN_ERR
-                              "%s: request_firmware() failed for '%s'\n",
-                              "prism54", priv->firmware);
+               if (rc)
                        return rc;
-               }
+
                /* prepare the Direct Memory Base register */
                reg = ISL38XX_DEV_FIRMWARE_ADDRES;
 
index 25ac9db35dbfe5b04060327566aa00399b5e2f67..47a7ea049fd2fa2aaeaa7ffce59e4c08fbff0932 100644 (file)
@@ -817,8 +817,6 @@ static int if_usb_prog_firmware(struct lbtf_private *priv)
        kernel_param_lock(THIS_MODULE);
        ret = request_firmware(&cardp->fw, lbtf_fw_name, &cardp->udev->dev);
        if (ret < 0) {
-               pr_err("request_firmware() failed with %#x\n", ret);
-               pr_err("firmware %s not found\n", lbtf_fw_name);
                kernel_param_unlock(THIS_MODULE);
                goto done;
        }
index 7d94695e7961cb59ea247350622ab3c65fb16301..39044292fbb5be896898f3ca5c1f35a94adbce72 100644 (file)
@@ -525,11 +525,8 @@ static int _mwifiex_fw_dpc(const struct firmware *firmware, void *context)
        struct wireless_dev *wdev;
        struct completion *fw_done = adapter->fw_done;
 
-       if (!firmware) {
-               mwifiex_dbg(adapter, ERROR,
-                           "Failed to get firmware %s\n", adapter->fw_name);
+       if (!firmware)
                goto err_dnld_fw;
-       }
 
        memset(&fw, 0, sizeof(struct mwifiex_fw_image));
        adapter->firmware = firmware;
index d55f229abeea66a1cd4cc9c4938f00170f1d59bf..e2deb6ccd9d31cbb4beef2e35b1dddb4a24ee67a 100644 (file)
@@ -5727,16 +5727,12 @@ static int mwl8k_firmware_load_success(struct mwl8k_priv *priv);
 static void mwl8k_fw_state_machine(const struct firmware *fw, void *context)
 {
        struct mwl8k_priv *priv = context;
-       struct mwl8k_device_info *di = priv->device_info;
        int rc;
 
        switch (priv->fw_state) {
        case FW_STATE_INIT:
-               if (!fw) {
-                       printk(KERN_ERR "%s: Error requesting helper fw %s\n",
-                              pci_name(priv->pdev), di->helper_image);
+               if (!fw)
                        goto fail;
-               }
                priv->fw_helper = fw;
                rc = mwl8k_request_fw(priv, priv->fw_pref, &priv->fw_ucode,
                                      true);
@@ -5771,11 +5767,8 @@ static void mwl8k_fw_state_machine(const struct firmware *fw, void *context)
                break;
 
        case FW_STATE_LOADING_ALT:
-               if (!fw) {
-                       printk(KERN_ERR "%s: Error requesting alt fw %s\n",
-                              pci_name(priv->pdev), di->helper_image);
+               if (!fw)
                        goto fail;
-               }
                priv->fw_ucode = fw;
                rc = mwl8k_firmware_load_success(priv);
                if (rc)
@@ -5813,10 +5806,8 @@ retry:
 
        /* Ask userland hotplug daemon for the device firmware */
        rc = mwl8k_request_firmware(priv, fw_image, nowait);
-       if (rc) {
-               wiphy_err(hw->wiphy, "Firmware files not found\n");
+       if (rc)
                return rc;
-       }
 
        if (nowait)
                return rc;
index c20886b02e6446141c048243a31168b643341d75..e7ec16d56b4bc719f9037ec2fcf6a4888a092f24 100644 (file)
@@ -38,10 +38,8 @@ static int rt2x00lib_request_firmware(struct rt2x00_dev *rt2x00dev)
        rt2x00_info(rt2x00dev, "Loading firmware file '%s'\n", fw_name);
 
        retval = request_firmware(&fw, fw_name, device);
-       if (retval) {
-               rt2x00_err(rt2x00dev, "Failed to request Firmware\n");
+       if (retval)
                return retval;
-       }
 
        if (!fw || !fw->size || !fw->data) {
                rt2x00_err(rt2x00dev, "Failed to read Firmware\n");
index f73e690bbe8e0b5cf11728b3310cdec03aaf68ed..3fd8ef29a9d80152321deca4b0b556393bfc04eb 100644 (file)
@@ -89,7 +89,6 @@ static void rtl_fw_do_work(const struct firmware *firmware, void *context,
                        if (!err)
                                goto found_alt;
                }
-               pr_err("Selected firmware is not available\n");
                rtlpriv->max_fw_size = 0;
                return;
        }
index 7a54497b7df25ace7557f6674ee0034d9a2a477a..f0dab3b26ebbeb891ea342ded7fa9ea2cbf1eea1 100644 (file)
@@ -63,13 +63,11 @@ static void rtl92se_fw_cb(const struct firmware *firmware, void *context)
        struct ieee80211_hw *hw = context;
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rt_firmware *pfirmware = NULL;
-       char *fw_name = "rtlwifi/rtl8192sefw.bin";
 
        RT_TRACE(rtlpriv, COMP_ERR, DBG_LOUD,
                         "Firmware callback routine entered!\n");
        complete(&rtlpriv->firmware_loading_complete);
        if (!firmware) {
-               pr_err("Firmware %s not available\n", fw_name);
                rtlpriv->max_fw_size = 0;
                return;
        }
index 480a8d08487816eb830d93f7a246b29ff2d32b68..4e9d99efe0b83a709190bfc53692b2112cdfe58a 100644 (file)
@@ -57,10 +57,8 @@ static int wl1251_fetch_firmware(struct wl1251 *wl)
 
        ret = request_firmware(&fw, WL1251_FW_NAME, dev);
 
-       if (ret < 0) {
-               wl1251_error("could not get firmware: %d", ret);
+       if (ret)
                return ret;
-       }
 
        if (fw->size % 4) {
                wl1251_error("firmware size is not multiple of 32 bits: %zu",
@@ -96,10 +94,8 @@ static int wl1251_fetch_nvs(struct wl1251 *wl)
 
        ret = request_firmware(&fw, WL1251_NVS_NAME, dev);
 
-       if (ret < 0) {
-               wl1251_error("could not get nvs file: %d", ret);
+       if (ret)
                return ret;
-       }
 
        if (fw->size % 4) {
                wl1251_error("nvs size is not multiple of 32 bits: %zu",
index f140f7d7f5532c78a46cb9218c4d31c6e10d6718..40529e0bd982b0d6cb51ed30c8e4cff0a9ee7cad 100644 (file)
@@ -755,10 +755,8 @@ static int wl12xx_fetch_firmware(struct wl1271 *wl, bool plt)
 
        ret = request_firmware(&fw, fw_name, wl->dev);
 
-       if (ret < 0) {
-               wl1271_error("could not get firmware %s: %d", fw_name, ret);
+       if (ret)
                return ret;
-       }
 
        if (fw->size % 4) {
                wl1271_error("firmware size is not multiple of 32 bits: %zu",
index 41641fc2be7437afa6dc05fd84e4f1fcc69e13a2..d05323f24aa17c870b45eee919f0bb5807129096 100644 (file)
@@ -62,8 +62,6 @@ static int zd1201_fw_upload(struct usb_device *dev, int apfw)
 
        err = request_firmware(&fw_entry, fwfile, &dev->dev);
        if (err) {
-               dev_err(&dev->dev, "Failed to load %s firmware file!\n", fwfile);
-               dev_err(&dev->dev, "Make sure the hotplug firmware loader is installed.\n");
                dev_err(&dev->dev, "Goto http://linux-lc100020.sourceforge.net for more info.\n");
                return err;
        }
index 8ff0374126e4fc4430180b5c1d9207238a1f984e..3b00e98581c11ff3ca3f7868e1d5ca873c15ed42 100644 (file)
@@ -108,16 +108,9 @@ static void int_urb_complete(struct urb *urb);
 static int request_fw_file(
        const struct firmware **fw, const char *name, struct device *device)
 {
-       int r;
-
        dev_dbg_f(device, "fw name %s\n", name);
 
-       r = request_firmware(fw, name, device);
-       if (r)
-               dev_err(device,
-                      "Could not load firmware file %s. Error number %d\n",
-                      name, r);
-       return r;
+       return request_firmware(fw, name, device);
 }
 
 static inline u16 get_bcdDevice(const struct usb_device *udev)
index a242a62caaa16eb84439c5a31c82be99ca73d95d..3cfebaffef6574b716f464a3d18934b2a1290dbb 100644 (file)
@@ -4103,8 +4103,6 @@ static int AscInitAsc1000Driver(ASC_DVC_VAR *asc_dvc)
 
        err = request_firmware(&fw, fwname, asc_dvc->drv_ptr->dev);
        if (err) {
-               printk(KERN_ERR "Failed to load image \"%s\" err %d\n",
-                      fwname, err);
                asc_dvc->err_code |= ASC_IERR_MCODE_CHKSUM;
                return err;
        }
@@ -4469,8 +4467,6 @@ static int AdvInitAsc3550Driver(ADV_DVC_VAR *asc_dvc)
 
        err = request_firmware(&fw, fwname, asc_dvc->drv_ptr->dev);
        if (err) {
-               printk(KERN_ERR "Failed to load image \"%s\" err %d\n",
-                      fwname, err);
                asc_dvc->err_code = ASC_IERR_MCODE_CHKSUM;
                return err;
        }
@@ -4969,8 +4965,6 @@ static int AdvInitAsc38C0800Driver(ADV_DVC_VAR *asc_dvc)
 
        err = request_firmware(&fw, fwname, asc_dvc->drv_ptr->dev);
        if (err) {
-               printk(KERN_ERR "Failed to load image \"%s\" err %d\n",
-                      fwname, err);
                asc_dvc->err_code = ASC_IERR_MCODE_CHKSUM;
                return err;
        }
@@ -5457,8 +5451,6 @@ static int AdvInitAsc38C1600Driver(ADV_DVC_VAR *asc_dvc)
 
        err = request_firmware(&fw, fwname, asc_dvc->drv_ptr->dev);
        if (err) {
-               printk(KERN_ERR "Failed to load image \"%s\" err %d\n",
-                      fwname, err);
                asc_dvc->err_code = ASC_IERR_MCODE_CHKSUM;
                return err;
        }
index d022407e5645c7166eb9f6a684bfd466f0c69b10..227f9aae29f97065340a0f6e57c8ca0eb98f44cb 100644 (file)
@@ -368,8 +368,6 @@ static ssize_t asd_store_update_bios(struct device *dev,
                                   filename_ptr,
                                   &asd_ha->pcidev->dev);
        if (err) {
-               asd_printk("Failed to load bios image file %s, error %d\n",
-                          filename_ptr, err);
                err = FAIL_OPEN_BIOS_FILE;
                goto out1;
        }
index 11853ec29d87a33d069950e467c8c3e978f4efcd..f2015d7051868f1b22f808ea5884631d21ebda13 100644 (file)
@@ -1299,11 +1299,8 @@ int asd_init_seqs(struct asd_ha_struct *asd_ha)
 
        err = asd_request_firmware(asd_ha);
 
-       if (err) {
-               asd_printk("Failed to load sequencer firmware file %s, error %d\n",
-                          SAS_RAZOR_SEQUENCER_FW_FILE, err);
+       if (err)
                return err;
-       }
 
        err = asd_seq_download_seqs(asd_ha);
        if (err) {
index eb0c76338295a115a5a9b121d71f77d78d25e60a..c9c01d1466807dca6c370202ea6e7dce64a7b0de 100644 (file)
@@ -1748,7 +1748,6 @@ bfad_read_firmware(struct pci_dev *pdev, u32 **bfi_image,
        const struct firmware *fw;
 
        if (request_firmware(&fw, fw_name, &pdev->dev)) {
-               printk(KERN_ALERT "Can't locate firmware %s\n", fw_name);
                *bfi_image = NULL;
                goto out;
        }
index cd8db134987153572ca6c3636f02a207297aa0d5..f34a40b02cba8bece43c9989082d2bc97e2016a7 100644 (file)
@@ -4091,10 +4091,8 @@ static ssize_t ipr_store_update_fw(struct device *dev,
        if (endline)
                *endline = '\0';
 
-       if (request_firmware(&fw_entry, fname, &ioa_cfg->pdev->dev)) {
-               dev_err(&ioa_cfg->pdev->dev, "Firmware file %s not found\n", fname);
+       if (request_firmware(&fw_entry, fname, &ioa_cfg->pdev->dev))
                return -EIO;
-       }
 
        image_hdr = (struct ipr_ucode_image_header *)fw_entry->data;
 
index 7c6be2ec110d11e8cc8086bca028ae0557559c20..b9469834b75354313fa1f803f02e300bbdd8ee13 100644 (file)
@@ -775,10 +775,6 @@ static ssize_t pm8001_store_update_fw(struct device *cdev,
                               pm8001_ha->dev);
 
        if (ret) {
-               PM8001_FAIL_DBG(pm8001_ha,
-                       pm8001_printk(
-                       "Failed to load firmware image file %s, error %d\n",
-                       filename_ptr, ret));
                pm8001_ha->fw_status = FAIL_OPEN_BIOS_FILE;
                goto out;
        }
index 3337cd341d210450fecb079026a10db2bf30eb9b..bd00e663957e3f5f642e1658e348cd8f1cbf80a1 100644 (file)
@@ -1515,8 +1515,6 @@ qla1280_request_firmware(struct scsi_qla_host *ha)
        err = request_firmware(&fw, fwname, &ha->pdev->dev);
 
        if (err) {
-               printk(KERN_ERR "Failed to load image \"%s\" err %d\n",
-                      fwname, err);
                fw = ERR_PTR(err);
                goto unlock;
        }
index 9e6b56527b2591c23c2cce1fce6fdc7f3c9fd94e..195269c7d04dc4377cf9b8dcc3f929d08eee0513 100644 (file)
@@ -7794,10 +7794,6 @@ qla2x00_load_risc(scsi_qla_host_t *vha, uint32_t *srisc_addr)
        /* Load firmware blob. */
        blob = qla2x00_request_firmware(vha);
        if (!blob) {
-               ql_log(ql_log_info, vha, 0x0083,
-                   "Firmware image unavailable.\n");
-               ql_log(ql_log_info, vha, 0x0084,
-                   "Firmware images can be retrieved from: "QLA_FW_URL ".\n");
                return QLA_FUNCTION_FAILED;
        }
 
@@ -7900,9 +7896,6 @@ qla24xx_load_risc_blob(scsi_qla_host_t *vha, uint32_t *srisc_addr)
 
        blob = qla2x00_request_firmware(vha);
        if (!blob) {
-               ql_log(ql_log_warn, vha, 0x0092,
-                   "-> Firmware file not found.\n");
-
                return QLA_FUNCTION_FAILED;
        }
 
index 185c5f34d4c14757283a26395aadaf5ecb7131e3..d51f91da1745fbb153c10918edd4fb3072728d5b 100644 (file)
@@ -2476,11 +2476,8 @@ try_blob_fw:
 
        /* Load firmware blob. */
        blob = ha->hablob = qla2x00_request_firmware(vha);
-       if (!blob) {
-               ql_log(ql_log_fatal, vha, 0x00a3,
-                   "Firmware image not present.\n");
+       if (!blob)
                goto fw_load_failed;
-       }
 
        /* Validating firmware blob */
        if (qla82xx_validate_firmware_blob(vha,
index 98908c2a096a713ccef1f6ee9a71ced5e46277cb..01a1da5898f68a26711d62cc8f687322a3f57d6e 100644 (file)
@@ -6805,8 +6805,6 @@ qla2x00_request_firmware(scsi_qla_host_t *vha)
                goto out;
 
        if (request_firmware(&blob->fw, blob->name, &ha->pdev->dev)) {
-               ql_log(ql_log_warn, vha, 0x0063,
-                   "Failed to load firmware image (%s).\n", blob->name);
                blob->fw = NULL;
                blob = NULL;
        }
index d539beef3ce8f3793d54451d61d4a2412b4d10d6..89b1f9e9fb7c10e4a79f537c1d5ee947fcb95e7f 100644 (file)
@@ -486,11 +486,8 @@ static int qlogicpti_load_firmware(struct qlogicpti *qpti)
        int i, timeout;
 
        err = request_firmware(&fw, fwname, &qpti->op->dev);
-       if (err) {
-               printk(KERN_ERR "Failed to load image \"%s\" err %d\n",
-                      fwname, err);
+       if (err)
                return err;
-       }
        if (fw->size % 2) {
                printk(KERN_ERR "Bogus length %zu in image \"%s\"\n",
                       fw->size, fwname);
index dd81d210bd49d1d97e5c9a925d56c934144f5267..933fdc31925a5facae45c9b442cbaee506e995d2 100644 (file)
@@ -245,10 +245,8 @@ bool init_firmware(struct net_device *dev)
                 */
                if (rst_opt == OPT_SYSTEM_RESET) {
                        rc = request_firmware(&fw_entry, fw_name[init_step], &priv->udev->dev);
-                       if (rc < 0) {
-                               RT_TRACE(COMP_ERR, "request firmware fail!\n");
+                       if (rc)
                                goto download_firmware_fail;
-                       }
 
                        if (fw_entry->size > sizeof(pfirmware->firmware_buf)) {
                                RT_TRACE(COMP_ERR, "img file size exceed the container buffer fail!\n");
index 40145c0338e458290891f9e36c35cf2622805a2c..c3107bb03b000dd30d076e157f4ee8bed0c57cb2 100644 (file)
@@ -59,8 +59,6 @@ int rtl871x_load_fw(struct _adapter *padapter)
        dev_info(dev, "r8712u: Loading firmware from \"%s\"\n", firmware_file);
        rc = request_firmware_nowait(THIS_MODULE, 1, firmware_file, dev,
                                     GFP_KERNEL, padapter, rtl871x_load_fw_cb);
-       if (rc)
-               dev_err(dev, "r8712u: Firmware request error %d\n", rc);
        return rc;
 }
 MODULE_FIRMWARE("rtlwifi/rtl8712u.bin");
index 70358d427211a089ca8c54baf3d2ecf55837a62b..3e5a24a93b89c9d021c022c594e4cff601611228 100644 (file)
@@ -37,11 +37,8 @@ int vnt_download_firmware(struct vnt_private *priv)
        dev_dbg(dev, "---->Download firmware\n");
 
        ret = request_firmware(&fw, FIRMWARE_NAME, dev);
-       if (ret) {
-               dev_err(dev, "firmware file %s request failed (%d)\n",
-                       FIRMWARE_NAME, ret);
+       if (ret)
                goto end;
-       }
 
        for (ii = 0; ii < fw->size; ii += FIRMWARE_CHUNK_SIZE) {
                length = min_t(int, fw->size - ii, FIRMWARE_CHUNK_SIZE);
index a6aabfd6e2da40b9c4bdbac2398de68716c376ea..cc36faef39bd30b3adb1244ee5e2168abf2202c5 100644 (file)
@@ -3484,10 +3484,8 @@ static int cyz_load_fw(struct pci_dev *pdev, void __iomem *base_addr,
        int retval;
 
        retval = request_firmware(&fw, "cyzfirm.bin", &pdev->dev);
-       if (retval) {
-               dev_err(&pdev->dev, "can't get firmware\n");
+       if (retval)
                goto err;
-       }
 
        /* Check whether the firmware is already loaded and running. If
           positive, skip this board */
index 9f13f7d49dd78874283efbb3a0286a776b882dc3..ba3316c073b38ecd2131d5ccbadb12c2d07dd41b 100644 (file)
@@ -854,13 +854,8 @@ static int moxa_init_board(struct moxa_board_conf *brd, struct device *dev)
        }
 
        ret = request_firmware(&fw, file, dev);
-       if (ret) {
-               printk(KERN_ERR "MOXA: request_firmware failed. Make sure "
-                               "you've placed '%s' file into your firmware "
-                               "loader directory (e.g. /lib/firmware)\n",
-                               file);
+       if (ret)
                goto err_free;
-       }
 
        ret = moxa_load_fw(brd, fw);
 
index 624f3d541c6875c7f805a1dec4db0454604702af..fb39c425614d14d477e13d46308ae251ac4833bf 100644 (file)
@@ -358,7 +358,6 @@ static void load_code(struct icom_port *icom_port)
 
        /* Load Call Setup into Adapter */
        if (request_firmware(&fw, "icom_call_setup.bin", &dev->dev) < 0) {
-               dev_err(&dev->dev,"Unable to load icom_call_setup.bin firmware image\n");
                status = -1;
                goto load_code_exit;
        }
@@ -378,7 +377,6 @@ static void load_code(struct icom_port *icom_port)
 
        /* Load Resident DCE portion of Adapter */
        if (request_firmware(&fw, "icom_res_dce.bin", &dev->dev) < 0) {
-               dev_err(&dev->dev,"Unable to load icom_res_dce.bin firmware image\n");
                status = -1;
                goto load_code_exit;
        }
@@ -423,7 +421,6 @@ static void load_code(struct icom_port *icom_port)
        }
 
        if (request_firmware(&fw, "icom_asc.bin", &dev->dev) < 0) {
-               dev_err(&dev->dev,"Unable to load icom_asc.bin firmware image\n");
                status = -1;
                goto load_code_exit;
        }
index 3c8c662c69e2509a12f2f3bbb666522335d42807..89cb6c851e04aad59d81f217f14fad93c0e2cb7f 100644 (file)
@@ -1161,10 +1161,8 @@ static void uart_firmware_cont(const struct firmware *fw, void *context)
        struct device *dev = context;
        int ret;
 
-       if (!fw) {
-               dev_err(dev, "firmware not found\n");
+       if (!fw)
                return;
-       }
 
        firmware = (struct qe_firmware *) fw->data;
 
index 5d41f85a744544191291b5f788260a1d096c9a30..df78902cc94273c3c73c06d52a53036e7d525de2 100644 (file)
@@ -1088,8 +1088,6 @@ static int cxacru_find_firmware(struct cxacru_data *instance,
                return -ENOENT;
        }
 
-       usb_info(usbatm, "found firmware %s\n", buf);
-
        return 0;
 }
 
index 635cf0466b5921c103bcf1b1c5bd657cf32e7e71..df3679ac740dabe4406307cf5b49f99b6e7a5369 100644 (file)
@@ -606,10 +606,8 @@ static void uea_upload_pre_firmware(const struct firmware *fw_entry,
        int ret, size;
 
        uea_enters(usb);
-       if (!fw_entry) {
-               uea_err(usb, "firmware is not available\n");
+       if (!fw_entry)
                goto err;
-       }
 
        pfw = fw_entry->data;
        size = fw_entry->size;
@@ -704,10 +702,6 @@ static int uea_load_firmware(struct usb_device *usb, unsigned int ver)
        ret = request_firmware_nowait(THIS_MODULE, 1, fw_name, &usb->dev,
                                        GFP_KERNEL, usb,
                                        uea_upload_pre_firmware);
-       if (ret)
-               uea_err(usb, "firmware %s is not available\n", fw_name);
-       else
-               uea_info(usb, "loading firmware %s\n", fw_name);
 
        uea_leaves(usb);
        return ret;
@@ -869,12 +863,8 @@ static int request_dsp(struct uea_softc *sc)
        }
 
        ret = request_firmware(&sc->dsp_firm, dsp_name, &sc->usb_dev->dev);
-       if (ret < 0) {
-               uea_err(INS_TO_USBDEV(sc),
-                      "requesting firmware %s failed with error %d\n",
-                       dsp_name, ret);
+       if (ret)
                return ret;
-       }
 
        if (UEA_CHIP_VERSION(sc) == EAGLE_IV)
                ret = check_dsp_e4(sc->dsp_firm->data, sc->dsp_firm->size);
@@ -1587,12 +1577,8 @@ static int request_cmvs_old(struct uea_softc *sc,
 
        cmvs_file_name(sc, cmv_name, 1);
        ret = request_firmware(fw, cmv_name, &sc->usb_dev->dev);
-       if (ret < 0) {
-               uea_err(INS_TO_USBDEV(sc),
-                      "requesting firmware %s failed with error %d\n",
-                      cmv_name, ret);
+       if (ret)
                return ret;
-       }
 
        data = (u8 *) (*fw)->data;
        size = (*fw)->size;
@@ -1629,9 +1615,6 @@ static int request_cmvs(struct uea_softc *sc,
                                "try to get older cmvs\n", cmv_name);
                        return request_cmvs_old(sc, cmvs, fw);
                }
-               uea_err(INS_TO_USBDEV(sc),
-                      "requesting firmware %s failed with error %d\n",
-                      cmv_name, ret);
                return ret;
        }
 
@@ -1914,11 +1897,8 @@ static int load_XILINX_firmware(struct uea_softc *sc)
        uea_enters(INS_TO_USBDEV(sc));
 
        ret = request_firmware(&fw_entry, fw_name, &sc->usb_dev->dev);
-       if (ret) {
-               uea_err(INS_TO_USBDEV(sc), "firmware %s is not available\n",
-                      fw_name);
+       if (ret)
                goto err0;
-       }
 
        pfw = fw_entry->data;
        size = fw_entry->size;
index 24d841850e0561cb8ccf52fc9fcc896eccdeaffa..84e62e60c8a51e479d46bfa994e6d54430356aea 100644 (file)
@@ -85,21 +85,17 @@ static int emi26_load_firmware (struct usb_device *dev)
 
        err = request_ihex_firmware(&loader_fw, "emi26/loader.fw", &dev->dev);
        if (err)
-               goto nofw;
+               goto wraperr;
 
        err = request_ihex_firmware(&bitstream_fw, "emi26/bitstream.fw",
                                    &dev->dev);
        if (err)
-               goto nofw;
+               goto wraperr;
 
        err = request_ihex_firmware(&firmware_fw, "emi26/firmware.fw",
                                    &dev->dev);
-       if (err) {
-       nofw:
-               dev_err(&dev->dev, "%s - request_firmware() failed\n",
-                       __func__);
+       if (err)
                goto wraperr;
-       }
 
        /* Assert reset (stop the CPU in the EMI) */
        err = emi26_set_reset(dev,1);
index f058d80297616889a38813d05d4ed478a5e060ef..4457095c5ddea7585477f6fc73c3b80d825e1cb4 100644 (file)
@@ -76,12 +76,8 @@ static int ezusb_ihex_firmware_download(struct usb_device *dev,
        const struct ihex_binrec *record;
 
        if (request_ihex_firmware(&firmware, firmware_path,
-                                 &dev->dev)) {
-               dev_err(&dev->dev,
-                       "%s - request \"%s\" failed\n",
-                       __func__, firmware_path);
+                                 &dev->dev))
                goto out;
-       }
 
        ret = ezusb_set_reset(dev, fx.cpucs_reg, 0);
        if (ret < 0)
index 4d30095d6ad2193a6d6064891b67dda2a19ebb75..e217999b192385be1edbb6bf7101845b8a840369 100644 (file)
@@ -45,7 +45,6 @@ static int isight_firmware_load(struct usb_interface *intf,
                return -ENOMEM;
 
        if (request_firmware(&firmware, "isight.fw", &dev->dev) != 0) {
-               printk(KERN_ERR "Unable to load isight firmware\n");
                ret = -ENODEV;
                goto out;
        }
index 4cca0b836f43092506f40c10fe0f2589fd12de1a..81a96791f74eff6ea011bcb3c0588a7681a0a049 100644 (file)
@@ -375,11 +375,8 @@ static void update_edgeport_E2PROM(struct edgeport_serial *edge_serial)
 
        response = request_ihex_firmware(&fw, fw_name,
                                         &edge_serial->serial->dev->dev);
-       if (response) {
-               dev_err(dev, "Failed to load image \"%s\" err %d\n",
-                      fw_name, response);
+       if (response)
                return;
-       }
 
        rec = (const struct ihex_binrec *)fw->data;
        BootMajorVersion = rec->data[0];
index c327d4cf79285d4c1b1904eb0c869f2431877c8f..ac3c2ae52f7b84be709680220c1b0cdfc8f0aad6 100644 (file)
@@ -1010,8 +1010,6 @@ static int download_fw(struct edgeport_serial *serial)
 
        status = request_firmware(&fw, fw_name, dev);
        if (status) {
-               dev_err(dev, "Failed to load image \"%s\" err %d\n",
-                               fw_name, status);
                return status;
        }
 
index ef23acc9b9ce4bc8fe8ccb8197b42f69928a87b3..73fa0cf7977ffc2468cc6870e5c88450806f40fe 100644 (file)
@@ -1663,10 +1663,8 @@ static int ti_download_firmware(struct ti_device *tdev)
        }
 
 check_firmware:
-       if (status) {
-               dev_err(&dev->dev, "%s - firmware not found\n", __func__);
+       if (status)
                return -ENOENT;
-       }
        if (fw_p->size > TI_FIRMWARE_BUF_SIZE) {
                dev_err(&dev->dev, "%s - firmware too large %zu\n", __func__, fw_p->size);
                release_firmware(fw_p);
index fd66f4d4a621b754739509b334cf98b6b9990ca8..ef5a29f865b5c58ac400c64fb158370890f6be77 100644 (file)
@@ -743,10 +743,8 @@ static ssize_t broadsheet_loadstore_waveform(struct device *dev,
                return -EINVAL;
 
        err = request_firmware(&fw_entry, "broadsheet.wbf", dev);
-       if (err < 0) {
-               dev_err(dev, "Failed to get broadsheet waveform\n");
+       if (err)
                goto err_failed;
-       }
 
        /* try to enforce reasonable min max on waveform */
        if ((fw_entry->size < 8*1024) || (fw_entry->size > 64*1024)) {
index a42e2eceee48f64aa22cb6ce2aa01e2f398f8cd0..13bf75b4dd02b1adc3cf1b9203fd6c517901e38c 100644 (file)
@@ -679,10 +679,8 @@ static int metronomefb_probe(struct platform_device *dev)
                a) request the waveform file from userspace
                b) process waveform and decode into metromem */
        retval = request_firmware(&fw_entry, "metronome.wbf", &dev->dev);
-       if (retval < 0) {
-               dev_err(&dev->dev, "Failed to get waveform\n");
+       if (retval)
                goto err_csum_table;
-       }
 
        retval = load_waveform((u8 *) fw_entry->data, fw_entry->size, 3, 31,
                                par);
index 01baa6d872e92f542f326bb30d8a87440259ff4a..0f01e78c0d9c2d17c1e369ee99d69602af1b4176 100644 (file)
@@ -58,10 +58,8 @@ int snd_vx_setup_firmware(struct vx_core *chip)
                if (! fw_files[chip->type][i])
                        continue;
                sprintf(path, "vx/%s", fw_files[chip->type][i]);
-               if (request_firmware(&fw, path, chip->dev)) {
-                       snd_printk(KERN_ERR "vx: can't load firmware %s\n", path);
+               if (request_firmware(&fw, path, chip->dev))
                        return -ENOENT;
-               }
                err = chip->ops->load_dsp(chip, i, fw);
                if (err < 0) {
                        release_firmware(fw);
index 24b34ecf5e5ba3949bf67b54c208a84416199e19..8bb05d10ae7078e79a426d5e900f9cd2cc38094a 100644 (file)
@@ -376,15 +376,11 @@ static int upload_dsp_code(struct snd_card *card)
        outb(HPBLKSEL_0, chip->io + HP_BLKS);
 
        err = request_firmware(&init_fw, INITCODEFILE, card->dev);
-       if (err < 0) {
-               printk(KERN_ERR LOGNAME ": Error loading " INITCODEFILE);
+       if (err)
                goto cleanup1;
-       }
        err = request_firmware(&perm_fw, PERMCODEFILE, card->dev);
-       if (err < 0) {
-               printk(KERN_ERR LOGNAME ": Error loading " PERMCODEFILE);
+       if (err)
                goto cleanup;
-       }
 
        memcpy_toio(chip->mappedbase, perm_fw->data, perm_fw->size);
        if (snd_msnd_upload_host(chip, init_fw->data, init_fw->size) < 0) {
index 5363d88cc4b936325e17bf1a1f32d126670b2915..209e645be532d5abbffac5e21e54201e86cbec7e 100644 (file)
@@ -531,10 +531,8 @@ static int sscape_upload_bootblock(struct snd_card *card)
        int ret;
 
        ret = request_firmware(&init_fw, "scope.cod", card->dev);
-       if (ret < 0) {
-               snd_printk(KERN_ERR "sscape: Error loading scope.cod");
+       if (ret)
                return ret;
-       }
        ret = upload_dma_data(sscape, init_fw->data, init_fw->size);
 
        release_firmware(init_fw);
@@ -571,11 +569,8 @@ static int sscape_upload_microcode(struct snd_card *card, int version)
        snprintf(name, sizeof(name), "sndscape.co%d", version);
 
        err = request_firmware(&init_fw, name, card->dev);
-       if (err < 0) {
-               snd_printk(KERN_ERR "sscape: Error loading sndscape.co%d",
-                               version);
+       if (err)
                return err;
-       }
        err = upload_dma_data(sscape, init_fw->data, init_fw->size);
        if (err == 0)
                snd_printk(KERN_INFO "sscape: MIDI firmware loaded %zu KBs\n",
index c5b1d5900eed22be57c94f8da866c881935c1b21..a84063199c1fe8d772b926045cb8fa08065ce2d8 100644 (file)
@@ -1953,10 +1953,8 @@ wavefront_download_firmware (snd_wavefront_t *dev, char *path)
        const struct firmware *firmware;
 
        err = request_firmware(&firmware, path, dev->card->dev);
-       if (err < 0) {
-               snd_printk(KERN_ERR "firmware (%s) download failed!!!\n", path);
+       if (err)
                return 1;
-       }
 
        len = 0;
        buf = firmware->data;
index 9acc0ac75ecae21f49bf4c1dc1ed8e9837ab7888..7c1ebc8ec8ec43c42db5471901987e78d9a0f678 100644 (file)
@@ -35,8 +35,6 @@ short hpi_dsp_code_open(u32 adapter, void *os_data, struct dsp_code *dsp_code,
        err = request_firmware(&firmware, fw_name, &dev->dev);
 
        if (err || !firmware) {
-               dev_err(&dev->dev, "%d, request_firmware failed for %s\n",
-                       err, fw_name);
                goto error1;
        }
        if (firmware->size < sizeof(header)) {
index a080d63a9b4560248eada7a3ae9bc6adadf6a4b8..c4ab9e51c0eec6c45ab1fa1aa23c5f5f91bbae8b 100644 (file)
@@ -3235,11 +3235,8 @@ int snd_cs46xx_start_dsp(struct snd_cs46xx *chip)
 #ifdef CONFIG_SND_CS46XX_NEW_DSP
        for (i = 0; i < CS46XX_DSP_MODULES; i++) {
                err = load_firmware(chip, &chip->modules[i], module_names[i]);
-               if (err < 0) {
-                       dev_err(chip->card->dev, "firmware load error [%s]\n",
-                                  module_names[i]);
+               if (err < 0)
                        return err;
-               }
                err = cs46xx_dsp_load_module(chip, chip->modules[i]);
                if (err < 0) {
                        dev_err(chip->card->dev, "image download error [%s]\n",
index 0941a7a17623a49e987488e58327ad2488d6a788..bdb8b7a0b6375dc0d9dbe8c002e3a2ec95688ef9 100644 (file)
@@ -48,11 +48,8 @@ static int get_firmware(const struct firmware **fw_entry,
                "firmware requested: %s\n", card_fw[fw_index].data);
        snprintf(name, sizeof(name), "ea/%s", card_fw[fw_index].data);
        err = request_firmware(fw_entry, name, &chip->pci->dev);
-       if (err < 0)
-               dev_err(chip->card->dev,
-                       "get_firmware(): Firmware not available (%d)\n", err);
 #ifdef CONFIG_PM_SLEEP
-       else
+       if (!err)
                chip->fw_cache[fw_index] = *fw_entry;
 #endif
        return err;
index a89a7e603ca87edcc1c6b3dc5b74623ef23a5625..f4b5106d1806a699f454628be64382bcd713a07e 100644 (file)
@@ -873,10 +873,8 @@ static int snd_emu10k1_emu1010_init(struct snd_emu10k1 *emu)
        dev_info(emu->card->dev, "emu1010: EMU_HANA_ID = 0x%x\n", reg);
 
        err = snd_emu1010_load_firmware(emu, 0, &emu->firmware);
-       if (err < 0) {
-               dev_info(emu->card->dev, "emu1010: Loading Firmware failed\n");
+       if (err < 0)
                return err;
-       }
 
        /* ID, should read & 0x7f = 0x55 when FPGA programmed. */
        snd_emu1010_fpga_read(emu, EMU_HANA_ID, &reg);
index 8b015b27e9c73a43262c64372fa1599e29608056..3d8751f072f7b195ba6444907f408a58ced7535e 100644 (file)
@@ -2034,8 +2034,6 @@ static void azx_firmware_cb(const struct firmware *fw, void *context)
 
        if (fw)
                chip->fw = fw;
-       else
-               dev_err(card->dev, "Cannot load firmware, continue without patching\n");
        if (!chip->disabled) {
                /* continue probing */
                azx_probe_continue(chip);
index 21ab9cc50c71525eede97162c6379cbff02f6628..65655e84798dec6487481c6d904f2cb1fad17956 100644 (file)
@@ -2333,7 +2333,6 @@ static int snd_korg1212_create(struct snd_card *card, struct pci_dev *pci,
 
        err = request_firmware(&dsp_code, "korg/k1212.dsp", &pci->dev);
        if (err < 0) {
-               snd_printk(KERN_ERR "firmware not available\n");
                snd_korg1212_free(korg1212);
                return err;
        }
index 13dcb2fd0a855228a373534b390eedd3857dc42f..1f77e42fba16e6cf71b5d4023ff42a68a5210f2f 100644 (file)
@@ -558,11 +558,8 @@ int snd_mixart_setup_firmware(struct mixart_mgr *mgr)
 
        for (i = 0; i < 3; i++) {
                sprintf(path, "mixart/%s", fw_files[i]);
-               if (request_firmware(&fw_entry, path, &mgr->pci->dev)) {
-                       dev_err(&mgr->pci->dev,
-                               "miXart: can't load firmware %s\n", path);
+               if (request_firmware(&fw_entry, path, &mgr->pci->dev))
                        return -ENOENT;
-               }
                /* fake hwdep dsp record */
                err = mixart_dsp_load(mgr, i, fw_entry);
                release_firmware(fw_entry);
index 2258bd698844ff6f326e40baeaefa22893dfe4ec..9df5c4b2cc2138fdc214060b6664147e3a56b244 100644 (file)
@@ -372,12 +372,8 @@ int pcxhr_setup_firmware(struct pcxhr_mgr *mgr)
                if (!fw_files[fw_set][i])
                        continue;
                sprintf(path, "pcxhr/%s", fw_files[fw_set][i]);
-               if (request_firmware(&fw_entry, path, &mgr->pci->dev)) {
-                       dev_err(&mgr->pci->dev,
-                               "pcxhr: can't load firmware %s\n",
-                                  path);
+               if (request_firmware(&fw_entry, path, &mgr->pci->dev))
                        return -ENOENT;
-               }
                /* fake hwdep dsp record */
                err = pcxhr_dsp_load(mgr, i, fw_entry);
                release_firmware(fw_entry);
index b4f30028182272f7f2f234e0eb1516619d280a3c..21edef8027c4aabc801dd7cb5df67b2817434d92 100644 (file)
@@ -1216,11 +1216,8 @@ static int try_to_load_firmware(struct cmdif *cif, struct snd_riptide *chip)
        if (!chip->fw_entry) {
                err = request_firmware(&chip->fw_entry, "riptide.hex",
                                       &chip->pci->dev);
-               if (err) {
-                       snd_printk(KERN_ERR
-                                  "Riptide: Firmware not available %d\n", err);
+               if (err)
                        return -EIO;
-               }
        }
        err = loadfirmware(cif, chip->fw_entry->data, chip->fw_entry->size);
        if (err) {
index cc06f0a1a7e46d33cbb9407ce486ba0f4a13b794..9edd073e70a9c6d80ab453c1891e1a88e6766fde 100644 (file)
@@ -5111,11 +5111,8 @@ static int hdsp_request_fw_loader(struct hdsp *hdsp)
                return -EINVAL;
        }
 
-       if (request_firmware(&fw, fwfile, &hdsp->pci->dev)) {
-               dev_err(hdsp->card->dev,
-                       "cannot load firmware %s\n", fwfile);
+       if (request_firmware(&fw, fwfile, &hdsp->pci->dev))
                return -ENOENT;
-       }
        if (fw->size < HDSP_FIRMWARE_SIZE) {
                dev_err(hdsp->card->dev,
                        "too short firmware size %d (expected %d)\n",
index 72e165cc64439750663f4857a06fd4c20a7ff38d..d73cc2abdb9a37922575366253ad17ba559a2c04 100644 (file)
@@ -894,10 +894,8 @@ static int wm2000_i2c_probe(struct i2c_client *i2c,
        }
 
        ret = request_firmware(&fw, filename, &i2c->dev);
-       if (ret != 0) {
-               dev_err(&i2c->dev, "Failed to acquire ANC data: %d\n", ret);
+       if (ret != 0)
                goto err_supplies;
-       }
 
        /* Pre-cook the concatenation of the register address onto the image */
        wm2000->anc_download_size = fw->size + 2;
index 69137c14d0dcfe92b2cf089effe13077e9c3ee0b..f410bd6f839d9dfc3fd536d92e68522790ff6989 100644 (file)
@@ -215,8 +215,6 @@ static int usb6fire_fw_ezusb_upload(
        ret = request_firmware(&fw, fwname, &device->dev);
        if (ret < 0) {
                kfree(rec);
-               dev_err(&intf->dev,
-                       "error requesting ezusb firmware %s.\n", fwname);
                return ret;
        }
        ret = usb6fire_fw_ihex_init(fw, rec);
@@ -292,8 +290,6 @@ static int usb6fire_fw_fpga_upload(
 
        ret = request_firmware(&fw, fwname, &device->dev);
        if (ret < 0) {
-               dev_err(&intf->dev, "unable to get fpga firmware %s.\n",
-                               fwname);
                kfree(buffer);
                return -EIO;
        }