Skip some tests with small textures
authorMatthias Clasen <mclasen@redhat.com>
Mon, 1 May 2023 20:00:24 +0000 (16:00 -0400)
committerMatthias Clasen <mclasen@redhat.com>
Mon, 1 May 2023 20:29:45 +0000 (16:29 -0400)
When textures are too large, we will scale them down
to fit the max texture size, which will cause comparisons
to fail.

.gitlab-ci/run-tests.sh
testsuite/gsk/meson.build
testsuite/meson.build

index 51e2db68fdf3d641a892bf141214c76f9a788225..4a206ef2b0a8d1d2c1f9d8b47aea0add8bda6a57 100755 (executable)
@@ -50,6 +50,7 @@ case "${backend}" in
                 --suite=gtk \
                 --no-suite=failing \
                 --no-suite=flaky \
+                --no-suite=${backend}_failing \
                 --no-suite=gsk-compare-broadway
     exit_code=$?
 
index 58d24d432c703f69bbdfbae20d70c8ece8cbe42d..7e738cd09720d1dc02f83233dec403827f9d7ffa 100644 (file)
@@ -48,8 +48,7 @@ compare_render_tests = [
   'empty-cross-fade',
   'empty-debug',
   'empty-inset-shadow',
-# this test fails for some of the backends
-# 'empty-linear-gradient',
+  'empty-linear-gradient',
   'empty-mask',
   'empty-opacity',
   'empty-outset-shadow',
@@ -108,10 +107,16 @@ renderers = [
 
 compare_xfails = [
   # Both tests fail because of some font rendering issue
+  'empty-linear-gradient',
   'unaligned-offscreen',
   'upside-down-label-3d', # not really 3d, but cairo fails it
 ]
 
+compare_xfails_small_texture = [
+  'big-checkerboard',
+  'big-checkerboard-scaled-down'
+]
+
 foreach renderer : renderers
   foreach testname : compare_render_tests
 
@@ -129,6 +134,10 @@ foreach renderer : renderers
       suites += 'failing'
     endif
 
+    if compare_xfails_small_texture.contains(testname)
+      suites += 'wayland_smalltexture_failing'
+    endif
+
     if ((exclude_term == '' or not testname.contains(exclude_term)) and
         (renderer_name != 'broadway' or broadway_enabled))
       test(renderer_name + ' ' + testname, compare_render,
index 15c80a07f2e98f24ef30e212401867439a3aee6f..ebcf98d550a7653431af4e4e5bb72e7c889a1864 100644 (file)
@@ -25,7 +25,7 @@ setups = [
   { 'backend': 'broadway', 'if': broadway_enabled, },
   { 'name': 'wayland_smalltexture',
     'backend': 'wayland', 'if': wayland_enabled,
-    'env': ['GSK_MAX_TEXTURE_SIZE=1024'], },
+    'env': ['GSK_MAX_TEXTURE_SIZE=1024'] },
   { 'backend': 'win32', 'if': os_win32 },
 ]
 
@@ -39,6 +39,10 @@ foreach setup : setups
       exclude += 'gsk-compare-broadway'
     endif
 
+    if name == 'wayland_smalltexture'
+      exclude += 'wayland_smalltexture_failing'
+    endif
+
     env = common_env + [
       'GDK_BACKEND=@0@'.format(backend),
     ] + setup.get('env', [])