libxl: initialise nr_dom_vcpus to fix 4a6070ea9
authorWei Liu <wei.liu2@citrix.com>
Mon, 24 Oct 2016 10:11:15 +0000 (11:11 +0100)
committerWei Liu <wei.liu2@citrix.com>
Mon, 24 Oct 2016 10:53:20 +0000 (11:53 +0100)
Clang complains nr_dom_vcpus may be used uninitialised after
4a6070ea9.

The real issue is vinfo can be NULL and nr_dom_vcpus remains
uninitialised if previous call fails.

Initialise nr_dom_vcpus to 0 at the beginning of the loop to fix the
issue.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Release-acked-by: Wei Liu <wei.liu2@citrix.com>
tools/libxl/libxl_numa.c

index fd64c2268699b4de80997701ed27a5617eefa8ad..a8a75f89e914b83db44ec5354fb7778cbaf1d4f6 100644 (file)
@@ -206,8 +206,9 @@ static int nr_vcpus_on_nodes(libxl__gc *gc, libxl_cputopology *tinfo,
 
     for (i = 0; i < nr_doms; i++) {
         libxl_vcpuinfo *vinfo = NULL;
+        int nr_dom_vcpus = 0;
         libxl_cpupoolinfo cpupool_info;
-        int cpupool, nr_dom_vcpus;
+        int cpupool;
 
         libxl_cpupoolinfo_init(&cpupool_info);