projects
/
gtk4.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
161259e
)
coloreditor: Don't unref unless we own it
author
Matthias Clasen
<mclasen@redhat.com>
Mon, 27 Sep 2021 20:40:29 +0000
(16:40 -0400)
committer
Matthias Clasen
<mclasen@redhat.com>
Sun, 31 Oct 2021 21:52:04 +0000
(17:52 -0400)
Calling gtk_widget_class_bind_template_child does
*not* give you a reference that you need to unref.
It manages the reference for you. So calling
g_clear_object on such a member is wrong.
gtk/gtkcoloreditor.c
patch
|
blob
|
history
diff --git
a/gtk/gtkcoloreditor.c
b/gtk/gtkcoloreditor.c
index 85a0c3df0eab59b614d4981f0dcf6803c026cd2c..84f2fe490b710f956860cdd1c74d14d233d1efcd 100644
(file)
--- a/
gtk/gtkcoloreditor.c
+++ b/
gtk/gtkcoloreditor.c
@@
-447,9
+447,6
@@
gtk_color_editor_dispose (GObject *object)
dismiss_current_popup (editor);
g_clear_object (&editor->picker);
- g_clear_object (&editor->h_adj);
- g_clear_object (&editor->s_adj);
- g_clear_object (&editor->v_adj);
G_OBJECT_CLASS (gtk_color_editor_parent_class)->dispose (object);
}