Fixup some minor review comments

diff --git a/src/cargo/core/compiler/build_plan.rs b/src/cargo/core/compiler/build_plan.rs
index 788d569b8faab28481c87b5871941286a815d9b4..d0ac68eede203663b9e91e8a741533673abeebc6 100644 (file)
--- a/src/cargo/core/compiler/build_plan.rs
+++ b/src/cargo/core/compiler/build_plan.rs
@@ -73,19 +73,20 @@ impl Invocation {
         self.program = cmd.get_program()
             .to_str()
             .ok_or_else(|| format_err!("unicode program string required"))?
-            .to_string()
-            .clone();
+            .to_string();
         self.cwd = Some(cmd.get_cwd().unwrap().to_path_buf());
         for arg in cmd.get_args().iter() {
             self.args.push(
                 arg.to_str()
                     .ok_or_else(|| format_err!("unicode argument string required"))?
-                    .to_string()
-                    .clone(),
+                    .to_string(),
             );
         }
-        for var in cmd.get_envs().keys() {
-            let value = cmd.get_env(var).unwrap_or_default();
+        for (var, value) in cmd.get_envs() {
+            let value = match value {
+                Some(s) => s,
+                None => continue,
+            };
             self.env.insert(
                 var.clone(),
                 value