gtktextview: Avoid calling gdk_rgba_free for NULL values
authorMarco Trevisan (Treviño) <mail@3v1n0.net>
Fri, 3 Feb 2023 15:41:56 +0000 (16:41 +0100)
committerMarco Trevisan (Treviño) <mail@3v1n0.net>
Fri, 3 Feb 2023 15:41:56 +0000 (16:41 +0100)
Related to glib#2908

gtk/gtktextview.c

index 62043ad54b9a83a97caab3f6ab895257a8d52476..fe7a63b69efcd8b9cc84b2b7b759a8a6834339ee 100644 (file)
@@ -7787,8 +7787,7 @@ gtk_text_view_set_attributes_from_style (GtkTextView        *text_view,
   else
     {
       values->appearance.underline = PANGO_UNDERLINE_NONE;
-      gdk_rgba_free (values->appearance.underline_rgba);
-      values->appearance.underline_rgba = NULL;
+      g_clear_pointer (&values->appearance.underline_rgba, gdk_rgba_free);
     }
 
   if (decoration_line & GTK_CSS_TEXT_DECORATION_LINE_OVERLINE)
@@ -7802,8 +7801,7 @@ gtk_text_view_set_attributes_from_style (GtkTextView        *text_view,
   else
     {
       values->appearance.overline = PANGO_OVERLINE_NONE;
-      gdk_rgba_free (values->appearance.overline_rgba);
-      values->appearance.overline_rgba = NULL;
+      g_clear_pointer (&values->appearance.overline_rgba, gdk_rgba_free);
     }
 
   if (decoration_line & GTK_CSS_TEXT_DECORATION_LINE_LINE_THROUGH)
@@ -7817,8 +7815,7 @@ gtk_text_view_set_attributes_from_style (GtkTextView        *text_view,
   else
     {
       values->appearance.strikethrough = FALSE;
-      gdk_rgba_free (values->appearance.strikethrough_rgba);
-      values->appearance.strikethrough_rgba = NULL;
+      g_clear_pointer (&values->appearance.strikethrough_rgba, gdk_rgba_free);
     }
 
   /* letter-spacing */