rombios: remove packed attribute for pushad_regs_t
authorWei Liu <wei.liu2@citrix.com>
Tue, 28 Aug 2018 13:56:38 +0000 (14:56 +0100)
committerWei Liu <wei.liu2@citrix.com>
Tue, 28 Aug 2018 14:14:56 +0000 (15:14 +0100)
The structure already has explicitly padding.

Removing the attribute silences a clang 6 warning:

tcgbios.c:1519:34: error: taking address of packed member 'u' of class or structure 'pushad_regs_t' may result in an unaligned pointer value [-Werror,-Waddress-of-packed-member]
                                                  ®s->u.r32.edx);
                                                   ^~~~~~~~~~~~~~~

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
tools/firmware/rombios/32bit/rombios_compat.h

index c0ae4151b516ad9a2f24a5bad79a5da32b038d38..3fe7d67721d8c64cc383e615c754606485fd6b8f 100644 (file)
@@ -52,7 +52,7 @@ typedef struct {
     Bit16u filler4;
     } r8;
   } u;
-} __attribute__((packed)) pushad_regs_t;
+} pushad_regs_t;