Simplify loop to write bytes to password

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

diff --git a/src/gui/filedetails/sharemodel.cpp b/src/gui/filedetails/sharemodel.cpp
index 146339b50efb4b9f3bd5b5c5ea3f96e711a73a04..e755718de8bdb5dd8fdb998a3df2a5d28907a0d3 100644 (file)
--- a/src/gui/filedetails/sharemodel.cpp
+++ b/src/gui/filedetails/sharemodel.cpp
@@ -63,10 +63,9 @@ QString createRandomPassword()
 
     RAND_bytes(unsignedCharArray.data(), numChars);
 
-    for (auto i = 0; i < numChars; i++) {
-        auto byte = unsignedCharArray[i];
-        byte %= asciiRange + 1;
-        byte += asciiMin;
+    for (const auto newChar : unsignedCharArray) {
+        // Ensure byte is within asciiRange
+        const auto byte = (newChar % (asciiRange + 1)) + asciiMin;
         passwd.append(byte);
     }