do not use dns.ADDRCONFIG for localhost

Last-Update: 2020-06-11
Bug-Debian: https://bugs.debian.org/962318
Forwarded: https://github.com/nodejs/node/issues/33816

it fails on IPv6-only systems. Setting it with libc fails on linux.
https://github.com/nodejs/node/issues/33279
https://lists.debian.org/debian-devel/2023/12/msg00011.html

Gbp-Pq: Topic deps
Gbp-Pq: Name localhost-no-addrconfig.patch

diff --git a/lib/net.js b/lib/net.js
index 05239dacf3e6e0378870affd67dbaa6d211d3cd0..15a4a6aa5c0ae4893e65049366c07858bd49481e 100644 (file)
--- a/lib/net.js
+++ b/lib/net.js
@@ -1,4 +1,5 @@
 // Copyright Joyent, Inc. and other Node contributors.
+
 //
 // Permission is hereby granted, free of charge, to any person obtaining a
 // copy of this software and associated documentation files (the
@@ -1343,13 +1344,6 @@ function lookupAndConnect(self, options) {
     hints: options.hints || 0,
   };
 
-  if (!isWindows &&
-      dnsopts.family !== 4 &&
-      dnsopts.family !== 6 &&
-      dnsopts.hints === 0) {
-    dnsopts.hints = dns.ADDRCONFIG;
-  }
-
   debug('connect: find host', host);
   debug('connect: dns options', dnsopts);
   self._host = host;

diff --git a/test/sequential/sequential.status b/test/sequential/sequential.status
index 948f38bc08740ea66c89a1bb10caafffa9a50d7c..3887bed7aacc255bbff84de9440b2199dd565022 100644 (file)
--- a/test/sequential/sequential.status
+++ b/test/sequential/sequential.status
@@ -24,6 +24,10 @@ test-worker-heapsnapshot-options                : PASS,FLAKY
 # https://github.com/nodejs/node/issues/24403
 test-cli-syntax: PASS,FLAKY
 
+# does not work on IPv6 only host
+test-tls-psk-client: PASS,FLAKY
+test-tls-securepair-client: PASS,FLAKY
+
 [$system==win32]
 # https://github.com/nodejs/node/issues/49630
 test-single-executable-application-snapshot: PASS, FLAKY