do not use dns.ADDRCONFIG for localhost

Last-Update: 2020-06-11
Bug-Debian: https://bugs.debian.org/962318
Forwarded: https://github.com/nodejs/node/issues/33816

it fails on IPv6-only systems. Setting it with libc fails on linux.
https://github.com/nodejs/node/issues/33279

Gbp-Pq: Name localhost-no-addrconfig.patch

diff --git a/lib/net.js b/lib/net.js
index fa6574c183e48e7cc36b91b6afea91a1eb104435..6be66f21200ea119f8d7ea092516d16f02d74b72 100644 (file)
--- a/lib/net.js
+++ b/lib/net.js
@@ -1,4 +1,5 @@
 // Copyright Joyent, Inc. and other Node contributors.
+
 //
 // Permission is hereby granted, free of charge, to any person obtaining a
 // copy of this software and associated documentation files (the
@@ -1028,13 +1029,6 @@ function lookupAndConnect(self, options) {
     hints: options.hints || 0
   };
 
-  if (process.platform !== 'win32' &&
-      dnsopts.family !== 4 &&
-      dnsopts.family !== 6 &&
-      dnsopts.hints === 0) {
-    dnsopts.hints = dns.ADDRCONFIG;
-  }
-
   debug('connect: find host', host);
   debug('connect: dns options', dnsopts);
   self._host = host;

diff --git a/test/sequential/sequential.status b/test/sequential/sequential.status
index 210a2d97c0ed5fa1fe3ca9652decb3981ffca997..95c80b9879394ae8a7e6b4908a4c8882fce955bf 100644 (file)
--- a/test/sequential/sequential.status
+++ b/test/sequential/sequential.status
@@ -17,6 +17,10 @@ test-http2-session-timeout                      : PASS,FLAKY
 # https://github.com/nodejs/node/issues/24403
 test-cli-syntax: PASS,FLAKY
 
+# does not work on IPv6 only host
+test-tls-psk-client: PASS,FLAKY
+test-tls-securepair-client: PASS,FLAKY
+
 [$system==win32]
 # https://github.com/nodejs/node/issues/22327
 test-http2-large-file: PASS, FLAKY