lldb-addversion-suffix-to-llvm-server-exec
authorLLVM Packaging Team <pkg-llvm-team@lists.alioth.debian.org>
Sat, 9 Mar 2019 06:10:15 +0000 (06:10 +0000)
committerMo Zhou <cdluminate@gmail.com>
Sat, 9 Mar 2019 06:10:15 +0000 (06:10 +0000)
lldb-server exec users always /usr/bin/lldb-server. Server is required
for any debugging with lldb which makes it unusable unless default version
package has been installed. Small changes to code and debian/rules allows
a workaround for lldb-server start up.

To use this one needs to add cmake defination during configure. eg
-DDEBIAN_VERSION_SUFFIX=-$(LLVM_VERSION)

Better implementation would be to use /usr/share/llvm-$(VERSION)/bin but
that change seems to require a big change to the path handling code
which could then break something else.

This probably should have upstream bug but I couldn't find any existing report.

Gbp-Pq: Name lldb-addversion-suffix-to-llvm-server-exec.patch

lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp

index 949cf19db658af3b43071baac14fba2da93c18c2..4dd6b43381b650652d8918ecffd5ddf79331e954 100644 (file)
@@ -32,6 +32,7 @@
 #include "lldb/Utility/StreamString.h"
 #include "llvm/ADT/SmallString.h"
 #include "llvm/Support/ScopedPrinter.h"
+#include "llvm/Config/llvm-config.h"
 
 // Project includes
 #include "ProcessGDBRemoteLog.h"
@@ -39,7 +40,7 @@
 #if defined(__APPLE__)
 #define DEBUGSERVER_BASENAME "debugserver"
 #else
-#define DEBUGSERVER_BASENAME "lldb-server"
+# define DEBUGSERVER_BASENAME    "lldb-server-"LLVM_VERSION_STRING
 #endif
 
 #if defined(HAVE_LIBCOMPRESSION)