ostree/fsck: Verify commit bindings for each ref
authorPhilip Withnall <withnall@endlessm.com>
Mon, 20 Nov 2017 12:51:28 +0000 (12:51 +0000)
committerAtomic Bot <atomic-devel@projectatomic.io>
Thu, 14 Dec 2017 14:18:44 +0000 (14:18 +0000)
Since an OSTree client will refuse to pull from a remote which it has
locally configured with a collection ID, if the commit on that remote
has incorrect or missing bindings, we’d better verify them as part of
fsck.

Signed-off-by: Philip Withnall <withnall@endlessm.com>
Closes: #1347
Approved by: cgwalters

src/ostree/ot-builtin-fsck.c

index 097af054060d7e9a6e5e4f29c93d08a39042fde9..6ebb3c83a542c4e8ea22a315dde02538b0a136bc 100644 (file)
@@ -159,6 +159,10 @@ fsck_commit_for_ref (OstreeRepo    *repo,
         return glnx_prefix_error (error, "Loading commit for ref %s", ref_name);
     }
 
+  /* Check its bindings. */
+  if (!ostree_cmd__private__ ()->ostree_repo_verify_bindings (collection_id, ref_name, commit, error))
+    return glnx_prefix_error (error, "Commit %s", checksum);
+
   return TRUE;
 }