Add informative messages after Q_ASSERTs for sockets in FileProviderSocketController...
authorClaudio Cambra <claudio.cambra@nextcloud.com>
Wed, 15 Mar 2023 15:18:15 +0000 (16:18 +0100)
committerClaudio Cambra <claudio.cambra@nextcloud.com>
Fri, 12 May 2023 05:28:47 +0000 (13:28 +0800)
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
src/gui/macOS/fileprovidersocketcontroller.cpp

index f3881c04fcf41057957d72141f273b2eb77adbac..8fd20fc9543537d6cfb58445b4606156161c952c 100644 (file)
@@ -53,6 +53,11 @@ void FileProviderSocketController::slotSocketDestroyed(const QObject * const obj
 void FileProviderSocketController::slotReadyRead()
 {
     Q_ASSERT(_socket);
+    if (!_socket) {
+        qCWarning(lcFileProviderSocketController) << "Cannot read data on dead socket";
+        return;
+    }
+
     while(_socket->canReadLine()) {
         const auto line = QString::fromUtf8(_socket->readLine().trimmed()).normalized(QString::NormalizationForm_C);
         qCDebug(lcFileProviderSocketController) << "Received message in file provider socket:" << line;
@@ -125,12 +130,22 @@ void FileProviderSocketController::sendMessage(const QString &message) const
 void FileProviderSocketController::start()
 {
     Q_ASSERT(_socket);
+    if (!_socket) {
+        qCWarning(lcFileProviderSocketController) << "Cannot start communication on dead socket";
+        return;
+    }
+
     requestFileProviderDomainInfo();
 }
 
 void FileProviderSocketController::requestFileProviderDomainInfo() const
 {
     Q_ASSERT(_socket);
+    if (!_socket) {
+        qCWarning(lcFileProviderSocketController) << "Cannot request file provider domain data on dead socket";
+        return;
+    }
+
     const auto requestMessage = QStringLiteral("SEND_FILE_PROVIDER_DOMAIN_IDENTIFIER");
     sendMessage(requestMessage);
 }