wayland: Drop create_dnd_surface
authorMatthias Clasen <mclasen@redhat.com>
Thu, 10 Nov 2022 15:05:26 +0000 (16:05 +0100)
committerMatthias Clasen <mclasen@redhat.com>
Fri, 6 Jan 2023 18:46:58 +0000 (13:46 -0500)
It is only used in one place.

gdk/wayland/gdkdrag-wayland.c
gdk/wayland/gdkprivate-wayland.h
gdk/wayland/gdksurface-wayland.c

index 297225e97a24632b3d9ae7cc436c4e5708be24a0..4af9d65e88b1615f8a8213a21a18399dc525f1bc 100644 (file)
@@ -367,10 +367,10 @@ _gdk_wayland_surface_drag_begin (GdkSurface         *surface,
   GdkWaylandDrag *drag_wayland;
   GdkDrag *drag;
   GdkSeat *seat;
-  GdkWaylandDisplay *display_wayland;
+  GdkDisplay *display;
   GdkCursor *cursor;
 
-  display_wayland = GDK_WAYLAND_DISPLAY (gdk_device_get_display (device));
+  display = gdk_device_get_display (device);
   seat = gdk_device_get_seat (device);
 
   drag_wayland = g_object_new (GDK_TYPE_WAYLAND_DRAG,
@@ -382,17 +382,13 @@ _gdk_wayland_surface_drag_begin (GdkSurface         *surface,
 
   drag = GDK_DRAG (drag_wayland);
 
-  drag_wayland->dnd_surface = create_dnd_surface (gdk_surface_get_display (surface));
+  drag_wayland->dnd_surface = _gdk_wayland_display_create_surface (display, GDK_SURFACE_DRAG, NULL, 0, 0, 100, 100);
   drag_wayland->dnd_wl_surface = gdk_wayland_surface_get_wl_surface (drag_wayland->dnd_surface);
-  
+
   gdk_wayland_drag_create_data_source (drag);
 
-  if (display_wayland->data_device_manager_version >=
-      WL_DATA_SOURCE_SET_ACTIONS_SINCE_VERSION)
-    {
-      wl_data_source_set_actions (drag_wayland->data_source,
-                                  gdk_to_wl_actions (actions));
-    }
+  if (GDK_WAYLAND_DISPLAY (display)->data_device_manager_version >= WL_DATA_SOURCE_SET_ACTIONS_SINCE_VERSION)
+    wl_data_source_set_actions (drag_wayland->data_source, gdk_to_wl_actions (actions));
 
   gdk_wayland_seat_set_drag (seat, drag);
 
index a551927be78369955a45e5cf5c7d06ee156f2a6b..e010066a04f9185852736a72b0de0e28c2b22379 100644 (file)
@@ -191,8 +191,6 @@ void gdk_wayland_surface_restore_shortcuts (GdkSurface *surface,
 
 void gdk_wayland_surface_update_scale (GdkSurface *surface);
 
-GdkSurface * create_dnd_surface (GdkDisplay *display);
-
 GdkModifierType gdk_wayland_keymap_get_gdk_modifiers (GdkKeymap *keymap,
                                                       guint32    mods);
 
index 03a0a39289721c5b983b91ab6fe9cb8abc046769..710082395cebae8f989031c89bd37858e12c3f33 100644 (file)
@@ -4873,19 +4873,6 @@ gdk_wayland_surface_restore_shortcuts (GdkSurface *surface,
   g_hash_table_remove (impl->shortcuts_inhibitors, gdk_seat);
 }
 
-GdkSurface *
-create_dnd_surface (GdkDisplay *display)
-{
-  GdkSurface *surface;
-
-  surface = _gdk_wayland_display_create_surface (display,
-                                                 GDK_SURFACE_DRAG,
-                                                 NULL,
-                                                 0, 0, 100, 100);
-
-  return surface;
-}
-
 #define LAST_PROP 1
 
 static void